tonyair/silverstripe-tagfield
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-tagfield synced 2024-10-22 11:05:32 +02:00
Code Issues Projects Releases Wiki Activity

FIX Use existing source datalist if available before creating a new one

Browse Source 
Fix for #171 - Issue when utilizing multiple of same parent class

Co-authored-by: Joe Madden <joe.madden@moosylvania.com>
This commit is contained in:
Joseph Madden 2021-10-14 19:38:53 -05:00 committed by GitHub
parent 43ccb16def
commit 55e03731bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/TagField.php
View File

@ -275,8 +275,12 @@ class TagField extends MultiSelectField
// Convert an array of values into a datalist of options
if (!$values instanceof SS_List) {
if (is_array($values) && !empty($values)) {
$values = DataList::create($dataClass)
->filter($this->getTitleField(), $values);
if (is_a($source, DataList::class)) {
$values = $source->filter($this->getTitleField(), $values);
} else {
$values = DataList::create($dataClass)
->filter($this->getTitleField(), $values);
}
} else {
$values = ArrayList::create();
}