tonyair/silverstripe-tagfield
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-tagfield synced 2024-06-29 07:59:26 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX Only retain unique tags (ignoring case sensitivity) when using the TagField::getTextbasedTags() method

Browse Source 
MINOR Removed redundant commented out code
This commit is contained in:
halkyon 2009-01-27 02:58:56 +00:00
parent 465c5716d7
commit 1d6b557678
1 changed files with 14 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
code/TagField.php
View File

@ -259,37 +259,14 @@ class TagField extends TextField {
return $tagArr;
}
/*protected function getTextbasedTags($searchString) {
$baseClass = ClassInfo::baseDataClass($this->getTagTopicClass());
$SQL_filter = sprintf("`%s`.`%s` LIKE '%%%s%%'",
$baseClass,
$this->tagFieldName,
Convert::raw2sql($searchString)
);
if($this->tagFilter) $SQL_filter .= ' AND ' . $this->tagFilter;
$allTopicObjs = DataObject::get($this->getTagTopicClass(), $SQL_filter, $this->tagSort);
$multipleTagsArr = ($allTopicObjs) ? array_values($allTopicObjs->map('ID', $this->tagFieldName)) : array();
$filteredTagArr = array();
foreach($multipleTagsArr as $multipleTags) {
$singleTagsArr = $this->splitTagsToArray($multipleTags);
foreach($singleTagsArr as $singleTag) {
// only add those tags of the whole string which
// match the search terms
if(stripos($singleTag, $searchString) !== false) {
$filteredTagArr[] = $singleTag;
}
}
}
// remove duplicates (retains case sensitive duplicates)
$filteredTagArr = array_unique($filteredTagArr);
return $filteredTagArr;
}*/
protected function getTextbasedTags($searchString) {
/**
* Return an array map of unique tags from
* the field name of the topic class.
*
* @param $searchString The text to search for tags
* @return array
*/
protected function getTextbasedTags($searchString) {
$baseClass = ClassInfo::baseDataClass($this->getTagTopicClass());
$SQL_filter = sprintf("`%s`.`%s` LIKE '%%%s%%'",
@ -299,9 +276,13 @@ class TagField extends TextField {
);
if($this->tagFilter) $SQL_filter .= ' AND ' . $this->tagFilter;
$sql = "Select `".$this->tagFieldName."` From `".$this->getTagTopicClass(). "` Where ".$SQL_filter;
$sql = "SELECT `" . $this->tagFieldName . "` FROM `".$this->getTagTopicClass() . "` WHERE ".$SQL_filter;
$map = DB::query($sql)->column();
return $map;
// remove duplicates (retains case sensitive duplicates)
$filteredMap = array_unique($map);
return $filteredMap;
}
public function setTagFilter($sql) {