tonyair/silverstripe-subsites
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-subsites synced 2024-10-22 11:05:55 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX SiteTreeSubsites->canEdit() returns true if no subsites are defined (meaning it won't prevent editing, but the permission might still be denied by SiteTree->canEdit())

Browse Source
This commit is contained in:
Ingo Schommer 2008-11-26 04:03:14 +00:00
parent cf926b437b
commit d0aafae7c5
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
code/SiteTreeSubsites.php
View File

@ -104,8 +104,14 @@ class SiteTreeSubsites extends DataObjectDecorator {
* @return boolean * @return boolean
*/ */
function canEdit($member = null) { function canEdit($member = null) {
if(!$member) $member = Member::currentUser(); if(!$member && $member !== FALSE) $member = Member::currentUser();
// if no subsites exist, member can edit from a subsites perspective
$allSubsites = DataObject::get('Subsite');
if(!$allSubsites) return true;
// otherwise get all allowed subsites, and check if the subsite
// this page belongs to is in the list
$allowedSubsites = Subsite::getSubsitesForMember($member); $allowedSubsites = Subsite::getSubsitesForMember($member);
if( if(
!$allowedSubsites !$allowedSubsites
@ -121,7 +127,7 @@ class SiteTreeSubsites extends DataObjectDecorator {
* @return boolean * @return boolean
*/ */
function canDelete($member = null) { function canDelete($member = null) {
if(!$member) $member = Member::currentUser(); if(!$member && $member !== FALSE) $member = Member::currentUser();
return $this->canEdit($member); return $this->canEdit($member);
} }
@ -130,7 +136,7 @@ class SiteTreeSubsites extends DataObjectDecorator {
* @return boolean * @return boolean
*/ */
function canAddChildren($member = null) { function canAddChildren($member = null) {
if(!$member) $member = Member::currentUser(); if(!$member && $member !== FALSE) $member = Member::currentUser();
return $this->canEdit($member); return $this->canEdit($member);
} }
@ -139,7 +145,7 @@ class SiteTreeSubsites extends DataObjectDecorator {
* @return boolean * @return boolean
*/ */
function canPublish($member = null) { function canPublish($member = null) {
if(!$member) $member = Member::currentUser(); if(!$member && $member !== FALSE) $member = Member::currentUser();
return $this->canEdit($member); return $this->canEdit($member);
} }