From 412b2709d22e635b46d579882358e9be8e321997 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Tue, 7 Feb 2023 17:16:51 +1300 Subject: [PATCH 1/2] API Deprecations --- src/Tasks/SubsiteMigrateFileTask.php | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/Tasks/SubsiteMigrateFileTask.php b/src/Tasks/SubsiteMigrateFileTask.php index c00c776..2904b80 100644 --- a/src/Tasks/SubsiteMigrateFileTask.php +++ b/src/Tasks/SubsiteMigrateFileTask.php @@ -4,9 +4,25 @@ namespace SilverStripe\Subsites\Tasks; use SilverStripe\Dev\Tasks\MigrateFileTask; use SilverStripe\Subsites\Model\Subsite; +use SilverStripe\Dev\Deprecation; +/** + * @deprecated 2.8.0 Will be removed without equivalent functionality to replace it + */ class SubsiteMigrateFileTask extends MigrateFileTask { + public function __construct() + { + Deprecation::withNoReplacement(function () { + Deprecation::notice( + '2.8.0', + 'Will be removed without equivalent functionality to replace it', + Deprecation::SCOPE_CLASS + ); + }); + parent::__construct(); + } + public function run($request) { $origDisableSubsiteFilter = Subsite::$disable_subsite_filter; From 05f775a78dff42d679f4b7623a96c2adb8aa9859 Mon Sep 17 00:00:00 2001 From: Loz Calver Date: Wed, 22 Feb 2023 16:07:57 +0000 Subject: [PATCH 2/2] NEW: Add extension hook for field-specific validation --- src/Forms/WildcardDomainField.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Forms/WildcardDomainField.php b/src/Forms/WildcardDomainField.php index 81feb01..90bf058 100644 --- a/src/Forms/WildcardDomainField.php +++ b/src/Forms/WildcardDomainField.php @@ -17,7 +17,7 @@ class WildcardDomainField extends TextField public function validate($validator) { if ($this->checkHostname($this->Value())) { - return true; + return $this->extendValidationResult(true, $validator); } $validator->validationError( @@ -25,7 +25,7 @@ class WildcardDomainField extends TextField _t('DomainNameField.INVALID_DOMAIN', 'Invalid domain name'), 'validation' ); - return false; + return $this->extendValidationResult(false, $validator); } /**