From 1975861aec218bc99a5f903335b5305cc7b59774 Mon Sep 17 00:00:00 2001 From: Garion Herman Date: Sun, 4 Jun 2017 15:05:59 +1200 Subject: [PATCH] Fix Duplicate to Subsite functionality. --- code/extensions/LeftAndMainSubsites.php | 7 +++---- code/extensions/SiteTreeSubsites.php | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/code/extensions/LeftAndMainSubsites.php b/code/extensions/LeftAndMainSubsites.php index 9079b41..51887bf 100644 --- a/code/extensions/LeftAndMainSubsites.php +++ b/code/extensions/LeftAndMainSubsites.php @@ -348,12 +348,11 @@ class LeftAndMainSubsites extends Extension /** * @param array $data - * @param Form $form */ - public function copytosubsite($data, $form) + public function copytosubsite($data) { - $page = DataObject::get_by_id(SiteTree::class, $data['ID']); - $subsite = DataObject::get_by_id('Subsite', $data['CopyToSubsiteID']); + $page = SiteTree::get()->byID($data['ID']); + $subsite = Subsite::get()->byID($data['CopyToSubsiteID']); $includeChildren = isset($data['CopyToSubsiteWithChildren']) ? $data['CopyToSubsiteWithChildren'] : false; $newPage = $page->duplicateToSubsite($subsite->ID, $includeChildren); diff --git a/code/extensions/SiteTreeSubsites.php b/code/extensions/SiteTreeSubsites.php index f281a19..5a450ed 100644 --- a/code/extensions/SiteTreeSubsites.php +++ b/code/extensions/SiteTreeSubsites.php @@ -12,7 +12,7 @@ use SilverStripe\Core\Convert; use SilverStripe\Forms\CheckboxField; use SilverStripe\Forms\DropdownField; use SilverStripe\Forms\FieldList; -use SilverStripe\Forms\InlineFormAction; +use SilverStripe\Forms\FormAction; use SilverStripe\Forms\ToggleCompositeField; use SilverStripe\ORM\DataExtension; use SilverStripe\ORM\DataObject; @@ -109,7 +109,7 @@ class SiteTreeSubsites extends DataExtension $isDefaultSubsite = $this->owner->SubsiteID == 0 || $this->owner->Subsite()->DefaultSite; if ($isDefaultSubsite && $subsitesMap) { - $fields->addFieldsToTab( + $fields->addFieldToTab( 'Root.Main', ToggleCompositeField::create('SubsiteOperations', _t('SiteTreeSubsites.SubsiteOperations', 'Subsite Operations'), @@ -118,7 +118,7 @@ class SiteTreeSubsites extends DataExtension 'Copy page to subsite'), $subsitesMap), new CheckboxField('CopyToSubsiteWithChildren', _t('SiteTreeSubsites.CopyToSubsiteWithChildren', 'Include children pages?')), - $copyAction = new InlineFormAction( + $copyAction = new FormAction( 'copytosubsite', _t('SiteTreeSubsites.CopyAction', 'Copy') )