Compare commits
45 Commits
Author | SHA1 | Date |
---|---|---|
Steve Boyd | df532bb741 | |
Will Rossiter | 1a87b18e71 | |
Guy Sartorelli | ee7f0e4d25 | |
Thomas Portelange | 66c1c09b74 | |
Thomas Portelange | d3d03d9f79 | |
Guy Sartorelli | f949becc6a | |
Thomas Portelange | ecaadc029e | |
Thomas Portelange | 05abb3f483 | |
Guy Sartorelli | f102cad3bf | |
Steve Boyd | d142dd77e4 | |
Steve Boyd | a919f8a317 | |
Steve Boyd | ea06c57cfb | |
Guy Sartorelli | d399c27722 | |
Steve Boyd | bf07381fc9 | |
Guy Sartorelli | 2ba8fe5c50 | |
Elliot Sawyer | f9dfa9f34c | |
Sam Minnée | c95b0105f5 | |
Michal Kleiner | 22d46a5ef8 | |
Robbie Averill | 10c85d4179 | |
Robbie Averill | b5a6416388 | |
Robbie Averill | 4edf7c23f8 | |
Mark Cameron | 3c8a06f5b9 | |
Robbie Averill | 34a3221097 | |
Sam Minnee | 1589089f5b | |
Sam Minnée | e919bdffd9 | |
Maxime Rainville | 40b9e876ba | |
NightjarNZ | c2569099ce | |
NightjarNZ | 5eacbe7842 | |
Maxime Rainville | 7add192ebf | |
NightjarNZ | 0fa6b0fde7 | |
NightjarNZ | 62ef14f711 | |
NightjarNZ | 0efd40e5c2 | |
NightjarNZ | 418c1178a1 | |
Daniel Hensby | 4167d9fd1a | |
Damian Mooyman | 6432ceea0d | |
Dylan Wagstaff | d315c61ea0 | |
Damian Mooyman | c346e64590 | |
Damian Mooyman | a38ab53e33 | |
Thomas Portelange | 978c371820 | |
Daniel Hensby | b36f3598bb | |
Mike Cochrane | 34648b9c05 | |
Daniel Hensby | f176bb0a39 | |
Damian Mooyman | 0e6aa26f55 | |
Damian Mooyman | ca4a76eaab | |
Damian Mooyman | 77e5a5e18c |
|
@ -0,0 +1,11 @@
|
|||
name: CI
|
||||
|
||||
on:
|
||||
push:
|
||||
pull_request:
|
||||
workflow_dispatch:
|
||||
|
||||
jobs:
|
||||
ci:
|
||||
name: CI
|
||||
uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1
|
|
@ -0,0 +1,16 @@
|
|||
name: Dispatch CI
|
||||
|
||||
on:
|
||||
# At 3:00 PM UTC, only on Sunday and Monday
|
||||
schedule:
|
||||
- cron: '0 15 * * 0,1'
|
||||
|
||||
jobs:
|
||||
dispatch-ci:
|
||||
name: Dispatch CI
|
||||
# Only run cron on the silverstripe account
|
||||
if: (github.event_name == 'schedule' && github.repository_owner == 'silverstripe') || (github.event_name != 'schedule')
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Dispatch CI
|
||||
uses: silverstripe/gha-dispatch-ci@v1
|
|
@ -0,0 +1,17 @@
|
|||
name: Keepalive
|
||||
|
||||
on:
|
||||
workflow_dispatch:
|
||||
# The 15th of every month at 3:50pm UTC
|
||||
schedule:
|
||||
- cron: '50 15 15 * *'
|
||||
|
||||
jobs:
|
||||
keepalive:
|
||||
name: Keepalive
|
||||
# Only run cron on the silverstripe account
|
||||
if: (github.event_name == 'schedule' && github.repository_owner == 'silverstripe') || (github.event_name != 'schedule')
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Keepalive
|
||||
uses: silverstripe/gha-keepalive@v1
|
|
@ -1,69 +0,0 @@
|
|||
inherit: true
|
||||
|
||||
checks:
|
||||
php:
|
||||
verify_property_names: true
|
||||
verify_argument_usable_as_reference: true
|
||||
verify_access_scope_valid: true
|
||||
useless_calls: true
|
||||
use_statement_alias_conflict: true
|
||||
variable_existence: true
|
||||
unused_variables: true
|
||||
unused_properties: true
|
||||
unused_parameters: true
|
||||
unused_methods: true
|
||||
unreachable_code: true
|
||||
too_many_arguments: true
|
||||
sql_injection_vulnerabilities: true
|
||||
simplify_boolean_return: true
|
||||
side_effects_or_types: true
|
||||
security_vulnerabilities: true
|
||||
return_doc_comments: true
|
||||
return_doc_comment_if_not_inferrable: true
|
||||
require_scope_for_properties: true
|
||||
require_scope_for_methods: true
|
||||
require_php_tag_first: true
|
||||
psr2_switch_declaration: true
|
||||
psr2_class_declaration: true
|
||||
property_assignments: true
|
||||
prefer_while_loop_over_for_loop: true
|
||||
precedence_mistakes: true
|
||||
precedence_in_conditions: true
|
||||
phpunit_assertions: true
|
||||
php5_style_constructor: true
|
||||
parse_doc_comments: true
|
||||
parameter_non_unique: true
|
||||
parameter_doc_comments: true
|
||||
param_doc_comment_if_not_inferrable: true
|
||||
optional_parameters_at_the_end: true
|
||||
one_class_per_file: true
|
||||
no_unnecessary_if: true
|
||||
no_trailing_whitespace: true
|
||||
no_property_on_interface: true
|
||||
no_non_implemented_abstract_methods: true
|
||||
no_error_suppression: true
|
||||
no_duplicate_arguments: true
|
||||
no_commented_out_code: true
|
||||
newline_at_end_of_file: true
|
||||
missing_arguments: true
|
||||
method_calls_on_non_object: true
|
||||
instanceof_class_exists: true
|
||||
foreach_traversable: true
|
||||
fix_line_ending: true
|
||||
fix_doc_comments: true
|
||||
duplication: true
|
||||
deprecated_code_usage: true
|
||||
deadlock_detection_in_loops: true
|
||||
code_rating: true
|
||||
closure_use_not_conflicting: true
|
||||
catch_class_exists: true
|
||||
blank_line_after_namespace_declaration: false
|
||||
avoid_multiple_statements_on_same_line: true
|
||||
avoid_duplicate_types: true
|
||||
avoid_conflicting_incrementers: true
|
||||
avoid_closing_tag: true
|
||||
assignment_of_null_return: true
|
||||
argument_type_checks: true
|
||||
|
||||
filter:
|
||||
paths: [code/*, tests/*]
|
40
.travis.yml
40
.travis.yml
|
@ -1,40 +0,0 @@
|
|||
language: php
|
||||
|
||||
dist: trusty
|
||||
|
||||
cache:
|
||||
directories:
|
||||
- $HOME/.composer/cache/files
|
||||
|
||||
php:
|
||||
- 5.6
|
||||
- 7.0
|
||||
- 7.1
|
||||
|
||||
env:
|
||||
global:
|
||||
- DB=SQLITE
|
||||
- PDO=1
|
||||
|
||||
matrix:
|
||||
fast_finish: true
|
||||
include:
|
||||
- php: 5.6
|
||||
env: PDO=0 PHPCS_TEST=1
|
||||
|
||||
before_script:
|
||||
# Init PHP
|
||||
- phpenv rehash
|
||||
- phpenv config-rm xdebug.ini
|
||||
- export PATH=~/.composer/vendor/bin:$PATH
|
||||
- echo 'memory_limit = 2048M' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini
|
||||
|
||||
# Install composer dependencies
|
||||
- composer validate
|
||||
- composer require --no-update silverstripe/recipe-cms:1.0.x-dev
|
||||
- composer install --prefer-dist --no-interaction --no-progress --no-suggest --optimize-autoloader --verbose --profile
|
||||
- if [[ $PHPCS_TEST ]]; then composer global require squizlabs/php_codesniffer:^3 --prefer-dist --no-interaction --no-progress --no-suggest -o; fi
|
||||
|
||||
script:
|
||||
- vendor/bin/phpunit vendor/silverstripe/framework/tests
|
||||
- if [[ $PHPCS_TEST ]]; then composer run-script lint; fi
|
|
@ -1,6 +1,7 @@
|
|||
# SQLite3 Module
|
||||
|
||||
[![Build Status](https://travis-ci.org/silverstripe-labs/silverstripe-sqlite3.png?branch=master)](https://travis-ci.org/silverstripe-labs/silverstripe-sqlite3)
|
||||
[![CI](https://github.com/silverstripe/silverstripe-sqlite3/actions/workflows/ci.yml/badge.svg)](https://github.com/silverstripe/silverstripe-sqlite3/actions/workflows/ci.yml)
|
||||
[![Silverstripe supported module](https://img.shields.io/badge/silverstripe-supported-0071C4.svg)](https://www.silverstripe.org/software/addons/silverstripe-commercially-supported-module-list/)
|
||||
|
||||
## Maintainer Contact
|
||||
|
||||
|
@ -9,7 +10,7 @@ Andreas Piening (Nickname: apiening)
|
|||
|
||||
## Requirements
|
||||
|
||||
* SilverStripe 4.0 or newer
|
||||
* Silverstripe 4.0 or newer
|
||||
|
||||
## Installation
|
||||
|
||||
|
@ -26,7 +27,6 @@ Either use the installer to automatically install SQLite or add this to your _co
|
|||
Make sure the webserver has sufficient privileges to write to that folder and that it is protected from
|
||||
external access.
|
||||
|
||||
|
||||
### Sample mysite/_config.php
|
||||
|
||||
```php
|
||||
|
|
|
@ -1,5 +1 @@
|
|||
<?php
|
||||
|
||||
use SilverStripe\Dev\Deprecation;
|
||||
|
||||
Deprecation::notification_version('1.4.0', 'sqlite3');
|
||||
|
|
|
@ -5,28 +5,28 @@ SilverStripe\Core\Injector\Injector:
|
|||
SQLite3PDODatabase:
|
||||
class: SilverStripe\SQLite\SQLite3Database
|
||||
properties:
|
||||
connector: %$PDOConnector
|
||||
schemaManager: %$SQLite3SchemaManager
|
||||
queryBuilder: %$SQLite3QueryBuilder
|
||||
connector: '%$PDOConnector'
|
||||
schemaManager: '%$SQLite3SchemaManager'
|
||||
queryBuilder: '%$SQLite3QueryBuilder'
|
||||
SQLite3Database:
|
||||
class: SilverStripe\SQLite\SQLite3Database
|
||||
properties:
|
||||
connector: %$SQLite3Connector
|
||||
schemaManager: %$SQLite3SchemaManager
|
||||
queryBuilder: %$SQLite3QueryBuilder
|
||||
connector: '%$SQLite3Connector'
|
||||
schemaManager: '%$SQLite3SchemaManager'
|
||||
queryBuilder: '%$SQLite3QueryBuilder'
|
||||
# Legacy connector names
|
||||
SQLiteDatabase:
|
||||
class: SilverStripe\SQLite\SQLite3Database
|
||||
properties:
|
||||
connector: %$SQLite3Connector
|
||||
schemaManager: %$SQLite3SchemaManager
|
||||
queryBuilder: %$SQLite3QueryBuilder
|
||||
connector: '%$SQLite3Connector'
|
||||
schemaManager: '%$SQLite3SchemaManager'
|
||||
queryBuilder: '%$SQLite3QueryBuilder'
|
||||
SQLitePDODatabase:
|
||||
class: SilverStripe\SQLite\SQLite3Database
|
||||
properties:
|
||||
connector: %$SQLite3Connector
|
||||
schemaManager: %$SQLite3SchemaManager
|
||||
queryBuilder: %$SQLite3QueryBuilder
|
||||
connector: '%$SQLite3Connector'
|
||||
schemaManager: '%$SQLite3SchemaManager'
|
||||
queryBuilder: '%$SQLite3QueryBuilder'
|
||||
SQLite3Connector:
|
||||
class: SilverStripe\SQLite\SQLite3Connector
|
||||
type: prototype
|
||||
|
|
|
@ -170,7 +170,7 @@ class SQLite3Connector extends DBConnector
|
|||
|
||||
public function escapeString($value)
|
||||
{
|
||||
return $this->dbConn->escapeString($value);
|
||||
return $this->dbConn->escapeString($value ?? '');
|
||||
}
|
||||
|
||||
public function selectDatabase($name)
|
||||
|
|
|
@ -60,6 +60,16 @@ class SQLite3Database extends Database
|
|||
*/
|
||||
protected $livesInMemory = false;
|
||||
|
||||
/**
|
||||
* @var bool
|
||||
*/
|
||||
protected $transactionNesting = 0;
|
||||
|
||||
/**
|
||||
* @var array
|
||||
*/
|
||||
protected $transactionSavepoints = [];
|
||||
|
||||
/**
|
||||
* List of default pragma values
|
||||
*
|
||||
|
@ -348,7 +358,7 @@ class SQLite3Database extends Database
|
|||
"(Title LIKE '%$relevanceKeywords%' OR MenuTitle LIKE '%$relevanceKeywords%'"
|
||||
. " OR Content LIKE '%$relevanceKeywords%' OR MetaDescription LIKE '%$relevanceKeywords%')"
|
||||
. " + (Title LIKE '%$htmlEntityRelevanceKeywords%' OR MenuTitle LIKE '%$htmlEntityRelevanceKeywords%'"
|
||||
. " OR Content LIKE '%$htmlEntityRelevanceKeywords%' OR MetaDescriptio "
|
||||
. " OR Content LIKE '%$htmlEntityRelevanceKeywords%' OR MetaDescription "
|
||||
. " LIKE '%$htmlEntityRelevanceKeywords%')";
|
||||
$relevance[$fileClass] = "(Name LIKE '%$relevanceKeywords%' OR Title LIKE '%$relevanceKeywords%')";
|
||||
} else {
|
||||
|
@ -401,7 +411,7 @@ class SQLite3Database extends Database
|
|||
$queries[$class]->setFrom('"'.DataObject::getSchema()->baseDataTable($class).'"');
|
||||
$queries[$class]->setSelect(array());
|
||||
foreach ($select[$class] as $clause) {
|
||||
if (preg_match('/^(.*) +AS +"?([^"]*)"?/i', $clause, $matches)) {
|
||||
if (preg_match('/^(.*) +AS +"?([^"]*)"?/i', $clause ?? '', $matches)) {
|
||||
$queries[$class]->selectField($matches[1], $matches[2]);
|
||||
} else {
|
||||
$queries[$class]->selectField(str_replace('"', '', $clause));
|
||||
|
@ -450,6 +460,19 @@ class SQLite3Database extends Database
|
|||
return version_compare($this->getVersion(), '3.6', '>=');
|
||||
}
|
||||
|
||||
/**
|
||||
* Does this database support transaction modes?
|
||||
*
|
||||
* SQLite doesn't support transaction modes.
|
||||
*
|
||||
* @param string $mode
|
||||
* @return bool
|
||||
*/
|
||||
public function supportsTransactionMode(string $mode): bool
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
public function supportsExtensions($extensions = array('partitions', 'tablespaces', 'clustering'))
|
||||
{
|
||||
if (isset($extensions['partitions'])) {
|
||||
|
@ -465,26 +488,148 @@ class SQLite3Database extends Database
|
|||
|
||||
public function transactionStart($transaction_mode = false, $session_characteristics = false)
|
||||
{
|
||||
$this->query('BEGIN');
|
||||
if ($this->transactionDepth()) {
|
||||
$this->transactionSavepoint('NESTEDTRANSACTION' . $this->transactionDepth());
|
||||
} else {
|
||||
$this->query('BEGIN');
|
||||
$this->transactionDepthIncrease();
|
||||
}
|
||||
}
|
||||
|
||||
public function transactionSavepoint($savepoint)
|
||||
{
|
||||
$this->query("SAVEPOINT \"$savepoint\"");
|
||||
$this->transactionDepthIncrease($savepoint);
|
||||
}
|
||||
|
||||
/**
|
||||
* Fetch the name of the most recent savepoint
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
protected function getTransactionSavepointName()
|
||||
{
|
||||
return end($this->transactionSavepoints);
|
||||
}
|
||||
|
||||
public function transactionRollback($savepoint = false)
|
||||
{
|
||||
// Named transaction
|
||||
if ($savepoint) {
|
||||
$this->query("ROLLBACK TO $savepoint;");
|
||||
$this->transactionDepthDecrease();
|
||||
return true;
|
||||
}
|
||||
|
||||
// Fail if transaction isn't available
|
||||
if (!$this->transactionDepth()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
if ($this->transactionIsNested()) {
|
||||
$this->transactionRollback($this->getTransactionSavepointName());
|
||||
} else {
|
||||
$this->query('ROLLBACK;');
|
||||
$this->transactionDepthDecrease();
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
public function transactionDepth()
|
||||
{
|
||||
return $this->transactionNesting;
|
||||
}
|
||||
|
||||
public function transactionEnd($chain = false)
|
||||
{
|
||||
$this->query('COMMIT;');
|
||||
// Fail if transaction isn't available
|
||||
if (!$this->transactionDepth()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
if ($this->transactionIsNested()) {
|
||||
$savepoint = $this->getTransactionSavepointName();
|
||||
$this->query('RELEASE ' . $savepoint);
|
||||
$this->transactionDepthDecrease();
|
||||
} else {
|
||||
$this->query('COMMIT;');
|
||||
$this->resetTransactionNesting();
|
||||
}
|
||||
|
||||
if ($chain) {
|
||||
$this->transactionStart();
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* Indicate whether or not the current transaction is nested
|
||||
* Returns false if there are no transactions, or the open
|
||||
* transaction is the 'outer' transaction, i.e. not nested.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
protected function transactionIsNested()
|
||||
{
|
||||
return $this->transactionNesting > 1;
|
||||
}
|
||||
|
||||
/**
|
||||
* Increase the nested transaction level by one
|
||||
* savepoint tracking is optional because BEGIN
|
||||
* opens a transaction, but is not a named reference
|
||||
*
|
||||
* @param string $savepoint
|
||||
*/
|
||||
protected function transactionDepthIncrease($savepoint = null)
|
||||
{
|
||||
++$this->transactionNesting;
|
||||
if ($savepoint) {
|
||||
array_push($this->transactionSavepoints, $savepoint);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Decrease the nested transaction level by one
|
||||
* and reduce the savepoint tracking if we are
|
||||
* nesting, as the last one is no longer valid
|
||||
*/
|
||||
protected function transactionDepthDecrease()
|
||||
{
|
||||
if ($this->transactionIsNested()) {
|
||||
array_pop($this->transactionSavepoints);
|
||||
}
|
||||
--$this->transactionNesting;
|
||||
}
|
||||
|
||||
/**
|
||||
* In error condition, set transactionNesting to zero
|
||||
*/
|
||||
protected function resetTransactionNesting()
|
||||
{
|
||||
$this->transactionNesting = 0;
|
||||
$this->transactionSavepoints = [];
|
||||
}
|
||||
|
||||
public function query($sql, $errorLevel = E_USER_ERROR)
|
||||
{
|
||||
return parent::query($sql, $errorLevel);
|
||||
}
|
||||
|
||||
public function preparedQuery($sql, $parameters, $errorLevel = E_USER_ERROR)
|
||||
{
|
||||
return parent::preparedQuery($sql, $parameters, $errorLevel);
|
||||
}
|
||||
|
||||
/**
|
||||
* Inspect a SQL query prior to execution
|
||||
* @deprecated 2.2.0:3.0.0
|
||||
* @param string $sql
|
||||
*/
|
||||
protected function inspectQuery($sql)
|
||||
{
|
||||
// no-op
|
||||
}
|
||||
|
||||
public function clearTable($table)
|
||||
|
@ -527,7 +672,7 @@ class SQLite3Database extends Database
|
|||
|
||||
public function formattedDatetimeClause($date, $format)
|
||||
{
|
||||
preg_match_all('/%(.)/', $format, $matches);
|
||||
preg_match_all('/%(.)/', $format ?? '', $matches);
|
||||
foreach ($matches[1] as $match) {
|
||||
if (array_search($match, array('Y', 'm', 'd', 'H', 'i', 's', 'U')) === false) {
|
||||
user_error('formattedDatetimeClause(): unsupported format character %' . $match, E_USER_WARNING);
|
||||
|
@ -549,9 +694,9 @@ class SQLite3Database extends Database
|
|||
$modifiers[] = 'localtime';
|
||||
}
|
||||
|
||||
if (preg_match('/^now$/i', $date)) {
|
||||
if (preg_match('/^now$/i', $date ?? '')) {
|
||||
$date = "'now'";
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date)) {
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date ?? '')) {
|
||||
$date = "'$date'";
|
||||
}
|
||||
|
||||
|
@ -566,9 +711,9 @@ class SQLite3Database extends Database
|
|||
$modifiers[] = 'localtime';
|
||||
}
|
||||
|
||||
if (preg_match('/^now$/i', $date)) {
|
||||
if (preg_match('/^now$/i', $date ?? '')) {
|
||||
$date = "'now'";
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date)) {
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date ?? '')) {
|
||||
$date = "'$date'";
|
||||
}
|
||||
|
||||
|
@ -588,15 +733,15 @@ class SQLite3Database extends Database
|
|||
$modifiers2[] = 'localtime';
|
||||
}
|
||||
|
||||
if (preg_match('/^now$/i', $date1)) {
|
||||
if (preg_match('/^now$/i', $date1 ?? '')) {
|
||||
$date1 = "'now'";
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date1)) {
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date1 ?? '')) {
|
||||
$date1 = "'$date1'";
|
||||
}
|
||||
|
||||
if (preg_match('/^now$/i', $date2)) {
|
||||
if (preg_match('/^now$/i', $date2 ?? '')) {
|
||||
$date2 = "'now'";
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date2)) {
|
||||
} elseif (preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/i', $date2 ?? '')) {
|
||||
$date2 = "'$date2'";
|
||||
}
|
||||
|
||||
|
|
|
@ -58,6 +58,11 @@ class SQLite3Query extends Query
|
|||
*/
|
||||
public function numRecords()
|
||||
{
|
||||
// Some queries are not iterable using fetchArray like CREATE statement
|
||||
if (!$this->handle->numColumns()) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
$this->handle->reset();
|
||||
$c=0;
|
||||
while ($this->handle->fetchArray()) {
|
||||
|
|
|
@ -2,10 +2,11 @@
|
|||
|
||||
namespace SilverStripe\SQLite;
|
||||
|
||||
use Exception;
|
||||
use SilverStripe\Control\Director;
|
||||
use SilverStripe\Dev\Debug;
|
||||
use SilverStripe\ORM\Connect\DBSchemaManager;
|
||||
use Exception;
|
||||
use SQLite3;
|
||||
|
||||
/**
|
||||
* SQLite schema manager class
|
||||
|
@ -231,7 +232,7 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
if (self::$vacuum) {
|
||||
$this->query('VACUUM', E_USER_NOTICE);
|
||||
$message = $this->database->getConnector()->getLastError();
|
||||
if (preg_match('/authoriz/', $message)) {
|
||||
if (preg_match('/authoriz/', $message ?? '')) {
|
||||
$this->alterationMessage("VACUUM | $message", "error");
|
||||
} else {
|
||||
$this->alterationMessage("VACUUMing", "repaired");
|
||||
|
@ -275,21 +276,22 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
}
|
||||
|
||||
$queries = array(
|
||||
"BEGIN TRANSACTION",
|
||||
"CREATE TABLE \"{$tableName}_alterfield_{$fieldName}\"(" . implode(',', $newColsSpec) . ")",
|
||||
"INSERT INTO \"{$tableName}_alterfield_{$fieldName}\" SELECT {$fieldNameList} FROM \"$tableName\"",
|
||||
"DROP TABLE \"$tableName\"",
|
||||
"ALTER TABLE \"{$tableName}_alterfield_{$fieldName}\" RENAME TO \"$tableName\"",
|
||||
"COMMIT"
|
||||
);
|
||||
|
||||
// Remember original indexes
|
||||
$indexList = $this->indexList($tableName);
|
||||
|
||||
// Then alter the table column
|
||||
foreach ($queries as $query) {
|
||||
$this->query($query.';');
|
||||
}
|
||||
$database = $this->database;
|
||||
$database->withTransaction(function () use ($database, $queries, $indexList) {
|
||||
foreach ($queries as $query) {
|
||||
$database->query($query . ';');
|
||||
}
|
||||
});
|
||||
|
||||
// Recreate the indexes
|
||||
foreach ($indexList as $indexName => $indexSpec) {
|
||||
|
@ -318,21 +320,22 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
$oldColsStr = implode(',', $oldCols);
|
||||
$newColsSpecStr = implode(',', $newColsSpec);
|
||||
$queries = array(
|
||||
"BEGIN TRANSACTION",
|
||||
"CREATE TABLE \"{$tableName}_renamefield_{$oldName}\" ({$newColsSpecStr})",
|
||||
"INSERT INTO \"{$tableName}_renamefield_{$oldName}\" SELECT {$oldColsStr} FROM \"$tableName\"",
|
||||
"DROP TABLE \"$tableName\"",
|
||||
"ALTER TABLE \"{$tableName}_renamefield_{$oldName}\" RENAME TO \"$tableName\"",
|
||||
"COMMIT"
|
||||
);
|
||||
|
||||
// Remember original indexes
|
||||
$oldIndexList = $this->indexList($tableName);
|
||||
|
||||
// Then alter the table column
|
||||
foreach ($queries as $query) {
|
||||
$this->query($query.';');
|
||||
}
|
||||
$database = $this->database;
|
||||
$database->withTransaction(function () use ($database, $queries) {
|
||||
foreach ($queries as $query) {
|
||||
$database->query($query . ';');
|
||||
}
|
||||
});
|
||||
|
||||
// Recreate the indexes
|
||||
foreach ($oldIndexList as $indexName => $indexSpec) {
|
||||
|
@ -368,7 +371,7 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
if ($sqlCreate && $sqlCreate['sql']) {
|
||||
preg_match(
|
||||
'/^[\s]*CREATE[\s]+TABLE[\s]+[\'"]?[a-zA-Z0-9_\\\]+[\'"]?[\s]*\((.+)\)[\s]*$/ims',
|
||||
$sqlCreate['sql'],
|
||||
$sqlCreate['sql'] ?? '',
|
||||
$matches
|
||||
);
|
||||
$fields = isset($matches[1])
|
||||
|
@ -429,6 +432,15 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
return $this->buildSQLiteIndexName($table, $index);
|
||||
}
|
||||
|
||||
protected function convertIndexSpec($indexSpec)
|
||||
{
|
||||
$supportedIndexTypes = ['index', 'unique'];
|
||||
if (isset($indexSpec['type']) && !in_array($indexSpec['type'], $supportedIndexTypes)) {
|
||||
$indexSpec['type'] = 'index';
|
||||
}
|
||||
return parent::convertIndexSpec($indexSpec);
|
||||
}
|
||||
|
||||
public function indexList($table)
|
||||
{
|
||||
$indexList = array();
|
||||
|
@ -540,7 +552,18 @@ class SQLite3SchemaManager extends DBSchemaManager
|
|||
|
||||
// Set default
|
||||
if (!empty($values['default'])) {
|
||||
$default = str_replace(array('"', "'", "\\", "\0"), "", $values['default']);
|
||||
/*
|
||||
On escaping strings:
|
||||
|
||||
https://www.sqlite.org/lang_expr.html
|
||||
"A string constant is formed by enclosing the string in single quotes ('). A single quote within
|
||||
the string can be encoded by putting two single quotes in a row - as in Pascal. C-style escapes
|
||||
using the backslash character are not supported because they are not standard SQL."
|
||||
|
||||
Also, there is a nifty PHP function for this. However apparently one must still be cautious of
|
||||
the null character ('\0' or 0x0), as per https://bugs.php.net/bug.php?id=63419
|
||||
*/
|
||||
$default = SQLite3::escapeString(str_replace("\0", "", $values['default']));
|
||||
return "TEXT DEFAULT '$default'";
|
||||
} else {
|
||||
return 'TEXT';
|
||||
|
|
|
@ -18,7 +18,7 @@
|
|||
"silverstripe/vendor-plugin": "^1.0"
|
||||
},
|
||||
"require-dev": {
|
||||
"phpunit/phpunit": "^5.7"
|
||||
"squizlabs/php_codesniffer": "^3"
|
||||
},
|
||||
"autoload": {
|
||||
"psr-4": {
|
||||
|
|
|
@ -1,11 +1,12 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<ruleset name="SilverStripe">
|
||||
<description>CodeSniffer ruleset for SilverStripe coding conventions.</description>
|
||||
<description>CodeSniffer ruleset for SilverStripe coding conventions.</description>
|
||||
|
||||
<!-- base rules are PSR-2 -->
|
||||
<rule ref="PSR2" >
|
||||
<!-- Current exclusions -->
|
||||
<exclude name="PSR1.Methods.CamelCapsMethodName" />
|
||||
</rule>
|
||||
<file>code</file>
|
||||
|
||||
<!-- base rules are PSR-2 -->
|
||||
<rule ref="PSR2" >
|
||||
<!-- Current exclusions -->
|
||||
<exclude name="PSR1.Methods.CamelCapsMethodName" />
|
||||
</rule>
|
||||
</ruleset>
|
||||
|
||||
|
|
|
@ -1,16 +0,0 @@
|
|||
<phpunit bootstrap="vendor/silverstripe/cms/tests/bootstrap.php" colors="true">
|
||||
|
||||
<testsuite name="Default">
|
||||
<directory>tests</directory>
|
||||
</testsuite>
|
||||
|
||||
<filter>
|
||||
<whitelist addUncoveredFilesFromWhitelist="true">
|
||||
<directory suffix=".php">.</directory>
|
||||
<exclude>
|
||||
<directory suffix=".php">tests/</directory>
|
||||
</exclude>
|
||||
</whitelist>
|
||||
</filter>
|
||||
|
||||
</phpunit>
|
Loading…
Reference in New Issue