MNT: use short array syntax

This commit is contained in:
Will Rossiter 2023-09-13 06:50:09 +12:00
parent 6d2ec29d32
commit fa8366e706
No known key found for this signature in database
GPG Key ID: 7FD2A809B22259EF
3 changed files with 17 additions and 17 deletions

View File

@ -41,15 +41,15 @@ class EditableSpamProtectionField extends EditableFormField
* @var array * @var array
* @config * @config
*/ */
private static $check_fields = array( private static $check_fields = [
EditableEmailField::class, EditableEmailField::class,
EditableTextField::class, EditableTextField::class,
EditableNumericField::class EditableNumericField::class
); ];
private static $db = array( private static $db = [
'SpamFieldSettings' => 'Text' 'SpamFieldSettings' => 'Text'
); ];
/** /**
* @var FormField * @var FormField
@ -69,7 +69,7 @@ class EditableSpamProtectionField extends EditableFormField
} }
// Extract saved field mappings and update this field. // Extract saved field mappings and update this field.
$fieldMapping = array(); $fieldMapping = [];
foreach ($this->getCandidateFields() as $otherField) { foreach ($this->getCandidateFields() as $otherField) {
$mapSetting = "Map-{$otherField->Name}"; $mapSetting = "Map-{$otherField->Name}";
$spamField = $this->spamMapValue($mapSetting); $spamField = $this->spamMapValue($mapSetting);
@ -106,7 +106,7 @@ class EditableSpamProtectionField extends EditableFormField
// Get list of all configured classes available for spam detection // Get list of all configured classes available for spam detection
$types = $this->config()->get('check_fields'); $types = $this->config()->get('check_fields');
$typesInherit = array(); $typesInherit = [];
foreach ($types as $type) { foreach ($types as $type) {
$subTypes = ClassInfo::subclassesFor($type); $subTypes = ClassInfo::subclassesFor($type);
$typesInherit = array_merge($typesInherit, $subTypes); $typesInherit = array_merge($typesInherit, $subTypes);
@ -132,7 +132,7 @@ class EditableSpamProtectionField extends EditableFormField
{ {
$fieldMap = json_decode($this->SpamFieldSettings ?? '', true); $fieldMap = json_decode($this->SpamFieldSettings ?? '', true);
if (empty($fieldMap)) { if (empty($fieldMap)) {
$fieldMap = array(); $fieldMap = [];
} }
foreach ($this->record as $key => $value) { foreach ($this->record as $key => $value) {
@ -202,7 +202,7 @@ class EditableSpamProtectionField extends EditableFormField
{ {
$map = json_decode($this->SpamFieldSettings ?? '', true); $map = json_decode($this->SpamFieldSettings ?? '', true);
if (empty($map)) { if (empty($map)) {
$map = array(); $map = [];
} }
if (array_key_exists($mapSetting, $map ?? [])) { if (array_key_exists($mapSetting, $map ?? [])) {

View File

@ -14,19 +14,19 @@ class CommentSpamProtection extends Extension
{ {
public function alterCommentForm(&$form) public function alterCommentForm(&$form)
{ {
$form->enableSpamProtection(array( $form->enableSpamProtection([
'name' => 'IsSpam', 'name' => 'IsSpam',
'mapping' => array( 'mapping' => [
'Name' => 'authorName', 'Name' => 'authorName',
'Email' => 'authorEmail', 'Email' => 'authorEmail',
'URL' => 'authorUrl', 'URL' => 'authorUrl',
'Comment' => 'body', 'Comment' => 'body',
'ReturnURL' => 'contextUrl' 'ReturnURL' => 'contextUrl'
), ],
'checks' => array( 'checks' => [
'spam', 'spam',
'profanity' 'profanity'
) ]
)); ]);
} }
} }

View File

@ -37,7 +37,7 @@ class FormSpamProtectionExtension extends Extension
* *
* @var array $mappable_fields * @var array $mappable_fields
*/ */
private static $mappable_fields = array( private static $mappable_fields = [
'id', 'id',
'title', 'title',
'body', 'body',
@ -48,7 +48,7 @@ class FormSpamProtectionExtension extends Extension
'authorUrl', 'authorUrl',
'authorIp', 'authorIp',
'authorId' 'authorId'
); ];
/** /**
* @config * @config
@ -88,7 +88,7 @@ class FormSpamProtectionExtension extends Extension
* @throws LogicException when get_protector method returns NULL. * @throws LogicException when get_protector method returns NULL.
* @return Object * @return Object
*/ */
public function enableSpamProtection($options = array()) public function enableSpamProtection($options = [])
{ {
// captcha form field name (must be unique) // captcha form field name (must be unique)