Move stub classes to their own files, run PSR-2 linter

code/SpamProtectorManager.php

@@ -12,7 +12,8 @@ class SpamProtectorManager
 
     public static function set_spam_protector($protector)
     {
-        Deprecation::notice('1.1',
+        Deprecation::notice(
+            '1.1',
             'SpamProtectorManager::set_spam_protector() is deprecated. '.
             'Use the new config system. FormSpamProtectorExtension.default_spam_protector'
         );
@@ -22,16 +23,19 @@ class SpamProtectorManager
 
     public static function get_spam_protector()
     {
-        Deprecation::notice('1.1',
+        Deprecation::notice(
+            '1.1',
             'SpamProtectorManager::get_spam_protector() is deprecated'.
-            'Use the new config system. FormSpamProtectorExtension.default_spam_protector');
+            'Use the new config system. FormSpamProtectorExtension.default_spam_protector'
+        );
 
         return self::$spam_protector;
     }
     
     public static function update_form($form, $before = null, $fieldsToSpamServiceMapping = array(), $title = null, $rightTitle = null)
     {
-        Deprecation::notice('1.1',
+        Deprecation::notice(
+            '1.1',
             'SpamProtectorManager::update_form is deprecated'.
             'Please use $form->enableSpamProtection() for adding spamprotection'
         );

tests/EditableSpamProtectionFieldTest.php

@@ -9,18 +9,19 @@ class EditableSpamProtectionFieldTest extends SapphireTest
     {
         parent::setUp();
 
+        if (!class_exists('EditableSpamProtectionField')) {
+            $this->markTestSkipped('"userforms" module not installed');
+        }
+
         Config::inst()->update(
-            'FormSpamProtectionExtension', 'default_spam_protector',
+            'FormSpamProtectionExtension',
+            'default_spam_protector',
             'EditableSpamProtectionFieldTest_Protector'
         );
     }
 
     public function testValidateFieldDoesntAddErrorOnSuccess()
     {
-        if (!class_exists('EditableSpamProtectionField')) {
-            $this->markTestSkipped('"userforms" module not installed');
-        }
-
         $formMock = $this->getFormMock();
         $formFieldMock = $this->getEditableFormFieldMock();
 
@@ -39,10 +40,6 @@ class EditableSpamProtectionFieldTest extends SapphireTest
 
     public function testValidateFieldAddsErrorFromField()
     {
-        if (!class_exists('EditableSpamProtectionField')) {
-            $this->markTestSkipped('"userforms" module not installed');
-        }
-
         $formMock = $this->getFormMock();
         $formFieldMock = $this->getEditableFormFieldMock();
 
@@ -57,17 +54,14 @@ class EditableSpamProtectionFieldTest extends SapphireTest
         $formMock
             ->expects($this->once())
             ->method('addErrorMessage')
-            ->with($this->anything(), $this->stringContains('some field message'), $this->anything(), $this->anything());;
+            ->with($this->anything(), $this->stringContains('some field message'), $this->anything(), $this->anything());
+        ;
 
         $formFieldMock->validateField(array('MyField' => null), $formMock);
     }
 
     public function testValidateFieldAddsDefaultError()
     {
-        if (!class_exists('EditableSpamProtectionField')) {
-            $this->markTestSkipped('"userforms" module not installed');
-        }
-
         $formMock = $this->getFormMock();
         $formFieldMock = $this->getEditableFormFieldMock();
 
@@ -119,17 +113,4 @@ class EditableSpamProtectionFieldTest extends SapphireTest
 
         return $editableFormFieldMock;
     }
-
-}
-
-class EditableSpamProtectionFieldTest_Protector implements SpamProtector, TestOnly
-{
-    public function getFormField($name = null, $title = null, $value = null)
-    {
-        return new TextField($name, 'Foo', $value);
-    }
-
-    public function setFieldMapping($fieldMapping)
-    {
-    }
 }

tests/FormSpamProtectionExtensionTest.php

@@ -20,15 +20,15 @@ class FormSpamProtectionExtensionTest extends SapphireTest
             new TextField('Title'),
             new TextField('Comment'),
             new TextField('URL')
-        ), new FieldList()
-        );
+        ), new FieldList());
         $this->form->disableSecurityToken();
     }
 
     public function testEnableSpamProtection()
     {
         Config::inst()->update(
-            'FormSpamProtectionExtension', 'default_spam_protector',
+            'FormSpamProtectionExtension',
+            'default_spam_protector',
             'FormSpamProtectionExtensionTest_FooProtector'
         );
 
@@ -96,49 +96,3 @@ class FormSpamProtectionExtensionTest extends SapphireTest
         $this->assertEquals('Foo', $fields[3]->Title());
     }
 }
-
-/**
- * @package spamprotection
- */
-class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
-{
-    public function getFormField($name = null, $title = null, $value = null)
-    {
-        return new TextField($name, $title, $value);
-    }
-
-    public function setFieldMapping($fieldMapping)
-    {
-    }
-}
-
-/**
- * @package spamprotection
- */
-class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
-{
-    public function getFormField($name = null, $title = null, $value = null)
-    {
-        $title = $title ?: 'Bar';
-        return new TextField($name, $title, $value);
-    }
-
-    public function setFieldMapping($fieldMapping)
-    {
-    }
-}
-
-/**
- * @package spamprotection
- */
-class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
-{
-    public function getFormField($name = null, $title = null, $value = null)
-    {
-        return new TextField($name, 'Foo', $value);
-    }
-
-    public function setFieldMapping($fieldMapping)
-    {
-    }
-}

tests/Stub/EditableSpamProtectionFieldTest_Protector.php

@@ -0,0 +1,13 @@
+<?php
+
+class EditableSpamProtectionFieldTest_Protector implements SpamProtector, TestOnly
+{
+    public function getFormField($name = null, $title = null, $value = null)
+    {
+        return new TextField($name, 'Foo', $value);
+    }
+
+    public function setFieldMapping($fieldMapping)
+    {
+    }
+}

tests/Stub/FormSpamProtectionExtensionTest_BarProtector.php

@@ -0,0 +1,17 @@
+<?php
+
+/**
+ * @package spamprotection
+ */
+class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
+{
+    public function getFormField($name = null, $title = null, $value = null)
+    {
+        $title = $title ?: 'Bar';
+        return new TextField($name, $title, $value);
+    }
+
+    public function setFieldMapping($fieldMapping)
+    {
+    }
+}

tests/Stub/FormSpamProtectionExtensionTest_BazProtector.php

@@ -0,0 +1,16 @@
+<?php
+
+/**
+ * @package spamprotection
+ */
+class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
+{
+    public function getFormField($name = null, $title = null, $value = null)
+    {
+        return new TextField($name, $title, $value);
+    }
+
+    public function setFieldMapping($fieldMapping)
+    {
+    }
+}

tests/Stub/FormSpamProtectionExtensionTest_FooProtector.php

@@ -0,0 +1,16 @@
+<?php
+
+/**
+ * @package spamprotection
+ */
+class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
+{
+    public function getFormField($name = null, $title = null, $value = null)
+    {
+        return new TextField($name, 'Foo', $value);
+    }
+
+    public function setFieldMapping($fieldMapping)
+    {
+    }
+}