tonyair/silverstripe-spamprotection
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-spamprotection.git synced 2024-06-14 16:41:31 +02:00
Code Issues Projects Releases Wiki Activity

FIX Ensure getIcon returns exposed resource URL for icon

Browse Source
This commit is contained in:
Robbie Averill 2017-11-03 11:07:41 +13:00
parent 654f45292c
commit 47eef922c7
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
code/EditableSpamProtectionField.php
View File

@ -259,15 +259,14 @@ class EditableSpamProtectionField extends EditableFormField
public function getIcon() public function getIcon()
{ {
// Get the end of the full qualified class name
$shortClass = end(explode("\\", __CLASS__));
$resource = ModuleLoader::getModule('silverstripe/spamprotection') $resource = ModuleLoader::getModule('silverstripe/spamprotection')
->getResource('images/' . strtolower($shortClass) . '.png'); ->getResource('images/editablespamprotectionfield.png');
if ($resource->exists()) { if (!$resource->exists()) {
return $resource->getRelativePath(); return '';
} }
return $resource->getURL();
} }
public function showInReports() public function showInReports()

7
tests/EditableSpamProtectionFieldTest.php
View File

@ -111,6 +111,13 @@ class EditableSpamProtectionFieldTest extends SapphireTest
$this->assertSame('baz', $field->spamMapValue('bar')); $this->assertSame('baz', $field->spamMapValue('bar'));
} }
public function testGetIcon()
{
$field = new EditableSpamProtectionField;
$this->assertContains('/images/editablespamprotectionfield.png', $field->getIcon());
}
protected function getFormMock() protected function getFormMock()
{ {
$formMock = $this->getMockBuilder(Form::class) $formMock = $this->getMockBuilder(Form::class)