From e938c60e9a23a019ba67ba23da7ebb3ac21df59e Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Sun, 4 Mar 2012 22:10:25 +0100
Subject: [PATCH 01/20] ENHANCEMENT Using chosen.js selection instead of a
 TreeDropdownField to select groups in SiteConfig->getCMSFields() and
 SiteTree->getCMSFields()

---
 code/model/SiteConfig.php | 12 +++++++++---
 code/model/SiteTree.php   |  9 +++++++--
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/code/model/SiteConfig.php b/code/model/SiteConfig.php
index ae23562f..1d9d537b 100644
--- a/code/model/SiteConfig.php
+++ b/code/model/SiteConfig.php
@@ -44,6 +44,9 @@ class SiteConfig extends DataObject implements PermissionProvider {
 	function getCMSFields() {
 		Requirements::javascript(CMS_DIR . "/javascript/SitetreeAccess.js");
 
+		$groupsMap = DataList::create('Group')->map('ID', 'Breadcrumbs')->toArray();
+		asort($groupsMap);
+
 		$fields = new FieldList(
 			new TabSet("Root",
 				$tabMain = new Tab('Main',
@@ -53,11 +56,14 @@ class SiteConfig extends DataObject implements PermissionProvider {
 				),
 				$tabAccess = new Tab('Access',
 					$viewersOptionsField = new OptionsetField("CanViewType", _t('SiteConfig.VIEWHEADER', "Who can view pages on this site?")),
-					$viewerGroupsField = new TreeMultiselectField("ViewerGroups", _t('SiteTree.VIEWERGROUPS', "Viewer Groups")),
+					$viewerGroupsField = Object::create('ListboxField', "ViewerGroups", _t('SiteTree.VIEWERGROUPS', "Viewer Groups"))
+						->setMultiple(true)->setSource($groupsMap),
 					$editorsOptionsField = new OptionsetField("CanEditType", _t('SiteConfig.EDITHEADER', "Who can edit pages on this site?")),
-					$editorGroupsField = new TreeMultiselectField("EditorGroups", _t('SiteTree.EDITORGROUPS', "Editor Groups")),
+					$editorGroupsField = Object::create('ListboxField', "EditorGroups", _t('SiteTree.EDITORGROUPS', "Editor Groups"))
+						->setMultiple(true)->setSource($groupsMap),
 					$topLevelCreatorsOptionsField = new OptionsetField("CanCreateTopLevelType", _t('SiteConfig.TOPLEVELCREATE', "Who can create pages in the root of the site?")),
-					$topLevelCreatorsGroupsField = new TreeMultiselectField("CreateTopLevelGroups", _t('SiteTree.TOPLEVELCREATORGROUPS', "Top level creators"))
+					$topLevelCreatorsGroupsField = Object::create('ListboxField', "CreateTopLevelGroups", _t('SiteTree.TOPLEVELCREATORGROUPS', "Top level creators"))
+						->setMultiple(true)->setSource($groupsMap)
 				)
 			)
 		);
diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php
index ff63dac9..162f1ab4 100644
--- a/code/model/SiteTree.php
+++ b/code/model/SiteTree.php
@@ -1890,6 +1890,9 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 	 * @return FieldList
 	 */
 	function getSettingsFields() {
+		$groupsMap = DataList::create('Group')->map('ID', 'Breadcrumbs')->toArray();
+		asort($groupsMap);
+		
 		$fields = new FieldList(
 			$rootTab = new TabSet("Root",
 				$tabBehaviour = new Tab('Settings',
@@ -1925,12 +1928,14 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 						"CanViewType", 
 						_t('SiteTree.ACCESSHEADER', "Who can view this page?")
 					),
-					$viewerGroupsField = new TreeMultiselectField("ViewerGroups", $this->fieldLabel('ViewerGroups')),
+					$viewerGroupsField = Object::create('ListboxField', "ViewerGroups", _t('SiteTree.VIEWERGROUPS', "Viewer Groups"))
+						->setMultiple(true)->setSource($groupsMap),
 					$editorsOptionsField = new OptionsetField(
 						"CanEditType", 
 						_t('SiteTree.EDITHEADER', "Who can edit this page?")
 					),
-					$editorGroupsField = new TreeMultiselectField("EditorGroups", $this->fieldLabel('EditorGroups'))
+					$editorGroupsField = Object::create('ListboxField', "EditorGroups", _t('SiteTree.EDITORGROUPS', "Editor Groups"))
+						->setMultiple(true)->setSource($groupsMap)
 				)
 			)
 		);

From e0a67a80c722b79fcb52263b35db9cae0b1fc28e Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Mon, 5 Mar 2012 16:07:53 +0100
Subject: [PATCH 02/20] BUGFIX Restored old permission code model, broken due
 to new controller structure. Introduced
 LeftAndMain::$required_permission_codes as a way to control permissions
 independently of subclasses, and "cluster" multiple classes under a single
 code.

---
 code/controllers/AssetAdmin.php               | 12 ++++-
 code/controllers/CMSFileAddController.php     |  2 +-
 code/controllers/CMSMain.php                  | 50 +++++--------------
 code/controllers/CMSPageAddController.php     |  1 +
 code/controllers/CMSPageEditController.php    |  1 +
 code/controllers/CMSPageHistoryController.php |  1 +
 .../controllers/CMSPageSettingsController.php |  3 +-
 code/controllers/CMSPagesController.php       |  1 +
 code/controllers/ReportAdmin.php              | 12 ++++-
 code/model/SiteTree.php                       |  2 +-
 lang/en_US.php                                |  2 +-
 11 files changed, 43 insertions(+), 44 deletions(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index bf707c96..34839bf0 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -6,7 +6,7 @@
  * @package cms
  * @subpackage assets
  */
-class AssetAdmin extends LeftAndMain {
+class AssetAdmin extends LeftAndMain implements PermissionProvider{
 
 	static $url_segment = 'assets';
 	
@@ -558,6 +558,16 @@ JS
 
 		return $items;
 	}
+
+	function providePermissions() {
+		$title = _t("AssetAdmin.MENUTITLE", LeftAndMain::menu_title_for_class($this->class));
+		return array(
+			"CMS_ACCESS_AssetAdmin" => array(
+				'name' => sprintf(_t('CMSMain.ACCESS', "Access to '%s' section"), $title),
+				'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access')
+			)
+		);
+	}
 	
 }
 /**
diff --git a/code/controllers/CMSFileAddController.php b/code/controllers/CMSFileAddController.php
index 5487aa6f..4d94051e 100644
--- a/code/controllers/CMSFileAddController.php
+++ b/code/controllers/CMSFileAddController.php
@@ -2,8 +2,8 @@
 class CMSFileAddController extends AssetAdmin {
 
 	static $url_segment = 'assets/add';
-
 	static $url_priority = 60;
+	static $required_permission_codes = 'CMS_ACCESS_AssetAdmin';
 	
 //	public function upload($request) {
 //		$formHtml = $this->renderWith(array('AssetAdmin_UploadContent'));
diff --git a/code/controllers/CMSMain.php b/code/controllers/CMSMain.php
index 1384c32c..8a0765f4 100644
--- a/code/controllers/CMSMain.php
+++ b/code/controllers/CMSMain.php
@@ -553,7 +553,8 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
 		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
 
 		// Use <button> to allow full jQuery UI styling
-		foreach($actions->dataFields() as $action) $action->setUseButtonTag(true);
+		$actions = $actions->dataFields();
+		if($actions) foreach($actions as $action) $action->setUseButtonTag(true);
 
 		$this->extend('updateEditForm', $form);
 
@@ -1315,44 +1316,19 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
 		);
 	}
 
-	/**
-	 * Provide the permission codes used by LeftAndMain.
-	 * Can't put it on LeftAndMain since that's an abstract base class.
-	 */
 	function providePermissions() {
-		$classes = ClassInfo::subclassesFor('LeftAndMain');
-
-		foreach($classes as $i => $class) {
-			$title = _t("{$class}.MENUTITLE", LeftAndMain::menu_title_for_class($class));
-			$perms["CMS_ACCESS_" . $class] = array(
-				'name' => sprintf(_t(
-					'CMSMain.ACCESS', 
-					"Access to '%s' section",
-					PR_MEDIUM,
-					"Item in permission selection identifying the admin section. Example: Access to 'Files & Images'"
-				), $title, null),
-				'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access')
-			);
-		}
-		$perms["CMS_ACCESS_LeftAndMain"] = array(
-			'name' => _t('CMSMain.ACCESSALLINTERFACES', 'Access to all CMS sections'),
-			'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access'),
-			'help' => _t('CMSMain.ACCESSALLINTERFACESHELP', 'Overrules more specific access settings.'),
-			'sort' => -100
+		$title = _t("CMSPagesController.MENUTITLE", LeftAndMain::menu_title_for_class('CMSPagesController'));
+		return array(
+			"CMS_ACCESS_CMSMain" => array(
+				'name' => sprintf(_t('CMSMain.ACCESS', "Access to '%s' section"), $title),
+				'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access'),
+				'help' => _t(
+					'CMSMain.ACCESS_HELP',
+					'Allow viewing of the section containing page tree and content. View and edit permissions can be handled through page specific dropdowns, as well as the separate "Content permissions".'
+				),
+				'sort' => -99 // below "CMS_ACCESS_LeftAndMain", but above everything else
+			)
 		);
-
-		$perms['CMS_ACCESS_CMSMain']['help'] = _t(
-			'CMSMain.ACCESS_HELP',
-			'Allow viewing of the section containing page tree and content. View and edit permissions can be handled through page specific dropdowns, as well as the separate "Content permissions".'
-		);
-		$perms['CMS_ACCESS_SecurityAdmin']['help'] = _t(
-			'SecurityAdmin.ACCESS_HELP',
-			'Allow viewing, adding and editing users, as well as assigning permissions and roles to them.'
-		);
-
-		if (isset($perms['CMS_ACCESS_ModelAdmin'])) unset($perms['CMS_ACCESS_ModelAdmin']);
-
-		return $perms;
 	}
 
 }
diff --git a/code/controllers/CMSPageAddController.php b/code/controllers/CMSPageAddController.php
index 6b3b835d..46c40f35 100644
--- a/code/controllers/CMSPageAddController.php
+++ b/code/controllers/CMSPageAddController.php
@@ -5,6 +5,7 @@ class CMSPageAddController extends CMSMain {
 	static $url_rule = '/$Action/$ID/$OtherID';
 	static $url_priority = 42;
 	static $menu_title = 'Add page';
+	static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 	
 	function AddForm() {
 		$form = parent::AddForm();
diff --git a/code/controllers/CMSPageEditController.php b/code/controllers/CMSPageEditController.php
index 977d321d..d1ecfefb 100644
--- a/code/controllers/CMSPageEditController.php
+++ b/code/controllers/CMSPageEditController.php
@@ -8,4 +8,5 @@ class CMSPageEditController extends CMSMain {
 	static $url_segment = 'page/edit';
 	static $url_rule = '/$Action/$ID/$OtherID';
 	static $url_priority = 41;
+	static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 }
\ No newline at end of file
diff --git a/code/controllers/CMSPageHistoryController.php b/code/controllers/CMSPageHistoryController.php
index b9291aef..ed0778d0 100644
--- a/code/controllers/CMSPageHistoryController.php
+++ b/code/controllers/CMSPageHistoryController.php
@@ -10,6 +10,7 @@ class CMSPageHistoryController extends CMSMain {
 	static $url_rule = '/$Action/$ID/$VersionID/$OtherVersionID';
 	static $url_priority = 42;
 	static $menu_title = 'History';
+	static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 	
 	static $allowed_actions = array(
 		'VersionsForm',
diff --git a/code/controllers/CMSPageSettingsController.php b/code/controllers/CMSPageSettingsController.php
index cf359880..9d1f2b43 100644
--- a/code/controllers/CMSPageSettingsController.php
+++ b/code/controllers/CMSPageSettingsController.php
@@ -6,10 +6,9 @@
 class CMSPageSettingsController extends CMSMain {
 
 	static $url_segment = 'page/settings';
-	
 	static $url_rule = '/$Action/$ID/$OtherID';
-	
 	static $url_priority = 42;
+	static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 		
 	function getEditForm($id = null, $fields = null) {
 		$record = $this->getRecord($id ? $id : $this->currentPageID());
diff --git a/code/controllers/CMSPagesController.php b/code/controllers/CMSPagesController.php
index 721c85ec..84ff954e 100644
--- a/code/controllers/CMSPagesController.php
+++ b/code/controllers/CMSPagesController.php
@@ -9,6 +9,7 @@ class CMSPagesController extends CMSMain {
 	static $url_rule = '/$Action/$ID/$OtherID';
 	static $url_priority = 41;
 	static $menu_title = 'Pages';	
+	static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 	
 	function init() {
 		parent::init();
diff --git a/code/controllers/ReportAdmin.php b/code/controllers/ReportAdmin.php
index 6ede3e7e..fdbb4d75 100644
--- a/code/controllers/ReportAdmin.php
+++ b/code/controllers/ReportAdmin.php
@@ -11,7 +11,7 @@
  * @package cms
  * @subpackage reports
  */
-class ReportAdmin extends LeftAndMain {
+class ReportAdmin extends LeftAndMain implements PermissionProvider {
 	
 	static $url_segment = 'reports';
 	
@@ -97,5 +97,15 @@ class ReportAdmin extends LeftAndMain {
 		FormResponse::load_form($this->EditForm()->forTemplate());
 		return FormResponse::respond();
 	}
+
+	function providePermissions() {
+		$title = _t("ReportAdmin.MENUTITLE", LeftAndMain::menu_title_for_class($this->class));
+		return array(
+			"CMS_ACCESS_ReportAdmin" => array(
+				'name' => sprintf(_t('CMSMain.ACCESS', "Access to '%s' section"), $title),
+				'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access')
+			)
+		);
+	}
 }
 
diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php
index 162f1ab4..f1a98f03 100644
--- a/code/model/SiteTree.php
+++ b/code/model/SiteTree.php
@@ -2660,7 +2660,7 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 				'name' => _t('SiteTree.EDIT_ALL_DESCRIPTION', 'Edit any page'),
 				'category' => _t('Permissions.CONTENT_CATEGORY', 'Content permissions'),
 				'sort' => -50,
-				'help' => _t('SiteTree.EDIT_ALL_HELP', 'Ability to edit any page on the site, regardless of the settings on the Access tab.  Requires the "Access to Site Content" permission')
+				'help' => _t('SiteTree.EDIT_ALL_HELP', 'Ability to edit any page on the site, regardless of the settings on the Access tab.  Requires the "Access to \'Pages\' section" permission')
 			),
 			'SITETREE_REORGANISE' => array(
 				'name' => _t('SiteTree.REORGANISE_DESCRIPTION', 'Change site structure'),
diff --git a/lang/en_US.php b/lang/en_US.php
index 93928138..b12df5ea 100644
--- a/lang/en_US.php
+++ b/lang/en_US.php
@@ -357,7 +357,7 @@ $lang['en_US']['SiteTree']['EDITHEADER'] = 'Who can edit this page?';
 $lang['en_US']['SiteTree']['EDITONLYTHESE'] = 'Only these people (choose from list)';
 $lang['en_US']['SiteTree']['EDITORGROUPS'] = 'Editor Groups';
 $lang['en_US']['SiteTree']['EDIT_ALL_DESCRIPTION'] = 'Edit any page';
-$lang['en_US']['SiteTree']['EDIT_ALL_HELP'] = 'Ability to edit any page on the site, regardless of the settings on the Access tab.  Requires the "Access to Site Content" permission';
+$lang['en_US']['SiteTree']['EDIT_ALL_HELP'] = 'Ability to edit any page on the site, regardless of the settings on the Access tab.  Requires the "Access to \'Pages\' section" permission';
 $lang['en_US']['SiteTree']['Editors'] = 'Editors Groups';
 $lang['en_US']['SiteTree']['HASBROKENLINKS'] = 'This page has broken links.';
 $lang['en_US']['SiteTree']['HOMEPAGEFORDOMAIN'] = array(

From 12c01d45dee88d601d4a153bbb71ac74e190a4bc Mon Sep 17 00:00:00 2001
From: jbridson <jeremy@silverstripe.com>
Date: Tue, 6 Mar 2012 15:00:36 +1300
Subject: [PATCH 03/20] MINOR:SSF-106 - added padding to the tfoot of the asset
 admin datagrid (for the styling of pagination)

---
 css/screen.css        | 1 +
 scss/_AssetAdmin.scss | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/css/screen.css b/css/screen.css
index 988a3137..b8e60d3e 100644
--- a/css/screen.css
+++ b/css/screen.css
@@ -11,6 +11,7 @@
 .CMSPageHistoryController del { background-color: #FDD; padding: 2px; color: #ff4444; }
 
 .cms .AssetAdmin #Form_EditForm_File td { padding-top: 0; padding-bottom: 0; }
+.cms .AssetAdmin #Form_EditForm_File td.bottom-all { padding: 0.7em; }
 .cms .AssetAdmin #Form_EditForm_File td.col-StripThumbnail { padding: 0; width: 32px; height: 32px; display: block; }
 .cms .AssetAdmin #Form_EditForm_File td.col-StripThumbnail img { width: 32px; height: 32px; }
 .cms .AssetAdmin #Form_EditForm_File tr[data-class=Folder] td.col-StripThumbnail { background: transparent url(../../sapphire/admin/images/sprites-32x32/blue-folder-horizontal.png) no-repeat top left; }
diff --git a/scss/_AssetAdmin.scss b/scss/_AssetAdmin.scss
index 3fc02ae3..15c67865 100644
--- a/scss/_AssetAdmin.scss
+++ b/scss/_AssetAdmin.scss
@@ -4,6 +4,9 @@
 			// Taken care of by minimum image sizes
 			padding-top: 0;
 			padding-bottom: 0;
+			&.bottom-all {
+				padding:0.7em;
+			}
 		}
 		td.col-StripThumbnail {
 			padding: 0;

From adefc15e5af07b56e4afc280c0289fae04d8dbfc Mon Sep 17 00:00:00 2001
From: Julian Seidenberg <julian@silverstripe.com>
Date: Tue, 6 Mar 2012 18:21:21 +1300
Subject: [PATCH 04/20] API-CHANGE: SSF-33 Adding "look for new files" trigger.
 Removing the legacy implementation of SyncForm and replacing it with an
 implementation that can be triggered via ajax.

---
 code/controllers/AssetAdmin.php | 47 +++++++++++++++++----------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index 34839bf0..ac1aea48 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -30,7 +30,7 @@ class AssetAdmin extends LeftAndMain implements PermissionProvider{
 		'removefile',
 		'savefile',
 		'deleteUnusedThumbnails' => 'ADMIN',
-		'SyncForm',
+		'doSync',
 		'filter',
 	);
 	
@@ -168,6 +168,19 @@ JS
 		} else {
 			$addFolderBtn = '';
 		}
+
+		if($folder->canEdit()) {
+			$syncButton = new LiteralField(
+				'SyncButton',
+				sprintf(
+					'<a class="ss-ui-button ss-ui-action cms-link-ajax" data-icon="" href="%s">%s</a>',
+					$this->Link('doSync'),
+					_t('FILESYSTEMSYNC','Sync files')
+				)
+			);
+		} else {
+			$syncButton = null;
+		}
 		
 		// Move existing fields to a "details" tab, unless they've already been tabbed out through extensions.
 		// Required to keep Folder->getCMSFields() simple and reuseable,
@@ -186,13 +199,14 @@ JS
 			}
 			$fields->push($tabs);
 		}
-		
+
 		// List view
 		$fields->addFieldsToTab('Root.ListView', array(
 			$actionsComposite = Object::create('CompositeField',
 				Object::create('CompositeField',
 					$uploadBtn,
-					$addFolderBtn
+					$addFolderBtn,
+					$syncButton //TODO: add this into a batch actions menu as in https://github.com/silverstripe/silverstripe-design/raw/master/Design/ss3-ui_files-manager-list-view.jpg
 				)->addExtraClass('cms-actions-row')
 			)->addExtraClass('cms-content-toolbar field'),
 			$gridField
@@ -419,28 +433,15 @@ JS
 	//------------------------------------------------------------------------------------------//
 
 	// Data saving handlers
+
 	/**
-	 * @return Form
+	 * Can be queried with an ajax request to trigger the filesystem sync. It returns a FormResponse status message
+	 * to display in the CMS
 	 */
-	public function SyncForm() {
-		$form = new Form(
-			$this,
-			'SyncForm',
-			new FieldList(
-			),
-			new FieldList(
-				FormAction::create('doSync', _t('FILESYSTEMSYNC','Look for new files'))
-					->describe(_t('AssetAdmin_left.ss.FILESYSTEMSYNC_DESC', 'SilverStripe maintains its own database of the files &amp; images stored in your assets/ folder.  Click this button to update that database, if files are added to the assets/ folder from outside SilverStripe, for example, if you have uploaded files via FTP.'))
-					->setUseButtonTag(true)
-			)
-		);
-		$form->setFormMethod('GET');
-		
-		return $form;
-	}
-	
-	public function doSync($data, $form) {
-		return Filesystem::sync();
+	public function doSync() {
+		$message = Filesystem::sync();
+		FormResponse::status_message($message, 'good');
+		echo FormResponse::respond();
 	}
 	
 	/**

From b6f73eb290915a57fdc2f7d0d156fb389b2d628f Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Tue, 6 Mar 2012 11:25:41 +0100
Subject: [PATCH 05/20] MINOR Title for "sync files" button

---
 code/controllers/AssetAdmin.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index ac1aea48..e2e456e0 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -173,7 +173,8 @@ JS
 			$syncButton = new LiteralField(
 				'SyncButton',
 				sprintf(
-					'<a class="ss-ui-button ss-ui-action cms-link-ajax" data-icon="" href="%s">%s</a>',
+					'<a class="ss-ui-button ss-ui-action cms-link-ajax" title="%s" href="%s">%s</a>',
+					_t('AssetAdmin.FILESYSTEMSYNCTITLE', 'Update the CMS database entries of files on the filesystem. Useful when new files have been uploaded outside of the CMS, e.g. through FTP.'),
 					$this->Link('doSync'),
 					_t('FILESYSTEMSYNC','Sync files')
 				)

From ecb31ce30a9d3e2e7727670873a40e31beea65ee Mon Sep 17 00:00:00 2001
From: Normann Lou <normannlou@gmail.com>
Date: Wed, 7 Mar 2012 14:28:57 +1300
Subject: [PATCH 06/20] MINOR SSF-30 : add extra field to Tabs (listView and
 TreeView) to LeftAndMain EditForm

---
 code/controllers/AssetAdmin.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index e2e456e0..06fbfcdc 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -191,6 +191,8 @@ JS
 				$tabList = new Tab('ListView', _t('AssetAdmin.ListView', 'List View')),
 				$tabTree = new Tab('TreeView', _t('AssetAdmin.TreeView', 'Tree View'))
 			);
+			$tabList->addExtraClass("content-listview");
+			$tabTree->addExtraClass("content-treeview");
 			if($fields->Count() && $folder->exists()) {
 				$tabs->push($tabDetails = new Tab('DetailsView', _t('AssetAdmin.DetailsView', 'Details')));
 				foreach($fields as $field) {

From 434dbdb2864c4565f76524c858888c8234412d0b Mon Sep 17 00:00:00 2001
From: Normann Lou <normannlou@gmail.com>
Date: Wed, 7 Mar 2012 16:52:29 +1300
Subject: [PATCH 07/20] MINOR SSF-30 : add extra class to Tab (GalleryView) to
 AssetAdmin EditForm

---
 code/controllers/AssetAdmin.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index 06fbfcdc..8e12aabe 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -195,6 +195,7 @@ JS
 			$tabTree->addExtraClass("content-treeview");
 			if($fields->Count() && $folder->exists()) {
 				$tabs->push($tabDetails = new Tab('DetailsView', _t('AssetAdmin.DetailsView', 'Details')));
+				$tabDetails->addExtraClass("content-galleryview");
 				foreach($fields as $field) {
 					$fields->removeByName($field->Name());
 					$tabDetails->push($field);

From 590027cfe3d34a17b31642956a6edae57a988edd Mon Sep 17 00:00:00 2001
From: jbridson <jeremy@silverstripe.com>
Date: Wed, 7 Mar 2012 17:33:15 +1300
Subject: [PATCH 08/20] ENHANCEMENT:SSF-30 - changed color of add folder
 button.

---
 css/screen.css        |  3 +++
 scss/_AssetAdmin.scss | 13 +++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/css/screen.css b/css/screen.css
index b8e60d3e..f03e95e5 100644
--- a/css/screen.css
+++ b/css/screen.css
@@ -10,6 +10,9 @@
 .CMSPageHistoryController ins { background-color: #DFD; padding: 2px; text-decoration: none; }
 .CMSPageHistoryController del { background-color: #FDD; padding: 2px; color: #ff4444; }
 
+.cms .AssetAdmin .cms-content-toolbar .cms-page-add-button { background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #f3f3f3), color-stop(100%, #d9d9d9)); background-image: -webkit-linear-gradient(#f3f3f3, #d9d9d9); background-image: -moz-linear-gradient(#f3f3f3, #d9d9d9); background-image: -o-linear-gradient(#f3f3f3, #d9d9d9); background-image: -ms-linear-gradient(#f3f3f3, #d9d9d9); background-image: linear-gradient(#f3f3f3, #d9d9d9); border-color: #c0c0c2; }
+.cms .AssetAdmin .cms-content-toolbar .cms-page-add-button span.btn-icon-add { height: 17px; }
+.cms .AssetAdmin .cms-content-toolbar .cms-page-add-button span.ui-button-text { color: #393939; text-shadow: white 0 1px 1px; }
 .cms .AssetAdmin #Form_EditForm_File td { padding-top: 0; padding-bottom: 0; }
 .cms .AssetAdmin #Form_EditForm_File td.bottom-all { padding: 0.7em; }
 .cms .AssetAdmin #Form_EditForm_File td.col-StripThumbnail { padding: 0; width: 32px; height: 32px; display: block; }
diff --git a/scss/_AssetAdmin.scss b/scss/_AssetAdmin.scss
index 15c67865..fd709b05 100644
--- a/scss/_AssetAdmin.scss
+++ b/scss/_AssetAdmin.scss
@@ -1,4 +1,17 @@
 .cms .AssetAdmin {
+	.cms-content-toolbar {
+		.cms-page-add-button {
+			@include background-image (linear-gradient(lighten(#e6e6e6, 5%), darken(#e6e6e6, 5%)));
+			border-color:#c0c0c2;
+			span.btn-icon-add {
+				height:17px;
+			}
+			span.ui-button-text {
+				color:#393939;
+				text-shadow: white 0 1px 1px;
+			}
+		}
+	}	
 	#Form_EditForm_File {
 		td {
 			// Taken care of by minimum image sizes

From b29a7540a2bdaf235bbb31e1416b2e42b102cf3e Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 7 Mar 2012 12:03:00 +0100
Subject: [PATCH 09/20] MINOR Fixed usage of deprecated FormField->describe()
 API

---
 code/model/SiteTree.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php
index f1a98f03..ca2d126a 100644
--- a/code/model/SiteTree.php
+++ b/code/model/SiteTree.php
@@ -2065,7 +2065,7 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 			// "unpublish"
 			$minorActions->push(
 				FormAction::create('unpublish', _t('SiteTree.BUTTONUNPUBLISH', 'Unpublish'), 'delete')
-					->describe(_t('SiteTree.BUTTONUNPUBLISHDESC', 'Remove this page from the published site'))
+					->setDescription(_t('SiteTree.BUTTONUNPUBLISHDESC', 'Remove this page from the published site'))
 					->addExtraClass('ss-ui-action-destructive')->setAttribute('data-icon', 'unpublish')
 			);
 		}
@@ -2075,7 +2075,7 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 				// "rollback"
 				$minorActions->push(
 					FormAction::create('rollback', _t('SiteTree.BUTTONCANCELDRAFT', 'Cancel draft changes'), 'delete')
-						->describe(_t('SiteTree.BUTTONCANCELDRAFTDESC', 'Delete your draft and revert to the currently published page'))
+						->setDescription(_t('SiteTree.BUTTONCANCELDRAFTDESC', 'Delete your draft and revert to the currently published page'))
 						->addExtraClass('delete')->setAttribute('data-icon', 'delete')
 				);
 			}

From 12124fdae03210d5592cecbe45a620a939c918a7 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 7 Mar 2012 13:48:52 +0100
Subject: [PATCH 10/20] MINOR Simplified "Meta" field labelling in
 SiteTree->getCMSFields() (removed header)

---
 code/model/SiteTree.php | 8 +++-----
 lang/en_US.php          | 7 +++----
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php
index ca2d126a..2b697cac 100644
--- a/code/model/SiteTree.php
+++ b/code/model/SiteTree.php
@@ -1846,7 +1846,6 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 				),
 				$tabMeta = new Tab('Metadata',
 					$urlsegment,
-					new HeaderField('MetaTagsHeader',$this->fieldLabel('MetaTagsHeader')),
 					new TextField("MetaTitle", $this->fieldLabel('MetaTitle')),
 					new TextareaField("MetaKeywords", $this->fieldLabel('MetaKeywords'), 1),
 					new TextareaField("MetaDescription", $this->fieldLabel('MetaDescription')),
@@ -2006,10 +2005,9 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 		
 		$labels['Title'] = _t('SiteTree.PAGETITLE', "Page name");
 		$labels['MenuTitle'] = _t('SiteTree.MENUTITLE', "Navigation label");
-		$labels['MetaTagsHeader'] = _t('SiteTree.METAHEADER', "Search Engine Meta-tags");
-		$labels['MetaTitle'] = _t('SiteTree.METATITLE', "Title");
-		$labels['MetaDescription'] = _t('SiteTree.METADESC', "Description");
-		$labels['MetaKeywords'] = _t('SiteTree.METAKEYWORDS', "Keywords");
+		$labels['MetaTitle'] = _t('SiteTree.METATITLE', "Meta Title");
+		$labels['MetaDescription'] = _t('SiteTree.METADESC', "Meta Description");
+		$labels['MetaKeywords'] = _t('SiteTree.METAKEYWORDS', "Meta Keywords");
 		$labels['ExtraMeta'] = _t('SiteTree.METAEXTRA', "Custom Meta Tags");
 		$labels['ClassName'] = _t('SiteTree.PAGETYPE', "Page type", PR_MEDIUM, 'Classname of a page object');
 		$labels['ParentType'] = _t('SiteTree.PARENTTYPE', "Page location", PR_MEDIUM);
diff --git a/lang/en_US.php b/lang/en_US.php
index b12df5ea..4f78c536 100644
--- a/lang/en_US.php
+++ b/lang/en_US.php
@@ -374,11 +374,10 @@ $lang['en_US']['SiteTree']['HomepageForDomain'] = 'Hompage for this domain';
 $lang['en_US']['SiteTree']['INHERIT'] = 'Inherit from parent page';
 $lang['en_US']['SiteTree']['LINKCHANGENOTE'] = 'Changing this page\'s link will also affect the links of all child pages.';
 $lang['en_US']['SiteTree']['MENUTITLE'] = 'Navigation label';
-$lang['en_US']['SiteTree']['METADESC'] = 'Description';
+$lang['en_US']['SiteTree']['METADESC'] = 'Meta Description';
 $lang['en_US']['SiteTree']['METAEXTRA'] = 'Custom Meta Tags';
-$lang['en_US']['SiteTree']['METAHEADER'] = 'Search Engine Meta-tags';
-$lang['en_US']['SiteTree']['METAKEYWORDS'] = 'Keywords';
-$lang['en_US']['SiteTree']['METATITLE'] = 'Title';
+$lang['en_US']['SiteTree']['METAKEYWORDS'] = 'Meta Keywords';
+$lang['en_US']['SiteTree']['METATITLE'] = 'Meta Title';
 $lang['en_US']['SiteTree']['MODIFIEDONDRAFT'] = 'Modified on draft site';
 $lang['en_US']['SiteTree']['NOTEUSEASHOMEPAGE'] = 'Use this page as the \'home page\' for the following domains: 
 							(separate multiple domains with commas)';

From 915dc7f27c529ad8ffefb5b7d51c59b25d534f4d Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 7 Mar 2012 14:37:12 +0100
Subject: [PATCH 11/20] MINOR Fixed wrong "add folder" css class + behaviour

---
 code/controllers/AssetAdmin.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index 8e12aabe..2d9a74fa 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -160,7 +160,7 @@ JS
 			$addFolderBtn = new LiteralField(
 				'AddFolderButton', 
 				sprintf(
-					'<a class="ss-ui-button ss-ui-action-constructive cms-panel-link cms-page-add-button" data-icon="add" href="%s">%s</a>',
+					'<a class="ss-ui-button ss-ui-action-constructive cms-panel-link" data-icon="add" href="%s">%s</a>',
 					Controller::join_links($this->Link('addfolder'), '?ParentID=' . $folder->ID),
 					_t('Folder.AddFolderButton', 'Add folder')
 				)

From 9981c929e09718c8f14e04b91c1282459517f3a5 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 7 Mar 2012 17:01:08 +0100
Subject: [PATCH 12/20] MINOR Fixed breadcrumbs in CMSFileAddController

---
 code/controllers/AssetAdmin.php | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index 2d9a74fa..c17dfa32 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -546,8 +546,14 @@ JS
 	public function Breadcrumbs($unlinked = false) {
 		$items = parent::Breadcrumbs($unlinked);
 
-		// The root element should explicitly point to the root node
-		$items[0]->Link = Controller::join_links($this->Link('show'), 'root');
+		// The root element should explicitly point to the root node.
+		// Used in CMSFileAddController subclass as well, so specifically link to AssetAdmin
+		$items[0]->Link = Controller::join_links(singleton('AssetAdmin')->Link('show'), 'root');
+
+		// HACK Force linkage to AssetAdmin, even when current controller is CMSFileAddController
+		foreach($items as $item) {
+			if($item->Link) $item->Link = str_replace('assets/add/show/', 'assets/show/', $item->Link);
+		}
 
 		// If a search is in progress, don't show the path
 		if($this->request->requestVar('q')) {

From 3670fe0530509a1ebb0135443a5582d69446776d Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 7 Mar 2012 17:02:08 +0100
Subject: [PATCH 13/20] ENHANCEMENT Show AssetAdmin breadcrumbs+tabs outside of
 search+editform panels

---
 code/controllers/AssetAdmin.php           |  3 +-
 code/controllers/CMSFileAddController.php | 11 +++++-
 templates/Includes/AssetAdmin_Content.ss  | 41 +++++++++++++++++++++++
 templates/Includes/AssetAdmin_EditForm.ss | 30 +++++++++++++++++
 4 files changed, 82 insertions(+), 3 deletions(-)
 create mode 100644 templates/Includes/AssetAdmin_Content.ss
 create mode 100644 templates/Includes/AssetAdmin_EditForm.ss

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index c17dfa32..d2d130b4 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -235,10 +235,9 @@ JS
 		));
 
 		$fields->setForm($form);
-		$form->addExtraClass('cms-edit-form');
 		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
 		// TODO Can't merge $FormAttributes in template at the moment
-		$form->addExtraClass('center ss-tabset ' . $this->BaseCSSClasses());
+		$form->addExtraClass('cms-edit-form cms-panel-padded center ' . $this->BaseCSSClasses());
 		$form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
 
 		$this->extend('updateEditForm', $form);
diff --git a/code/controllers/CMSFileAddController.php b/code/controllers/CMSFileAddController.php
index 4d94051e..aa1a84cd 100644
--- a/code/controllers/CMSFileAddController.php
+++ b/code/controllers/CMSFileAddController.php
@@ -16,6 +16,11 @@ class CMSFileAddController extends AssetAdmin {
 //		}
 //	}
 	
+	public function Content() {
+		// Disable AssetAdmin layout including the search panel
+		return $this->renderWith('LeftAndMain_Content');
+	}
+
 	/**
 	 * @return Form
 	 * @todo what template is used here? AssetAdmin_UploadContent.ss doesn't seem to be used anymore
@@ -45,7 +50,8 @@ class CMSFileAddController extends AssetAdmin {
 			new FieldList()
 		);
 		$form->addExtraClass('center cms-edit-form ' . $this->BaseCSSClasses());
-		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
+		// Don't use AssetAdmin_EditForm, as it assumes a different panel structure
+		$form->setTemplate('LeftAndMain_EditForm');
 		$form->Fields()->push(
 			new LiteralField(
 				'BackLink',
@@ -61,6 +67,9 @@ class CMSFileAddController extends AssetAdmin {
 		return $form;
 	}
 
+	/**
+	 * Disable AssetAdmin search panel
+	 */
 	function Tools() {
 		return false;
 	}
diff --git a/templates/Includes/AssetAdmin_Content.ss b/templates/Includes/AssetAdmin_Content.ss
new file mode 100644
index 00000000..2f70a036
--- /dev/null
+++ b/templates/Includes/AssetAdmin_Content.ss
@@ -0,0 +1,41 @@
+<div class="cms-content center ss-tabset $BaseCSSClasses" data-layout-type="border">
+
+	<div class="cms-content-header north">
+		<div>
+			<% control EditForm %>
+				<% if Backlink %>
+					<a class="backlink ss-ui-button cms-panel-link" data-icon="back" href="$Backlink">
+						<% _t('Back', 'Back') %>
+					</a>
+				<% end_if %>
+
+				<h2 id="page-title-heading">
+				<% control Controller %>
+					<% include CMSBreadcrumbs %>
+				<% end_control %>
+				</h2>
+				<% if Fields.hasTabset %>
+					<% with Fields.fieldByName('Root') %>
+					<div class="cms-content-header-tabs">
+						<ul>
+						<% control Tabs %>
+							<li><a href="#$id"<% if extraClass %> class="$extraClass"<% end_if %>>$Title</a></li>
+						<% end_control %>
+						</ul>
+					</div>
+					<% end_with %>
+				<% end_if %>
+			<% end_control %>
+		
+		</div>
+	</div>
+
+	<div class="cms-content-fields center ui-widget-content" data-layout-type="border">
+
+		$Tools
+		
+		$EditForm
+		
+	</div>
+	
+</div>
\ No newline at end of file
diff --git a/templates/Includes/AssetAdmin_EditForm.ss b/templates/Includes/AssetAdmin_EditForm.ss
new file mode 100644
index 00000000..9f562bb3
--- /dev/null
+++ b/templates/Includes/AssetAdmin_EditForm.ss
@@ -0,0 +1,30 @@
+<form $FormAttributes>
+	
+	<% if Message %>
+	<p id="{$FormName}_error" class="message $MessageType">$Message</p>
+	<% else %>
+	<p id="{$FormName}_error" class="message $MessageType" style="display: none"></p>
+	<% end_if %>
+
+	<fieldset>
+		<% if Legend %><legend>$Legend</legend><% end_if %> 
+		<% control Fields %>
+			$FieldHolder
+		<% end_control %>
+		<div class="clear"><!-- --></div>
+	</fieldset>
+
+	<% if Actions %>
+	<div class="Actions">
+		<% control Actions %>
+			$Field
+		<% end_control %>
+		<% if CurrentPage.PreviewLink %>
+		<a href="$CurrentPage.PreviewLink" class="cms-preview-toggle-link ss-ui-button" data-icon="preview">
+			<% _t('LeftAndMain.PreviewButton', 'Preview') %> &raquo;
+		</a>
+		<% end_if %>
+	</div>
+	<% end_if %>
+
+</form>
\ No newline at end of file

From 83aae46236522986c09c35d12f821a22f28421e6 Mon Sep 17 00:00:00 2001
From: jbridson <jeremy@silverstripe.com>
Date: Thu, 8 Mar 2012 09:03:03 +1300
Subject: [PATCH 14/20] BUGFIX:SSF-30 - moved tabs SCSS from _style.scss to
 AssetAdmin.scss

---
 css/screen.css                        |   8 +++++
 images/content-header-tabs-sprite.png | Bin 0 -> 4026 bytes
 scss/_AssetAdmin.scss                 |  46 +++++++++++++++++++++++++-
 3 files changed, 53 insertions(+), 1 deletion(-)
 create mode 100644 images/content-header-tabs-sprite.png

diff --git a/css/screen.css b/css/screen.css
index f03e95e5..8cc07e06 100644
--- a/css/screen.css
+++ b/css/screen.css
@@ -10,6 +10,14 @@
 .CMSPageHistoryController ins { background-color: #DFD; padding: 2px; text-decoration: none; }
 .CMSPageHistoryController del { background-color: #FDD; padding: 2px; color: #ff4444; }
 
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav li a { font-weight: bold; line-height: 16px; padding: 12px 20px 11px; text-indent: -9999em; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav li a.content-treeview { background: url(../images/content-header-tabs-sprite.png) no-repeat 2px 0px; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav li a.content-galleryview { background: url(../images/content-header-tabs-sprite.png) no-repeat -87px 0px; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav li a.content-listview { background: url(../images/content-header-tabs-sprite.png) no-repeat -38px 0px; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-state-active, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-content .ui-state-active, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-header .ui-state-active { border-top: none; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-state-active a.content-treeview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-content .ui-state-active a.content-treeview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-header .ui-state-active a.content-treeview { background: url(../images/content-header-tabs-sprite.png) no-repeat 2px -40px; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-state-active a.content-galleryview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-content .ui-state-active a.content-galleryview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-header .ui-state-active a.content-galleryview { background: url(../images/content-header-tabs-sprite.png) no-repeat -87px -40px; }
+.cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-state-active a.content-listview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-content .ui-state-active a.content-listview, .cms .AssetAdmin .cms-content-header-tabs .ui-tabs-nav .ui-widget-header .ui-state-active a.content-listview { background: url(../images/content-header-tabs-sprite.png) no-repeat -38px -40px; }
 .cms .AssetAdmin .cms-content-toolbar .cms-page-add-button { background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #f3f3f3), color-stop(100%, #d9d9d9)); background-image: -webkit-linear-gradient(#f3f3f3, #d9d9d9); background-image: -moz-linear-gradient(#f3f3f3, #d9d9d9); background-image: -o-linear-gradient(#f3f3f3, #d9d9d9); background-image: -ms-linear-gradient(#f3f3f3, #d9d9d9); background-image: linear-gradient(#f3f3f3, #d9d9d9); border-color: #c0c0c2; }
 .cms .AssetAdmin .cms-content-toolbar .cms-page-add-button span.btn-icon-add { height: 17px; }
 .cms .AssetAdmin .cms-content-toolbar .cms-page-add-button span.ui-button-text { color: #393939; text-shadow: white 0 1px 1px; }
diff --git a/images/content-header-tabs-sprite.png b/images/content-header-tabs-sprite.png
new file mode 100644
index 0000000000000000000000000000000000000000..0648bd5fe07b7e7c2a2b194e82b908ade32b77f9
GIT binary patch
literal 4026
zcmaJ^2UL?u+oc34t4L8$l+O^B4k?6|0MQUoLKl!G#gGID5E7CgRgj{BtB4>S1f@w4
zL<FTPO7C5W2nwixNKu-!Kj^yq?>XOo?>X-~cjnyZKF`eDIcMG|Gm|q1_{8|w*w_wW
z^>xizZ6512=h?^l!mzJSvzns}JsXAv#f9OEqY>HA1d1~eh$Z7(iRMHc!QZ=;sKv&{
z2_jkAFl>yCka!9ijN9XY{m4{SG#i`NNk1wM??Ge$or$g_FKy65bv+13B4~rGRgIy>
zR1DFLq#r;dS_GI_;sZSJ2m<IN3aI6WWC@Uo3>?sp?CC{E`e}oH=ptEoZx{js{-7{C
zv_U_MvN1LTVkk5sP!$YS!b8=dKs6W`23Jv6S62ioLt#(|R2c$OR)VP`;mSxT6!_-@
zVr8QdT#)9vr~k~w>S=@A7z`>B0`c|r1^dFm6q+jphCm?pG?bN<SPUh)zZV1Nr{qPK
z{H35vq~mEMDuYDv0`4i|oGCsGZ4j%{pHm=H|C05h|G7-81%vqEs1O(!x;Ld?L}TOs
zO(m26V$&Js#J}tPuflXoe<~4TPNY+OXn5Afxk&D%q9QRgB91|!SyCvTzgE%Ajl!VN
z-6&Kb#zGZnjKh<>_WD2g#>Pmj7oCCg!V|H&+8~w!m_#BV_0R|?6r-oAf`DUSFg=)t
zx(Wt^Ijw=#QNzG7P~Bg#x)i(*ndrs%6-)R#R_$M7_pCssvNG!uX{3up!f6_X4E!-=
zB<bI4f&Z)CpRt60uSMlwV<D_!AbT78|2F#95X(J#@Gsl4I)53T=*4n7jb&?7BTg_I
z+kP-s7j5Y``q`nA#vD4z#lB;3msh)=`$9(Mw}z0%#M`C9>ht%Pg>6z?D22AF#|%?1
z4vvnfOK$LH8#NinjY_3!Tuf7Zg$hlU;i-P~dn~Aj4*nt~aXni~2te4-gbVO4UVpa!
zrE+|MD``=yTZqR5<S7_>szpwK2f?Ld@&nQM0Dq%?^s<WmtLBU#JHEN<ou#MsmiVfx
zT8`H-sNzdIYxQa!T_<+GeY{QfK5)}FI!$0=TSDjFqSe)HCxBF+LF9ORBuUW`*M4y0
z20>HPg}KCa`%{#TX=LDQk<!B)owKhi9$nhUKk#zuxp(Jx2hSXKrUOhzSTf{B_cA`X
z+lCD$x)Sk>dB(_a;p@8Es8Uq7T;%=~YASo5g(m8GMXu9aD7N%J(rD8w-Mn<66uGPQ
z(l<T}#@Q_ePxOcpYDb4Xx#q3PTc4_+3$u*2H1$k)vJSl;K6fR-;SH}_2RCOV>CQ{}
zrc6Pga#WS#l$JJoFZPu)u*EJgd?kP_>}@aVlk<_OLm3uOKI!!lzTC&BFSM^`j7mjX
z(i40bUY2VqNew+_Wv8dWGH%EA1*4p+cUJ@hLG^I&v@Hv#x9!IcMNX`{I3cq_fs;cj
zXH;L8U<HTC3NlM#sGTVbNG4)j<LZ%3pPD4MZBH|1bblUcJ?#%6fpjFfP9Lr<&oPV*
zfUmAdR<ZX>%9Q5;bnh8Iy03bFHvC1gcsV&TcN_QolFhK!7_^A{`#0!~IMV_|yM=UH
zb;La0C}mz&Iw|@&#Um_X@$N^57fbFJ?jKTt8R9l;TX{8|#5397AF+Wo_P=~=rQuSF
z<-*$!zvz0zC7bG2wm;bORX&3IoqfnD74i(4XZlf{p}g)j!g<c#t`$;qn9sAOx1Wyr
zT3s)~@}#6SHR@_lR0WBMSY3&|)^x}2aS>-XbLibUtW##EmD3Xx3>{|yY%63>-(9&g
z?Q7a{lowl=WiK04S2R|I0dPed_mC_j`6#bN)4Vt!2Z8Scrc%BFa$<i6B5?rmOthrb
z$49{5mo0^YMwjJ|^xqV;%0;1>8oX_fKXO!bH*G|hwkJwHnSl(wTb{P<l?i*z2@>A|
z(4ABT%P!2OSO6o19^bV9P95TjNaK*mJGF-pT>nHry}vj1k5j<nQADGC4)zXSIT+%t
znI5E;Shnas|M`nu1^GN24!_wpc?LsqPF;Nnv@Y(jMv4!=-}bHHy_GkKs9dPJi)unq
z4Q-<Fg_F5XADXnk)CX;7C1@f_I>v3T+5a|wk?CG;XQh^^cfw)C)-|MlXKN(x3%&?q
z4}RF))g@y0P`X%(v=pM8tWx~4;-atb9E5``gWf%G^GHZqS$R^sOUPt^7rWAIr_0y+
zWFwck>e=Cyv*W5OAL+44GmO#Ek&#kQMjD5abUbw#X8Jf5!X|0CBDz^D^ho02e>?`e
zp1ku|*nJ;(JgA`}5!z!VAHTdt8uC0ZXnD{xk($g1hys}8^v%*MnB(J5V}S*e8r-8-
zL))$2c4vjGK|lB+b_{Y2F4omhzia}(?E7B1y!~{Se}2TKS$R$kT*HZriQ!k{ixeB^
zSbX;U1^g0q%*2|$58KTC<lE)c?v6sT45)YU%rk+){+addQ;D)pME1|&FA2qi8PsA>
zcKTw}@l}9=!>(+Gk<^AF#|p;H;OP8QbW8NC!Wsg$7|i>zIHsjE$;VNHD<P}3HzJdi
z5t@AKsE3PLnDnTO!+k^K7mL(Ym0StZ)=oSphnfVF&@imu>0&6JCq2ewYW5^#>!ZWV
zGf8VpsMJ>3Ygh0(!Y8CBz~lx8*<AC17RO8VV~!r>qvua<FItjX3WrfP9O#Xr0uFsU
zBP4%R5ST_YH*3x2EURmmu-1uK!1o?+j1q;^IbC9=?~3T_`N#S(lArinwLPy{;7<|b
zwgEq^d~<o4$6~X)bKIt((l9`0V4^TFV<nmVnPOkL${wPZ6-F2JUUi=NzK~F0x>G4A
zhrsIanI^}r7W;gtb@EAH)9~KeYUJaNLf<}ls(9#5bYFss=6(@B`vbXiKHRa*8Z#W>
zVuq)5Y10=%A4tJtWTuO@D>1n#b_uk+)W$g&{^df83;bOU&2zJ&ci?q`;J5wXWM*8$
zGM`S|s-taJ3}pAl3ZJzVmjN$cVtUBEc$dU=&goWM8ql%zR+sQ-8gul-S4#l`PixE2
z+R5tOC=aSCcCvgv4LA^Uqe{Ybnh9Tro?Qouw!0Z(jH0iQuO*5{<SNd;tdDRj=&ldc
zT5eSWy440vt{wZNUQQ0Jb6;t-zS+`Z>%aA2Gp+Lv(T`dk*_gL$K{GCbE^?;t%qNnt
zIMk_-L+EqRsW?dQV03WIgxm7Umg(0@STf3g(r}Z;an>VXl-H$Rb0DRSvdUl0Hc;?Q
zJHGLgta-|?z$9EsH0Wc$q}@=);KtIe#pDhB`|gA(E$68k^2kn+)$P2K)p_Yza%<fA
z+Qu3-3aeq+ac8fc+U-U=%J-G8G(L#R5t4Vz>gLio!zD1V&TcGbCx1;Wxp<#_##(g2
z_8<Ufl{a!@A<t3v&TpdN#DLA><)u|-q(&Sf&M|Vz*CKdpNpCQqon6?EFt@zyFBN+&
zOG=;7-TpH1<HBzbkH4VoaLQ;Zv0cp;Iff_?vF3HWZqOA#hN|Yd)Gux4-ZV`7pk=|!
z=dM?FLgj0)^V@D8F}N2k-Al!8humOQJ?0qZ$49p=8NamixiuVj;9j1HVD@2prQ&qm
zVSjnj<tC&`OyY;OyP)D}nfc9rU_UIXE@MXKiuhqba+`pp9|l$biWFpCIOmb#em1QU
z01#$YYiiE+-d3bOV8ohG`&~m;zomM8S+tw^P%-D<$Ut6sP&;4Ejy&=zqVP(*>#OyL
z2&^l%x~7OjwddANcJC&TNqyHF#lu1!fi)*%RgEM;0;3JUk24_;vM=$}HK%q)m2hc8
z1T}`16lAIZpES5VW`h}&!j`dHv$ZzcrqYkZ(?ygID+yV|eSJ>ZHp7%YtmNO9!7DCs
z&mUHVlF%t}QW&={72ia)$3LvC^>J%qmX(z`)dX)>U4?-&OP=0yFf_vDoHH<y3kw9&
z4(oco(&@tGCuRiu1t`ph>N&MJK=MmMULdASWfxBAJ@D<AOMu}eWI&5=I&N^y=eIP;
zAJ6i^^wr(Dd;Ptw&Qzd4V_S{|cb_5d9kXrtpus}OopJJ)F?x`pjZTO`GGnyF^4*qJ
zS6z>LKAQ&auy+xMhgq>!@IWM*&X3}cD{JZMee+3$yR&0Rg?m*6pxZ%;B|Oon7`j>n
zfQ`JR<Rs~gQoct>p>1*`^Wz(nbm}U;XOvjogB7+CmZO<7iWS}_?yV{^QBH#e&VfAb
zjB$FcRymSi)Vql0U2K1vZ8-8y+DjMNtvkkTectv`vL#MA#_XbC`_(X8P75V-cqOFd
z=s@%#Mc0~)h0pE}UJuBG^P0GqH|TGs8icR5rs%2_hWlN*5j`d+DhS=pXDj$^dR+OM
z10iF;yw)?<Mg9zsI^U5DSHyon<Yx~4F@fc3ZlBD4Cf$>!CcISG6w$XuojBhqu8^8~
z&Ln^@w@L9rWK&HwcTi77f%OT+^Q%E7*49MNhoNu0<e>br9Pa$mKF(vu)!RRDpj@r{
z`?4>7YkM>@a<s5geawg7RACp?T7coP&&nl;aL37;Ze(TXHCHs-?N^TKwr%Wi;7Rc>
zXB;R?2V6MJ8T};w2GCADG&&!!Vfbllv}#;E@4S;M)1=uV<93Yn^;>1g?BY<8dTOXy
zRo*-rDO4Jgb6aju3?Mr7O&H-0<qq8G(>W^ggaa&lz}<F|i-eC84u1QbONjneU8}4v
zR{A=BAfPv3B*_z>TWJ~3`Qc21xZY{_CluOY9<mZSa>7rSSD>u4x;jsU4%fIpo+}UD
z5$oiX79^0f`{m9VzrTNMve108AxyO>DKzt0(*>R(x^Oz=`ScM5i4)%!1Uex>&+a~&
z*EtVi4_}-$t=piD2-W!TWL@Tn6%i~QZnCwJJh=kWD2=Ix{PQ{<V*wQSc`^Tq-l}dn
bU1n$7$<w!GE@&Ou`<uq<ndlblTnPI=%LN}g

literal 0
HcmV?d00001

diff --git a/scss/_AssetAdmin.scss b/scss/_AssetAdmin.scss
index fd709b05..5e9ca93c 100644
--- a/scss/_AssetAdmin.scss
+++ b/scss/_AssetAdmin.scss
@@ -1,4 +1,47 @@
 .cms .AssetAdmin {
+	.cms-content-header-tabs {
+		.ui-tabs-nav {
+			li {
+				a {
+					font-weight: bold;
+					line-height: 16px;
+					padding: 12px 20px 11px;
+					text-indent:-9999em;
+
+					&.content-treeview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat 2px 0px;
+					}
+					&.content-galleryview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat -87px 0px;
+					}
+					&.content-listview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat -38px 0px;
+					}
+				}
+			}
+			
+			.ui-state-active, 
+			.ui-widget-content .ui-state-active, 
+			.ui-widget-header .ui-state-active {
+				border: {
+					top:none;
+				}
+		
+				a {
+					&.content-treeview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat 2px -40px;
+					}
+					&.content-galleryview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat -87px -40px;
+					}
+					&.content-listview {
+						background:url(../images/content-header-tabs-sprite.png) no-repeat -38px -40px;
+					}
+				}
+			}
+		}
+	}
+
 	.cms-content-toolbar {
 		.cms-page-add-button {
 			@include background-image (linear-gradient(lighten(#e6e6e6, 5%), darken(#e6e6e6, 5%)));
@@ -44,4 +87,5 @@
 			}
 		}
 	}
-} 
\ No newline at end of file
+} 
+	
\ No newline at end of file

From c226554b5a847bcf894c44db98edc2dc37b2b55f Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 15:25:45 +0100
Subject: [PATCH 15/20] MINOR Adjusted AssetAdmin to GridFieldAction_ * class
 renames

---
 code/controllers/AssetAdmin.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index d2d130b4..21e2c7e8 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -122,8 +122,8 @@ JS
 			new GridFieldSortableHeader(),
 			new GridFieldDefaultColumns(),
 			new GridFieldPaginator(15),
-			new GridFieldAction_Edit(),
-			new GridFieldAction_Delete(),
+			new GridFieldDeleteAction(),
+			new GridFieldEditAction(),
 			new GridFieldPopupForms()
 		);
 		$gridField = new GridField('File','Files', $this->getList(), $gridFieldConfig);

From f085583b61de731d9c3d019f33cd3e59c6d04536 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 17:26:02 +0100
Subject: [PATCH 16/20] ENHNANCEMENT Creating folders via (faster) JavaScript
 prompt in AssetAdmin, implicitly fixing AssetAdmin->doAdd() layout issues
 after submitting

---
 code/controllers/AssetAdmin.php | 38 ++++++++++++++++++++++-----------
 javascript/AssetAdmin.js        | 16 ++++++++++++++
 javascript/lang/en_US.js        |  3 ++-
 3 files changed, 43 insertions(+), 14 deletions(-)

diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php
index 21e2c7e8..e85a2f15 100644
--- a/code/controllers/AssetAdmin.php
+++ b/code/controllers/AssetAdmin.php
@@ -160,7 +160,12 @@ JS
 			$addFolderBtn = new LiteralField(
 				'AddFolderButton', 
 				sprintf(
-					'<a class="ss-ui-button ss-ui-action-constructive cms-panel-link" data-icon="add" href="%s">%s</a>',
+					'<a class="ss-ui-button ss-ui-action-constructive cms-add-folder-link" data-icon="add" data-url="%s" href="%s">%s</a>',
+					Controller::join_links($this->Link('AddForm'), '?' . http_build_query(array(
+						'action_doAdd' => 1,
+						'ParentID' => $folder->ID,
+						'SecurityID' => $form->getSecurityToken()->getValue()
+					))),
 					Controller::join_links($this->Link('addfolder'), '?ParentID=' . $folder->ID),
 					_t('Folder.AddFolderButton', 'Add folder')
 				)
@@ -335,9 +340,9 @@ JS
 		$fields->dataFieldByName('ParentID')->setValue($this->request->getVar('ParentID'));
 		$form->setFields($fields);
 
-		$form->addExtraClass('cms-edit-form');
 		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
-		$form->addExtraClass('center ' . $this->BaseCSSClasses());
+		// TODO Can't merge $FormAttributes in template at the moment
+		$form->addExtraClass('cms-add-form cms-edit-form cms-panel-padded center ' . $this->BaseCSSClasses());
 		
 		return $form;
 	}
@@ -358,20 +363,23 @@ JS
 			singleton($class)->hasExtension('Hierarchy') 
 			&& isset($data['ParentID'])
 			&& is_numeric($data['ParentID'])
+			&& $data['ParentID']
 		) {
 			$parentRecord = DataObject::get_by_id($class, $data['ParentID']);
 			if(
 				$parentRecord->hasMethod('canAddChildren') 
 				&& !$parentRecord->canAddChildren()
 			) return Security::permissionFailure($this);
+		} else {
+			$parentRecord = null;
 		}
 
 		$parent = (isset($data['ParentID']) && is_numeric($data['ParentID'])) ? (int)$data['ParentID'] : 0;
 		$name = (isset($data['Name'])) ? basename($data['Name']) : _t('AssetAdmin.NEWFOLDER',"NewFolder");
-		if(!isset($parentRecord) || !$parentRecord->ID) $parent = 0;
+		if(!$parentRecord || !$parentRecord->ID) $parent = 0;
 		
 		// Get the folder to be created		
-		if(isset($parentRecord->ID)) $filename = $parentRecord->FullPath . $name;
+		if($parentRecord && $parentRecord->ID) $filename = $parentRecord->FullPath . $name;
 		else $filename = ASSETS_PATH . '/' . $name;
 
 		// Actually create
@@ -397,14 +405,10 @@ JS
 		mkdir($record->FullPath);
 		chmod($record->FullPath, Filesystem::$file_create_mask);
 
-		if($this->isAjax()) {
-			$link = Controller::join_links($this->Link('show'), $record->ID);
-			$this->getResponse()->addHeader('X-ControllerURL', $link);
-			$form = $this->getEditForm($record->ID);
-			return $form->forTemplate();
-		} else {
-			return $this->redirect(Controller::join_links($this->Link('show'), $record->ID));
-		}
+		$parentID = $parentRecord ? $parentRecord->ID : 'root';
+		$link = Controller::join_links($this->Link('show'), $parentID);
+		$this->getResponse()->addHeader('X-ControllerURL', $link);
+		return $this->redirect($link);
 	}
 
 	/**
@@ -563,6 +567,14 @@ JS
 			)));
 		}
 
+		// If we're adding a folder, note that in breadcrumbs as well
+		if($this->request->param('Action') == 'addfolder') {
+			$items->push(new ArrayData(array(
+				'Title' => _t('Folder.AddFolderButton', 'Add folder'),
+				'Link' => false
+			)));
+		}
+
 		// TODO Remove once ViewableData->First()/Last() is fixed
 		foreach($items as $i => $item) $item->iteratorProperties($i, $items->Count());
 
diff --git a/javascript/AssetAdmin.js b/javascript/AssetAdmin.js
index 3da0126c..ddd72658 100644
--- a/javascript/AssetAdmin.js
+++ b/javascript/AssetAdmin.js
@@ -52,6 +52,22 @@
 			}
 		});
 
+		/**
+		 * Prompt for a new foldername, rather than using dedicated form.
+		 * Better usability, but less flexibility in terms of inputs and validation.
+		 * Mainly necessary because AssetAdmin->AddForm() returns don't play nicely
+		 * with the nested AssetAdmin->EditForm() DOM structures.
+		 */
+		$('.AssetAdmin .cms-add-folder-link').entwine({
+			onclick: function(e) {
+				var name = prompt(ss.i18n._t('Folder.Name'));
+				if(!name) return false;
+
+				this.closest('.cms-container').loadPanel(this.data('url') + '&Name=' + name);
+				return false;
+			}
+		});
+
 		/**
 		 * Class: #Form_SyncForm
 		 */
diff --git a/javascript/lang/en_US.js b/javascript/lang/en_US.js
index 7124a7cb..1b98091f 100644
--- a/javascript/lang/en_US.js
+++ b/javascript/lang/en_US.js
@@ -35,6 +35,7 @@ if(typeof(ss) == 'undefined' || typeof(ss.i18n) == 'undefined') {
 		'SecurityAdmin.BATCHACTIONSDELETECONFIRM': "Do you really want to delete %s groups?",
 		'CMSMAIN.AddSearchCriteria': 'Add Criteria',
 		'WidgetAreaEditor.TOOMANY': 'Sorry, you have reached the maximum number of widgets in this area',
-		'AssetAdmin.ConfirmDelete': 'Do you really want to delete this folder and all contained files?'
+		'AssetAdmin.ConfirmDelete': 'Do you really want to delete this folder and all contained files?',
+		'Folder.Name': 'Foldername'
 	});
 }

From 953e2bd1c74ebb06355acf8855e6211de6c467cb Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 17:26:34 +0100
Subject: [PATCH 17/20] MINOR Fixed overloaded delete confirmations in
 AssetAdmin.js

---
 javascript/AssetAdmin.js | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/javascript/AssetAdmin.js b/javascript/AssetAdmin.js
index ddd72658..701c76af 100644
--- a/javascript/AssetAdmin.js
+++ b/javascript/AssetAdmin.js
@@ -28,10 +28,10 @@
 		 * Load folder detail view via controller methods
 		 * rather than built-in GridField view (which is only geared towards showing files).
 		 */
-		$('#Form_EditForm_File .ss-gridfield-item').entwine({
+		$('.AssetAdmin.cms-edit-form .ss-gridfield-item').entwine({
 			onclick: function(e) {
 				// Let actions do their own thing
-				if($(e.target).is('.action')) {
+				if($(e.target).closest('.action').length) {
 					this._super(e);
 					return;
 				}
@@ -45,7 +45,17 @@
 			}
 		});
 
-		$('.cms-edit-form :submit[name=action_delete]').entwine({
+		$('.AssetAdmin.cms-edit-form .action.gridfield-button-delete').entwine({
+			onclick: function(e) {
+				if(!confirm(ss.i18n._t('AssetAdmin.ConfirmDelete'))) return false;
+				
+				this.getGridField().reload({data: [{name: this.attr('name'), value: this.val()}]});
+				e.preventDefault();
+				return false;
+			}
+		});
+
+		$('.AssetAdmin.cms-edit-form :submit[name=action_delete]').entwine({
 			onclick: function(e) {
 				if(!confirm(ss.i18n._t('AssetAdmin.ConfirmDelete'))) return false;
 				else this._super(e);

From c94308d21de1eb5082054e3523e112747cfed390 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 17:31:02 +0100
Subject: [PATCH 18/20] MINOR Implemented "Add new" link in CMSPagesController

---
 code/controllers/CMSPagesController.php                 | 4 ++++
 templates/Includes/CMSPagesController_ContentToolbar.ss | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/code/controllers/CMSPagesController.php b/code/controllers/CMSPagesController.php
index 84ff954e..32957e09 100644
--- a/code/controllers/CMSPagesController.php
+++ b/code/controllers/CMSPagesController.php
@@ -39,6 +39,10 @@ class CMSPagesController extends CMSMain {
 		return false;
 	}
 
+	function AddLink() {
+		return singleton("CMSPageAddController")->Link();
+	}
+
 	public function currentPageID() {
 		return false;
 	}
diff --git a/templates/Includes/CMSPagesController_ContentToolbar.ss b/templates/Includes/CMSPagesController_ContentToolbar.ss
index 9941df02..f5271236 100644
--- a/templates/Includes/CMSPagesController_ContentToolbar.ss
+++ b/templates/Includes/CMSPagesController_ContentToolbar.ss
@@ -13,7 +13,7 @@
 </div>
 
 <div class="cms-actions-row">
-	<a class="ss-ui-button ss-ui-action-constructive" data-icon="add" href="#cms-page-add-form"><% _t('CMSMain.AddNewButton', 'Add new') %></a>
+	<a class="ss-ui-button ss-ui-action-constructive cms-panel-link" data-icon="add" href="$AddLink"><% _t('CMSMain.AddNewButton', 'Add new') %></a>
 </div>
 
 <div class="cms-content-batchactions">

From 79269a22edf0a9149107f4c29d61fbd7edca0d8f Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 18:19:38 +0100
Subject: [PATCH 19/20] MINOR Moved CMSMain->RootForm() to
 CMSSettingsController (same effect, but clearer structure)

---
 code/controllers/CMSMain.php               | 30 ----------------------
 code/controllers/CMSSettingsController.php | 27 +++++++++++++++++--
 2 files changed, 25 insertions(+), 32 deletions(-)

diff --git a/code/controllers/CMSMain.php b/code/controllers/CMSMain.php
index 8a0765f4..992bcd8d 100644
--- a/code/controllers/CMSMain.php
+++ b/code/controllers/CMSMain.php
@@ -38,7 +38,6 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
 		'publishall',
 		'publishitems',
 		'PublishItemsForm',
-		'RootForm',
 		'sidereport',
 		'SideReportsForm',
 		'submit',
@@ -525,41 +524,12 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
 			$this->extend('updateEditForm', $form);
 
 			return $form;
-		} if ($id == 0 || $id == 'root') {
-			return $this->RootForm();
 		} else if($id) {
 			return new Form($this, "EditForm", new FieldList(
 				new LabelField('PageDoesntExistLabel',_t('CMSMain.PAGENOTEXISTS',"This page doesn't exist"))), new FieldList()
 			);
 		}
 	}
-
-	/**
-	 * @return Form
-	 */
-	function RootForm() {
-		$siteConfig = SiteConfig::current_site_config();
-		$fields = $siteConfig->getCMSFields();
-
-		$actions = $siteConfig->getCMSActions();
-		$form = new Form($this, 'RootForm', $fields, $actions);
-		$form->addExtraClass('root-form');
-		$form->addExtraClass('cms-edit-form');
-		// TODO Can't merge $FormAttributes in template at the moment
-		$form->addExtraClass('cms-content center ss-tabset');
-		if($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
-		$form->setHTMLID('Form_EditForm');
-		$form->loadDataFrom($siteConfig);
-		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
-
-		// Use <button> to allow full jQuery UI styling
-		$actions = $actions->dataFields();
-		if($actions) foreach($actions as $action) $action->setUseButtonTag(true);
-
-		$this->extend('updateEditForm', $form);
-
-		return $form;
-	}
 	
 	public function currentPageID() {
 		$id = parent::currentPageID();
diff --git a/code/controllers/CMSSettingsController.php b/code/controllers/CMSSettingsController.php
index da644c91..d9010792 100644
--- a/code/controllers/CMSSettingsController.php
+++ b/code/controllers/CMSSettingsController.php
@@ -6,8 +6,31 @@ class CMSSettingsController extends CMSMain {
 	static $menu_priority = -1;
 	static $menu_title = 'Settings';
 	
-	function getEditForm($id = null, $fields = null) {
-		return $this->RootForm();
+		/**
+	 * @return Form
+	 */
+	function getEditForm($id = null) {
+		$siteConfig = SiteConfig::current_site_config();
+		$fields = $siteConfig->getCMSFields();
+
+		$actions = $siteConfig->getCMSActions();
+		$form = new Form($this, 'EditForm', $fields, $actions);
+		$form->addExtraClass('root-form');
+		$form->addExtraClass('cms-edit-form');
+		// TODO Can't merge $FormAttributes in template at the moment
+		$form->addExtraClass('cms-content center ss-tabset');
+		if($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
+		$form->setHTMLID('Form_EditForm');
+		$form->loadDataFrom($siteConfig);
+		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
+
+		// Use <button> to allow full jQuery UI styling
+		$actions = $actions->dataFields();
+		if($actions) foreach($actions as $action) $action->setUseButtonTag(true);
+
+		$this->extend('updateEditForm', $form);
+
+		return $form;
 	}
 	
 	function PreviewLink() {

From ce5204f2f83cff7172f30080da9cd0b0a56dd138 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 8 Mar 2012 20:02:15 +0100
Subject: [PATCH 20/20] MINOR Respect permission failures from parent
 implementation in CMSPageHistoryController

---
 code/controllers/CMSPageHistoryController.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/code/controllers/CMSPageHistoryController.php b/code/controllers/CMSPageHistoryController.php
index ed0778d0..ac328398 100644
--- a/code/controllers/CMSPageHistoryController.php
+++ b/code/controllers/CMSPageHistoryController.php
@@ -82,6 +82,8 @@ class CMSPageHistoryController extends CMSMain {
 		$versionID = ($record) ? $record->Version : $versionID;
 		
 		$form = parent::getEditForm($record, ($record) ? $record->getCMSFields() : null);
+		// Respect permission failures from parent implementation
+		if(!($form instanceof Form)) return $form;
 
 		$form->setActions(new FieldList(
 			$revert = FormAction::create('doRollback', _t('CMSPageHistoryController.REVERTTOTHISVERSION', 'Revert to this version'))->setUseButtonTag(true)