Commit Graph

262 Commits

Author SHA1 Message Date
micmania1 d112ca5d12 FIX handling of fulltext indexes declared as strings 2014-08-16 10:16:20 +00:00
James Pluck b148e2457c FIX Total Items count on Search
This issue causes pagination to fail for search results on sites
using the postgres db.

Patch corrects the TotalItems in the returned List to show all items
matching the search criteria rather than just the items returned in
the current 'page' requested.
2014-08-01 15:33:58 +12:00
torleif eac309696d FIX postgres filter on non text fields - on branch 1.1
See 7626d74bee
2014-07-25 21:25:54 +12:00
Damian Mooyman 731e25fe5a Merge pull request #31 from tractorcow/pulls/fix-master
BUG Fix issues in master
2014-07-18 17:08:00 +12:00
Damian Mooyman 010ce575ed BUG Fix issues in master 2014-07-18 13:06:58 +12:00
ClayLennart d9699fa28d Add bigint support 2014-07-15 09:44:01 +02:00
Simon Welsh 0c07807e1f Merge pull request #14 from tractorcow/3.2-pdo-connector
API Upgraded module to use new database ORM
2014-07-11 10:34:13 +10:00
Simon Welsh 4f6a9523f6 Don't test against unsupported core versions 2014-07-11 09:26:11 +10:00
Simon Welsh 042eb98dfe Don't test against unsupported core versions 2014-07-11 09:25:44 +10:00
Simon Welsh 191846ee4a Merge pull request #29 from tractorcow/pulls/alias-version
Alias dev-master as 1.2
2014-07-11 09:23:38 +10:00
Damian Mooyman c864f27d61 Alias dev-master as 1.2
Include composer installation instructions
2014-07-11 09:35:34 +12:00
Damian Mooyman abe3843012 API Upgraded module to use new database ORM 2014-07-11 09:13:52 +12:00
Simon Welsh f3be11732c Minimum version is now 3.2 2014-07-09 19:31:12 +10:00
Simon Welsh 6c966276ab Create 1.1 branch for pre-3.2 support 2014-07-09 19:26:27 +10:00
torleif 7626d74bee FIX postgres can filter on non text fields
This issue causes the comparison to fail if comparing a non text fields (for example, a date or integer). This will cause the CMS to fail in places such as Gridfield selector. 

Similar fix as this one: https://github.com/silverstripe/silverstripe-framework/pull/2242 The difference being comparisonClause(...) being more apt solution in SS 3.1
2014-04-08 13:24:05 +12:00
Ingo Schommer 4ca243fc68 Added travis support 2014-02-18 17:56:10 +13:00
Sam Minnee 863ead3255 FIX: Fix fatal bugs in previous commit. 2014-02-14 15:27:36 +13:00
Sam Minnée bc37bf7a4f Merge pull request #24 from sminnee/fix-select-database
FIX: PostgreSQLDatabase::selectDatabase() should switch to the database ...
2014-02-14 14:34:49 +13:00
Sam Minnee f967c20383 FIX: PostgreSQLDatabase::selectDatabase() should switch to the database if it exists.
Previous implementation of PostgreSQLDatabase::selectDatabase() just updated internal
registers, and expected connectDatabase() or similar to be called.  This is out of line
with MySQLDatabase's behaviour, and frankly a bit stupid.  FullTextSearch's test system
expected different behaviour from selectDatabase() and so this is needed to fix that.

Since it's making PostgreSQLDatabase match the behaviour of MySQLDatabase, I don't consider
it an API change.
2014-02-14 13:49:11 +13:00
Simon Welsh b8771b79da Better error handling and support passwords with spaces in them 2013-12-20 14:34:31 +13:00
Sean Harvey 65702e4a6b Merge pull request #22 from stojg/unittest-speed-improvements
NEW: Improve the unittest running time by not truncating tables
2013-06-06 16:40:49 -07:00
Stig Lindqvist 082adb4fd6 NEW: Improve the unittest running time by not truncating tables
When clearing tables this will delete all rows instead of truncating it.

Benchmarking this change by running the full cms and framework test suit changed improved the running time from 32 minutes to 9 minutes.

If truncate functionality is needed for any special cases it should be run as

    DB::query("TRUNCATE \"TableToTruncate\"");
2013-06-06 13:43:31 +12:00
Simon Welsh 9e8b755a59 Merge pull request #13 from ss23/patch-1
Update PostgreSQLDatabaseConfigurationHelper.php
2013-03-24 03:05:15 -07:00
Stephen Shkardoon 0c7362bbc5 Update PostgreSQLDatabaseConfigurationHelper.php
In prepration for https://github.com/silverstripe/sapphire/pull/1319
Probably should accept this at the same time.

If someone knows of the relevant ALTER permissions in Postgres, feel free to implment.
2013-03-24 03:03:59 +13:00
Sam Minnée c389d79398 Merge pull request #12 from stojg/bug-infinite-loop-on-failed-connect
BUG: Infinite loop on failed connect to a postgresql server
2013-02-26 14:46:35 -08:00
Stig Lindqvist 201e5b7b8b BUG: Infinite loop on failed connect to a postgresql server
When a postgres db server is down or credentials are wrone, the adapter still tries to check for a existing database and loops back into trying to connect again.
2013-02-27 11:17:11 +13:00
Ingo Schommer cd7b761bed BUG Faulty query escape in tableList()
This caused tables starting with "sql" to be excluded from
the tableList() results, where only "sql_" should be filtered.
An unescaped underscore in ANSI SQL pattern matching stands
for "any single character", the escape needed to be doubled
to account for PHP's own escape expanding.

This broke SQLQueryTest since the test data wasn't reset
between test runs.
2012-12-11 15:09:10 +01:00
Ingo Schommer fc7a21b567 BUG Support for case sensitive searches
Through newly added Database->comparisonClause() API
2012-12-11 01:47:47 +01:00
Ingo Schommer 8673583f13 Fixed syntax error in searchengine() 2012-11-28 22:48:27 +01:00
Ingo Schommer 618d7f1137 Less restrictive compatibility notation in composer
Support 2.5.x ("post-2.4") as well
2012-11-28 22:07:12 +01:00
Sam Minnée 12e2d69c09 Merge pull request #11 from tractorcow/3.0-unescaped-query-fix
BUG Unescaped query fix
2012-11-15 18:49:15 -08:00
Damian Mooyman 9b623a2b2b BUG Unescaped underscore in query unintentionally hid any table beginning with 'SQL' or 'PG' 2012-11-16 14:42:49 +13:00
Ingo Schommer 5b0684d677 Added 2.4-compatible composer.json 2012-11-09 12:44:06 +01:00
Ingo Schommer 7ba07e905d Corrected minimum requirements, 3.0 only since at least 6e30463e 2012-10-12 15:19:46 +02:00
Sam Minnée c5eb666447 Merge pull request #10 from tractorcow/3.0-index-typo-fix
FIXED: Minor typo in string concatenation
2012-09-23 17:50:59 -07:00
Damian Mooyman ef4cd20cfa FIXED: Minor typo in string concatenation 2012-09-24 12:46:23 +12:00
Ingo Schommer 9924c8d53a Merge pull request #9 from vikas-srivastava/composer
New : Added composer.json
2012-09-22 10:21:46 -07:00
vikas srivastava 53d86394d2 New : Added composer.json
Added composer.json file which will help this module for submission on proposed extension.silverstripe.org website. Please add more fields according to requirement.

For more information please visit at http://extension.openbees.org/instructions/
2012-09-22 20:41:59 +05:30
Sam Minnee 3fe7671442 FIX: Conditional revert of 06f80d3347 as the original code is necessary in some configurations.
Now we have the magic of an if block to guide us.
2012-09-19 17:28:17 +12:00
Sam Minnée c46e45f599 Merge pull request #7 from silverstripe/index-fixes
Index fixes
2012-09-17 18:25:33 -07:00
Sam Minnee 06f80d3347 FIX: Fix the apparently obsolete code for extracting search index columns from the trigger meta-data. 2012-09-18 13:19:22 +12:00
Sam Minnee 54821bde2d FIX: Fixed PostgreSQLDatabase::indexList() / PostgresSQLDatabase::requireIndex() so that it doesn't need to infer the ORM-name for the index in order to determine the schema update. 2012-09-18 13:19:19 +12:00
Sam Minnee 8cd7cc5127 Removed unnecessary exec bit. 2012-09-18 12:49:21 +12:00
Sam Minnée c22f7faa53 Merge pull request #6 from tractorcow/3.0-ddl-fixes
3.0 ddl fixes
2012-09-16 23:41:52 -07:00
Damian Mooyman 37199fc08c FIXED: Incorrect paging on full text search results 2012-09-17 16:51:20 +12:00
Damian Mooyman 3291147c8e FIXED: Issue with correct extraction of index names from the database. The root cause of this issue was the way that columns from indxes were retrieved. It was assumed that the column names formed the index name, which isn't necessarily true (E.g. when the index is named "SearchFields"). The behaviour of the module was updated to create case-sensitive index and trigger names, which could then be used to later tell Silverstripe which indexes existed in the database. These could be compared to the SiteTree::$indexes property in a case-sensitive fashion to determine which indexes needed to be created / updated. This update fixes a lot of the unnecessary/broken DDL operations that occurred. 2012-09-17 16:15:00 +12:00
Damian Mooyman dc7334087c FIXED: Improved parsing of index strings to support more index formats (array, string, variable index types in either form, etc).
UPDATED: Syntax to conform (better) to SS coding convention
UPDATED: Refactor, cleanup, and simplification of alterTable to reduce duplication of effort. Use of index parsing mechanism to pre-prepare indexe specifications for generation.
UPDATED: Better naming of variables (For instance, $indexName instead of $k)
BUG: Index generation is still not working properly. To investigate.
2012-09-17 11:13:41 +12:00
Sam Minnee 8cd458b818 BUGFIX: Make indexList() return double-quotes in index names to prevent unnecessary recreation of the indexes. 2012-08-21 16:22:17 +12:00
Sam Minnee f74e9c260e BUGFIX: Fix support for \ characters in table names. 2012-08-21 16:21:45 +12:00
Hamish Friedlander 5ba1b80391 Merge pull request #5 from phalkunz/master
BUG: Fix PostgreSQL error when creating a table for namespaced data object
2012-08-09 18:43:35 -07:00