tonyair/silverstripe-postgresql
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-postgresql synced 2024-06-15 17:21:52 +02:00
Code Issues Projects Releases Wiki Activity

BUG Fix pg_query / pg_query_params not correctly raising exceptions on error

Browse Source
This commit is contained in:
Damian Mooyman 2016-07-04 12:44:34 +12:00
parent 946d429c41
commit f797f49aeb
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/PostgreSQLConnector.php
View File

@ -221,14 +221,16 @@ class PostgreSQLConnector extends DBConnector
} }
// Execute query // Execute query
// Unfortunately error-suppression is required in order to handle sql errors elegantly.
// Please use PDO if you can help it
if (!empty($parameters)) { if (!empty($parameters)) {
$result = pg_query_params($this->dbConn, $sql, $parameters); $result = @pg_query_params($this->dbConn, $sql, $parameters);
} else { } else {
$result = pg_query($this->dbConn, $sql); $result = @pg_query($this->dbConn, $sql);
} }
// Handle error // Handle error
if ($result === false) { if (!$result) {
$this->databaseError($this->getLastError(), $errorLevel, $sql, $parameters); $this->databaseError($this->getLastError(), $errorLevel, $sql, $parameters);
return null; return null;
} }