From 7bb29a928849f70109a19dd98abe21e8b532ff5d Mon Sep 17 00:00:00 2001 From: David Preece Date: Sat, 14 Mar 2015 12:14:54 +1300 Subject: [PATCH] Fixes alter table problem If you can log in (with write permissons), you can alter tables. --- code/PostgreSQLDatabaseConfigurationHelper.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/code/PostgreSQLDatabaseConfigurationHelper.php b/code/PostgreSQLDatabaseConfigurationHelper.php index bbb65d5..d131798 100644 --- a/code/PostgreSQLDatabaseConfigurationHelper.php +++ b/code/PostgreSQLDatabaseConfigurationHelper.php @@ -177,16 +177,16 @@ class PostgreSQLDatabaseConfigurationHelper implements DatabaseConfigurationHelp } public function requireDatabaseAlterPermissions($databaseConfig) { - $success = false; $conn = $this->createConnection($databaseConfig, $error); if($conn) { - // Check if this user has create privileges on the default tablespace - $sqlUsername = $this->quote($conn, $databaseConfig['username']); - $permissions = $this->query($conn, "select * from has_tablespace_privilege($sqlUsername, 'pg_default', 'create')"); - $success = $permissions && (reset($permissions) == 't'); + // if the account can even log in, it can alter tables + return array( + 'success' => true, + 'applies' => true + ); } return array( - 'success' => $success, + 'success' => false, 'applies' => true ); }