Commit Graph

129 Commits

Author SHA1 Message Date
Sean Harvey
c2ba6d441f API CHANGE Added currentSessionHash property to MultiForm which stores the currently opened session by the user
API CHANGE Renamed MultiForm::getSessionRecord() to getCurrentSession() and removed the parameter, since this wasn't done in a very OOP manner
MINOR Test for MultiFormSession::markCompleted() to ensure that session can't be used again by MultiForm
2009-08-05 10:12:13 +00:00
Rainer Spittel
a907cc6493 ENHANCEMENT: enabled MultiForm to use customised action (actions_exempt_from_validation).
Changed has been done in the constructor to read the static variables (incl. overwritten variables).
2009-07-27 23:14:04 +00:00
Sean Harvey
8e04dfbaa5 MINOR Tidy up of tests 2009-07-20 09:22:49 +00:00
Normann Lou
07120018bf BUGFIX: MultiFormStep::saveInto() need the current Controller as the new $form Controller to work 2009-06-03 01:47:36 +00:00
Sean Harvey
04130ad501 BUGFIX If the step doesn't exist, don't attempt to delete it 2009-04-27 23:13:21 +00:00
Will Rossiter
3690de6943 MINOR: added is_numeric check to prevent form failing on certain cases 2009-01-29 09:27:17 +00:00
Sean Harvey
ef436eadd4 BUGFIX Ensure that any relations to MultiFormStep are destroyed before calling delete() 2009-01-27 10:47:22 +00:00
Sean Harvey
70b7e95c81 Reverted r70810 which didn't have a commit message 2009-01-27 10:45:46 +00:00
Sean Harvey
7e9d014eee 2009-01-27 10:44:40 +00:00
Sean Harvey
203bb03286 MINOR Reuse of $currentStep variable, instead of retrieving the step again 2008-12-17 11:11:53 +00:00
Sean Harvey
9f8d2e1da8 ENHANCEMENT Removed hack of specific action to bypass validation and allow specifying actions to be exempt through a public static variable 2008-12-17 11:08:46 +00:00
Ingo Schommer
a867db5fe8 ENHANCEMENT Added MultiFormStep->saveInto() to simulate Form->saveInto() behaviour with a stub form. This is preferred method of saving step data into a DataObject, instead of using $myObj->update($myStep->loadData()), is update() doesn't trigger custom formfield saving behaviour (e.g. to save relations on an existing dataobject for CheckboxSetField) 2008-10-09 00:36:46 +00:00
Sean Harvey
a8877b780f ENHANCEMENT Made MultiForm->prev() do the same behaviour for saving data as MultiForm->next() 2008-10-01 22:18:44 +00:00
Sean Harvey
647a5257e3 MINOR Removed unused static function is_action_field from MultiForm 2008-10-01 21:10:20 +00:00
Sean Harvey
053ac04387 MINOR Removed @usedby, it's not a valid phpdoc token 2008-10-01 21:06:56 +00:00
Ingo Schommer
7968b09fea ENHANCEMENT Added MultiForm->getSavedSteps() and MultiForm->getSavedStepByClass()
ENHANCEMENT Added MultiFormStep->validateStep() for custom validation routines
ENHANCEMENT Changed MultiForm->save() to use $form->getData() instead of $data to ensure that all fields are saveable into a DataObject (had trouble with ConfirmedPasswordField returning array instead of string)
2008-10-01 18:36:52 +00:00
Sean Harvey
228d03592e MINOR Removed old MultiForm::__construct() comments 2008-09-20 09:36:54 +00:00
Sean Harvey
c97022314f MINOR Code syntax formatting and removal of useless comment 2008-09-20 09:31:44 +00:00
Sean Harvey
1ba27d9c7d MINOR Removed MultiFormSession::[Data] which is never used 2008-07-21 21:07:48 +00:00
Sean Harvey
a42bb6103b BUGFIX Removing url_type which isnt very useful MINOR documentation updates ENHANCEMENT return value on MultiForm->setCurrentStep() MINOR code cleanup in general 2008-07-21 21:06:59 +00:00
Sean Harvey
1b662ff9e1 BUGFIX $this->form wasn't accessible on MultiFormStep because it wasn't being set by MultiForm->__construct() early enough in the piece 2008-07-21 05:22:06 +00:00
Sean Harvey
69b5cd6686 Don't validate if not necessary - merged from branches/kiwiselect 2008-07-21 05:14:04 +00:00
Sean Harvey
6abbe5b44f MINOR where[] can't be used for reading 2008-07-21 04:40:18 +00:00
Sean Harvey
8d138f4059 MINOR Removed 3 useless lines of code 2008-07-21 03:34:27 +00:00
Sean Harvey
78080c6238 ENHANCEMENT Correct use of parent::__construct() so that fields, actions and validation are correctly set without extra code to set them on MultiForm 2008-07-21 03:21:51 +00:00
Sean Harvey
80e71b5ccf BUGFIX SQL injection possibility fix on MultiForm->getSessionRecordByID() 2008-07-09 06:34:28 +00:00
Sean Harvey
f362ed07be BUGFIX Disable security token inherited from Form. We do not require this as we tie a MultiForm instance to a MultiFormSession via a URL parameter 2008-07-04 01:07:33 +00:00
Sean Harvey
58b7bb2210 MINOR echo out the amount of session records that were deleted on MultiFormPurgeTask 2008-07-02 00:54:22 +00:00
Sean Harvey
9da9a611a0 BUGFIX Made MultiFormPurgeTask greatly simplified, and workable - it simply deletes all session data after days specified in $session_expiry_days 2008-07-02 00:39:40 +00:00
Sean Harvey
fce12220b2 ENHANCEMENT Allowed static $ignored_fields to be overloaded on subclass of MultiForm, so specific fields can be ignored 2008-07-01 23:57:07 +00:00
Sean Harvey
3b9f092ac1 BUGFIX We now call $nextStep->Link and $prevStep->Link() instead of $this->getCurrentStep()->Link() on MultiForm->next() and MultiForm->prev() which is confusing, and doesn't always work 2008-06-23 05:06:36 +00:00
Sean Harvey
295cd5077e API CHANGE Ticket #2562 - Cleaner instanciation of MultiForm subclass, init() is removed with the move of session/step initialization to __construct() 2008-06-19 10:29:47 +00:00
Sean Harvey
35f2de5de3 ENHANCEMENT MultiFormStep->form can now be accessed to return the form that the step was created on 2008-06-18 08:07:11 +00:00
Sean Harvey
e4e43ee4af ENHANCEMENT prev() now saves the current step data, exactly as next() does 2008-06-05 01:13:55 +00:00
Sean Harvey
4d0e9491cc ENHANCEMENT Don't validate if hitting the "prev" action 2008-06-05 01:12:08 +00:00
Sean Harvey
2bb5983f19 Added TODO for what $can_go_back doesn't do yet! 2008-05-27 04:54:24 +00:00
Sean Harvey
4f758064d9 FEATURE Allow setting a flag (true, by default) so that you can't use the "back" form action for a step. 2008-05-27 04:49:16 +00:00
Sean Harvey
2385c23d63 BUGFIX getCurrentStep should be called as a method, not a property 2008-05-26 04:06:09 +00:00
Sean Harvey
b0f45b505b BUGFIX validator couldn't tie itself to a form correctly, encapsulated validator setup on MultiForm->setValidator() 2008-05-24 23:49:49 +00:00
Sean Harvey
edcdbf8935 Fixed re-creating of a new Hash field even if one exists, also fixed non-object errors through better structured setSession() method 2008-05-14 11:30:35 +00:00
Sean Harvey
54164a129f Whitespace 2008-05-14 10:57:41 +00:00
Sean Harvey
6cfe0680c0 Added TODO items to fix later 2008-05-14 10:57:25 +00:00
Sean Harvey
927e974724 Added TODO about session being "baked" into MultiForm directly 2008-05-14 10:45:19 +00:00
Sean Harvey
8d93736482 Fall back to using the class name if there is no title property set 2008-05-14 10:40:19 +00:00
Sean Harvey
56325faf8f added an accessor method for $this->session 2008-05-14 10:22:58 +00:00
Sean Harvey
626c272b6f Remove the relation as well as delete the object 2008-05-14 07:16:38 +00:00
Sean Harvey
652c0af4c2 Added parent::onBeforeDelete() - without this, it breaks! 2008-05-14 06:54:53 +00:00
Sean Harvey
ff9662f9f5 Revert last change 2008-04-30 03:47:33 +00:00
Sean Harvey
3872ca004c Don't need to check if data exists first 2008-04-30 03:46:35 +00:00
Sean Harvey
75a4fb78d5 Added TODO 2008-04-29 09:50:06 +00:00
Sean Harvey
ac09ddfa86 Removed the disabling of SecurityID 2008-04-28 06:42:32 +00:00
Sean Harvey
d878a45645 tweaked doc 2008-04-28 03:13:29 +00:00
Sean Harvey
9475fabee7 Fixed old documentation 2008-04-28 03:13:03 +00:00
Sean Harvey
20207a8dee Disable default form security token - our sessions are identified by URL, so this won't work! (Although we could possibly find a better way than simply disabling this in the future) 2008-04-28 03:10:13 +00:00
Sean Harvey
dac113fe3d Made the hidden field work the same way as the FormAction() 2008-04-23 10:46:11 +00:00
Sean Harvey
6f07bf39b2 Added phpdoc to methods and classes 2008-04-22 11:03:03 +00:00
Sean Harvey
ec747bc6c6 Documented loadData() and saveData() 2008-04-21 08:54:48 +00:00
Sean Harvey
aa6236b495 Added getController (an accessor method to $this->controller so we can use $Controller, or <% control Controller %> in the form templates) 2008-04-21 08:32:05 +00:00
Sean Harvey
22d9241021 Added getPreviousStepFromDatabase() to return the previous step class record from the database (if it exists!) 2008-04-21 05:06:47 +00:00
Sean Harvey
6baef78fd3 Added missing doc on init() 2008-04-20 22:07:18 +00:00
Sean Harvey
18fe36cdd9 Encapsulated getting session records, added notes 2008-04-20 09:28:02 +00:00
Sean Harvey
a4a78b82cb Use microtime() 2008-04-20 05:59:15 +00:00
Sean Harvey
985abc7557 Variable name change 2008-04-20 00:44:14 +00:00
Sean Harvey
b298e83a0f Removed two of the same calls, just use one outside the if-else block instead 2008-04-20 00:43:19 +00:00
Sean Harvey
0d3196607a Made use of MultiFormStep::getNextStepFromDatabase() instead of direct DO::get() call, and check for SessionID before attempting a DO::get() 2008-04-20 00:39:01 +00:00
Sean Harvey
facf2e3833 Docs, bug fixes in code 2008-04-20 00:28:49 +00:00
Sean Harvey
eb5b57f418 encapsulated $this->session->CurrentStep() calls to getCurrentStep() 2008-04-20 00:28:18 +00:00
Sean Harvey
a0dfd338fb Encapsulated procedures from init() into their own methods, specifically, setSession() which sets up the current multiform session, and getCurrentStep() is now smarter and setCurrentStep() does the step writing responsibilities 2008-04-20 00:01:27 +00:00
Sean Harvey
75cee5851a Removed TODO that's been done! 2008-04-19 03:42:17 +00:00
Sean Harvey
75ce791dca Added documentation 2008-04-19 01:23:28 +00:00
Sean Harvey
a47191c802 Removed calls to previously removed methods 2008-04-19 01:21:48 +00:00
Sean Harvey
01fe23fe2f Removed unused methods 2008-04-19 01:19:47 +00:00
Sean Harvey
433d74b94d Added TODO 2008-04-19 01:17:12 +00:00
Sean Harvey
39005fdf84 Added support for Hash identification of a MultiFormSession - probably needs some encapsulation, as we're adding more code to init(), and encapsulate the checking of this->stat('url_type') into it's own method, so you don't need to do the ternary operator so much 2008-04-19 01:14:16 +00:00
Sean Harvey
0775215578 Removed url_type - this isn't done quite yet to be committed. 2008-04-19 00:08:19 +00:00
Sean Harvey
cb0a14e601 Added TODO about expiration 2008-04-19 00:05:02 +00:00
Sean Harvey
101771a096 Added TODO for security 2008-04-18 23:49:01 +00:00
Sean Harvey
a48c1433ea Changed static function isActionField to is_action_field to adhere to coding standards 2008-04-18 23:25:41 +00:00
Sean Harvey
5c76350fba 2008-04-17 22:03:51 +00:00