tonyair/silverstripe-mssql
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-mssql synced 2024-09-30 21:29:29 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX: sqlserv crashes php if there are too many open handles - free the handle as soon as the end of the dataset is reached

Browse Source
This commit is contained in:
Andrew O'Neil 2009-09-14 01:44:58 +00:00
parent ddbd0fda5d
commit bdddbc61a5
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/MSSQLDatabase.php
View File

@ -1336,7 +1336,7 @@ class MSSQLQuery extends Query {
if($this->mssql) {
mssql_free_result($this->handle);
} else {
sqlsrv_free_stmt($this->handle);
if($this->handle) sqlsrv_free_stmt($this->handle);
}
}
@ -1420,7 +1420,7 @@ class MSSQLQuery extends Query {
if (isset($this->cachedRecords) && count($this->cachedRecords) && (!isset($this->cachingRows) || !$this->cachingRows)) {
return array_shift($this->cachedRecords);
}
if($data = sqlsrv_fetch_array($this->handle, SQLSRV_FETCH_NUMERIC)) {
if($this->handle && $data = sqlsrv_fetch_array($this->handle, SQLSRV_FETCH_NUMERIC)) {
$output = array();
$fields = sqlsrv_field_metadata($this->handle);
foreach($fields as $columnIdx => $field) {
@ -1435,6 +1435,12 @@ class MSSQLQuery extends Query {
}
return $output;
} else {
// Free the handle if there are no more results - sqlserv crashes if there are too many handles
if($this->handle) {
sqlsrv_free_stmt($this->handle);
$this->handle = false;
}
return false;
}