tonyair/silverstripe-mssql
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-mssql synced 2024-10-22 08:05:53 +02:00
Code Issues Projects Releases Wiki Activity

BUG Fix SortColumn ORDER BY not working when using a limit

Browse Source 
MSSQL doesn't support putting an alias into the OVER clause,
something which is required when limiting results with an offset.
The workaround is to just put the aggregate inline, taken from
the select list.
This commit is contained in:
Sean Harvey 2012-12-20 15:56:11 +13:00
parent baf3d39cc0
commit 7c369a383a
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
code/MSSQLDatabase.php
View File

@ -1230,8 +1230,20 @@ class MSSQLDatabase extends SS_Database {
// If there's a limit and an offset, then we need to do a subselect // If there's a limit and an offset, then we need to do a subselect
} else if($limit && $offset) { } else if($limit && $offset) {
if($query->getOrderBy()) { $orderby = $query->getOrderBy();
$orderByClause = $this->sqlOrderByToString($query->getOrderBy());
// workaround for subselect not working with alias functions
// just use the function directly in the order by instead of the alias
$selects = $query->getSelect();
foreach($orderby as $field => $dir) {
if(preg_match('/SortColumn/', $field)) {
unset($orderby[$field]);
$orderby[$selects[str_replace('"', '', $field)]] = $dir;
}
}
if($orderby) {
$orderByClause = $this->sqlOrderByToString($orderby);
$rowNumber = "ROW_NUMBER() OVER ($orderByClause) AS Number"; $rowNumber = "ROW_NUMBER() OVER ($orderByClause) AS Number";
} else { } else {
$selects = $query->getSelect(); $selects = $query->getSelect();