tonyair/silverstripe-mssql
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-mssql synced 2024-10-22 08:05:53 +02:00
Code Issues Projects Releases Wiki Activity

Fixing use of "bigint" and "decimal" for pure integer types.

Browse Source 
See https://github.com/silverstripe/silverstripe-mssql/issues/14
for more info.

"bigint" doesn't work for PHP 32-bit, as the integer could get too big
for PHP to be able to interpret the value as an integer type. In that
case it would try to approximate it as a float, but that could lead
to a bad assumption for identity columns.

For compatibility, stick with standard "int" type which has a maximum
value of 2147483647.

Note that MySQLAdapter already has this maximum, so changing it to
this keeps this database adapter consistent with MySQL.
This commit is contained in:
Sean Harvey 2014-07-11 13:42:11 +12:00
parent a6a9b25901
commit 093df443ea
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
code/MSSQLSchemaManager.php
View File

@ -438,12 +438,13 @@ class MSSQLSchemaManager extends DBSchemaManager {
// Update the data_type field to be a complete column definition string for use by // Update the data_type field to be a complete column definition string for use by
// SS_Database::requireField() // SS_Database::requireField()
switch($field['data_type']){ switch($field['data_type']){
case 'int':
case 'bigint': case 'bigint':
case 'numeric': case 'numeric':
case 'float': case 'float':
case 'bit': case 'bit':
if($field['data_type'] != 'bigint' && $sizeSuffix = $field['numeric_precision']) { if($field['data_type'] != 'bigint' && $field['data_type'] != 'int' && $sizeSuffix = $field['numeric_precision']) {
$field['data_type'] .= "($sizeSuffix)"; $field['data_type'] .= "($sizeSuffix)";
} }
if($field['is_nullable'] == 'YES') { if($field['is_nullable'] == 'YES') {
@ -729,8 +730,7 @@ class MSSQLSchemaManager extends DBSchemaManager {
* @return string * @return string
*/ */
public function int($values) { public function int($values) {
//We'll be using an 8 digit precision to keep it in line with the serial8 datatype for ID columns return 'int not null default ' . (int) $values['default'];
return 'numeric(8) not null default ' . (int) $values['default'];
} }
/** /**
@ -788,17 +788,15 @@ class MSSQLSchemaManager extends DBSchemaManager {
/** /**
* This returns the column which is the primary key for each table * This returns the column which is the primary key for each table
* In Postgres, it is a SERIAL8, which is the equivalent of an auto_increment
*
* @return string * @return string
*/ */
function IdColumn($asDbValue = false, $hasAutoIncPK = true){ function IdColumn($asDbValue = false, $hasAutoIncPK = true){
if($asDbValue) { if($asDbValue) {
return 'bigint not null'; return 'int not null';
} else if($hasAutoIncPK) { } else if($hasAutoIncPK) {
return 'bigint identity(1,1)'; return 'int identity(1,1)';
} else { } else {
return 'bigint not null'; return 'int not null';
} }
} }