MINOR Tidy up of code in MSSQLDatabase::__construct()

This commit is contained in:
Sean Harvey 2010-09-29 04:30:05 +00:00
parent 75b1933ca3
commit 083517d02b

View File

@ -134,26 +134,20 @@ class MSSQLDatabase extends SS_Database {
ini_set('sqlsrv.WarningsReturnAsErrors', 'Off'); ini_set('sqlsrv.WarningsReturnAsErrors', 'Off');
} }
// Windows authentication doesn't require a username and password $options = array(
if(defined('MSSQL_USE_WINDOWS_AUTHENTICATION') && MSSQL_USE_WINDOWS_AUTHENTICATION == true) {
$connectionInfo = array(
'CharacterSet' => 'UTF-8',
'MultipleActiveResultSets' => true
);
} else {
$connectionInfo = array(
'UID' => $parameters['username'],
'PWD' => $parameters['password'],
'CharacterSet' => 'UTF-8', 'CharacterSet' => 'UTF-8',
'MultipleActiveResultSets' => true 'MultipleActiveResultSets' => true
); );
if(!(defined('MSSQL_USE_WINDOWS_AUTHENTICATION') && MSSQL_USE_WINDOWS_AUTHENTICATION == true)) {
$options['UID'] = $parameters['username'];
$options['PWD'] = $parameters['password'];
} }
$this->dbConn = sqlsrv_connect($parameters['server'], $connectionInfo);
$this->dbConn = sqlsrv_connect($parameters['server'], $options);
} }
if(!$this->dbConn) { if(!$this->dbConn) {
$this->databaseError("Couldn't connect to MS SQL database"); $this->databaseError('Couldn\'t connect to SQL Server database');
} else { } else {
$this->database = $parameters['database']; $this->database = $parameters['database'];
$this->selectDatabase($this->database); $this->selectDatabase($this->database);