tonyair/silverstripe-mathspamprotection
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-mathspamprotection synced 2024-10-22 08:05:52 +02:00
Code Issues Projects Releases Wiki Activity

Update for strict comparison with ===

Browse Source 
problem: loose comparison with == -> Null = "0"
solved: strict comparison with === -> Null = false
new session with $v1 = 0 and $v2 = 0 did lead to true answer with actually no answer given (Null -> "0")
 0 + 0 = 0 -> true
ref: https://www.php.net/manual/en/types.comparisons.php
This commit is contained in:
Tech-Maou 2021-03-31 17:18:39 +02:00 committed by GitHub
parent 570eec324c
commit ce700643f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/MathSpamProtectorField.php
View File

@ -151,7 +151,7 @@ class MathSpamProtectorField extends TextField
$word = MathSpamProtectorField::digit_to_word($v1 + $v2); $word = MathSpamProtectorField::digit_to_word($v1 + $v2);
return ($word == strtolower($answer) || ($this->config()->get('allow_numeric_answer') && (($v1 + $v2) == $answer))); return ($word == strtolower($answer) || ($this->config()->get('allow_numeric_answer') && (($v1 + $v2) === $answer)));
} }
/** /**