From ea72c5def059a5912b21b40caae4a4df6ddb1c12 Mon Sep 17 00:00:00 2001 From: Sam Minnee Date: Fri, 3 Jul 2015 17:34:58 +0100 Subject: [PATCH] Prefer stable packages while still allowing dev ones. Fixes #100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Although the original ticket recommended increasing our minimum-stability, this change gives us the best of both worlds. - Where stable packages are available and meet the requirements, they will be used. - Where stable packages aren’t available or they don’t meet the dependency requirements, non-stable packages are still allowed. As part of this I have also tightened up the silverstripe-themes req version, as “*” is an anti-pattern. The versioning of the theme has rightly split off from the versioning of the framework; it looks like 3.1.* is what we should expect. Arguably, we could set the dependency to ~3.1, but in this case I think it’s fine to be conservative. --- composer.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index bef0c76..346000e 100644 --- a/composer.json +++ b/composer.json @@ -7,13 +7,14 @@ "silverstripe/framework": "self.version", "silverstripe/reports": "self.version", "silverstripe/siteconfig": "self.version", - "silverstripe-themes/simple": "*" + "silverstripe-themes/simple": "3.1.*" }, "require-dev": { - "phpunit/PHPUnit": "~3.7@stable" + "phpunit/PHPUnit": "~3.7" }, "config": { "process-timeout": 600 }, + "prefer-stable": true, "minimum-stability": "dev" }