MINOR Tweaking of installer text to avoid misleading information about "exists" when there's actually an error

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/phpinstaller/branches/2.4@107366 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
sharvey 2010-07-01 03:16:02 +00:00 committed by Sam Minnee
parent 719b56e137
commit 6de2e4fbd3

View File

@ -231,14 +231,14 @@ class InstallRequirements {
array( array(
"Database Configuration", "Database Configuration",
"Database support", "Database support",
"Database support not included in PHP.") "Database support in PHP")
) )
) { ) {
if($this->requireDatabaseServer( if($this->requireDatabaseServer(
$databaseConfig, $databaseConfig,
array( array(
"Database Configuration", "Database Configuration",
"Database server exists", "Database server",
"I couldn't find a database server on '$databaseConfig[server]'", "I couldn't find a database server on '$databaseConfig[server]'",
$databaseConfig['server'] $databaseConfig['server']
) )
@ -341,9 +341,9 @@ class InstallRequirements {
$this->getBaseDir() $this->getBaseDir()
)); ));
$this->requireFile('mysite', array("File permissions", "mysite/ folder exists", "There's no mysite folder.")); $this->requireFile('mysite', array("File permissions", "mysite/ folder exists?", "There's no mysite folder."));
$this->requireFile('sapphire', array("File permissions", "sapphire/ folder exists", "There's no sapphire folder.")); $this->requireFile('sapphire', array("File permissions", "sapphire/ folder exists?", "There's no sapphire folder."));
$this->requireFile('cms', array("File permissions", "cms/ folder exists", "There's no cms folder.")); $this->requireFile('cms', array("File permissions", "cms/ folder exists?", "There's no cms folder."));
if($isApache) { if($isApache) {
$this->requireWriteable('.htaccess', array("File permissions", "Is the .htaccess file writeable?", null)); $this->requireWriteable('.htaccess', array("File permissions", "Is the .htaccess file writeable?", null));
@ -767,7 +767,7 @@ class InstallRequirements {
$helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']); $helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']);
$result = $helper->requireDatabaseOrCreatePermissions($databaseConfig); $result = $helper->requireDatabaseOrCreatePermissions($databaseConfig);
if($result['success']) { if($result['success']) {
if($result['alreadyExists']) $testDetails[3] = "Database $databaseConfig[database] exists"; if($result['alreadyExists']) $testDetails[3] = "Database $databaseConfig[database]";
else $testDetails[3] = "Able to create a new database"; else $testDetails[3] = "Able to create a new database";
$this->testing($testDetails); $this->testing($testDetails);
return true; return true;