From 66b1ce5e122835755639f384cb16bc02f98fd54c Mon Sep 17 00:00:00 2001 From: sminnee Date: Wed, 13 Oct 2010 04:28:14 +0000 Subject: [PATCH] BUGFIX Fixed InstallerRequirements::isApache() which didn't work if $_SERVER['SERVER_SIGNATURE'] is available for Apache (from r101733) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/phpinstaller/trunk@112224 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- install.php | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/install.php b/install.php index d569e31..a7b7db3 100644 --- a/install.php +++ b/install.php @@ -277,15 +277,16 @@ class InstallRequirements { } function isApache() { - $webserver = strip_tags(trim(@$_SERVER['SERVER_SIGNATURE'])); - if(!$webserver) { - if(isset($_SERVER['SERVER_SOFTWARE'])) { - if(strpos($_SERVER['SERVER_SOFTWARE'], 'Apache') !== false) { - return true; - } - } + $signature = isset($_SERVER['SERVER_SIGNATURE']) + ? $_SERVER['SERVER_SIGNATURE'] + : @$_SERVER['SERVER_SOFTWARE']; + + $signature = strip_tags(trim($signature)); + if($signature && strpos($signature, 'Apache') !== false) { + return true; + } else { + return false; } - return false; } function findWebserver() {