From 612ff2922bd99d2e63f9baf6072c3373136c7a38 Mon Sep 17 00:00:00 2001 From: Guy Sartorelli Date: Mon, 30 May 2022 12:21:41 +1200 Subject: [PATCH 1/2] ENH Add `.graphql-generated` directory by default. This directory will be required for all new projects (unless explicitly opting out of graphql v4) - having this directory by default makes it easier to set more sane permissions (i.e. not requiring the entire project root to be writable). --- .graphql-generated/_manifest_exclude | 0 composer.json | 3 ++- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .graphql-generated/_manifest_exclude diff --git a/.graphql-generated/_manifest_exclude b/.graphql-generated/_manifest_exclude new file mode 100644 index 0000000..e69de29 diff --git a/composer.json b/composer.json index edfb9dd..de6e27b 100644 --- a/composer.json +++ b/composer.json @@ -15,7 +15,8 @@ "extra": { "project-files": [ "app/_config/*", - ".env.example" + ".env.example", + ".graphql-generated/*" ], "public-files": [ "assets/*", From 57195eab039dc8dee91c659bb66ddcc57bf9a54f Mon Sep 17 00:00:00 2001 From: Guy Sartorelli Date: Thu, 2 Jun 2022 10:30:56 +1200 Subject: [PATCH 2/2] ENH Add and ignore public/_graphql silverstripe/graphql v4 needs write access to this directory, so it may be easier for some developers to have the directory there as soon as they `composer create_project silverstripe/installer`. Like `.graphql-generated`, best practice is to not commit this directory to VCS, and instead let it be filled at deploy time. --- .gitignore | 3 ++- public/_graphql/.gitkeep | 0 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 public/_graphql/.gitkeep diff --git a/.gitignore b/.gitignore index eb58de0..7c57c77 100644 --- a/.gitignore +++ b/.gitignore @@ -4,4 +4,5 @@ /themes/simple/ /_resources/ /public/_resources/ -/.graphql-generated +/.graphql-generated/ +/public/_graphql/ diff --git a/public/_graphql/.gitkeep b/public/_graphql/.gitkeep new file mode 100644 index 0000000..e69de29