tonyair/silverstripe-installer
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-installer synced 2024-10-22 17:05:33 +02:00
Code Issues Projects Releases Wiki Activity

API CHANGE Installer now uses a database configuration helper class which isolates the logic of checking the database away from the installer, this interface can be used by other databases like MSSQL and PostgreSQL. The installer now looks for a specific file inside each database module, provided it's configured in install.php MySQL is provided by default, as it lives in sapphire

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/phpinstaller/branches/2.4@98786 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
sharvey 2010-02-11 07:37:08 +00:00 committed by Sam Minnee
parent cb788ccae4
commit 34bad1fc7f
1 changed files with 83 additions and 179 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

244
install.php
View File

@ -50,6 +50,39 @@ if($envFileExists) {
} }
} }
// This is a listing of supported databases, so the installer knows about them
$otherDatabaseLocations = array(
'mssql' => array(
'class' => 'MSSQLDatabase',
'title' => 'SQL Server 2008'
),
'postgresql' => array(
'class' => 'PostgreSQLDatabase',
'title' => 'PostgreSQL'
),
'sqlite3' => array(
'class' => 'SQLite3Database',
'title' => 'SQLite 3'
),
'sqlitepdo' => array(
'class' => 'SQLitePDODatabase',
'title' => 'SQLite PDO'
)
);
// MySQL support comes out of the box with sapphire - others databases
// live in their own module directories. We need to check the existance of them!
$foundDatabaseClasses = array('MySQLDatabase' => 'MySQL');
include_once('sapphire/dev/install/DatabaseConfigurationHelper.php');
include_once('sapphire/dev/install/MySQLDatabaseConfigurationHelper.php');
foreach($otherDatabaseLocations as $dir => $details) {
$helperPath = $dir . '/code/' . $details['class'] . 'ConfigurationHelper.php';
if(file_exists($helperPath)) {
$foundDatabaseClasses[$details['class']] = $details['title'];
include_once($helperPath);
}
}
// Load database config // Load database config
if(isset($_REQUEST['db'])) { if(isset($_REQUEST['db'])) {
// Disabled inputs don't submit anything - we need to use the environment (except the database name) // Disabled inputs don't submit anything - we need to use the environment (except the database name)
@ -146,25 +179,6 @@ if($installFromCli && ($req->hasErrors() || $dbReq->hasErrors())) {
exit(1); exit(1);
} }
// This is a mapping of module directory name to database class
$otherDatabaseLocations = array(
'mssql' => array(
'class' => 'MSSQLDatabase',
'title' => 'SQL Server 2008'
),
'postgresql' => array(
'class' => 'PostgreSQLDatabase',
'title' => 'PostgreSQL'
)
);
// MySQL support comes out of the box with sapphire - others databases
// live in their own module directories. We need to check the existance of them!
$foundDatabaseClasses = array('MySQLDatabase' => 'MySQL');
foreach($otherDatabaseLocations as $dir => $details) {
if(file_exists($dir)) $foundDatabaseClasses[$details['class']] = $details['title'];
}
if((isset($_REQUEST['go']) || $installFromCli) && !$req->hasErrors() && !$dbReq->hasErrors() && $adminConfig['username'] && $adminConfig['password']) { if((isset($_REQUEST['go']) || $installFromCli) && !$req->hasErrors() && !$dbReq->hasErrors() && $adminConfig['username'] && $adminConfig['password']) {
// Confirm before reinstalling // Confirm before reinstalling
if(!isset($_REQUEST['force_reinstall']) && !$installFromCli && $alreadyInstalled) { if(!isset($_REQUEST['force_reinstall']) && !$installFromCli && $alreadyInstalled) {
@ -194,13 +208,13 @@ if((isset($_REQUEST['go']) || $installFromCli) && !$req->hasErrors() && !$dbReq-
*/ */
class InstallRequirements { class InstallRequirements {
var $errors, $warnings, $tests, $dbConn; var $errors, $warnings, $tests;
/** /**
* Just check that the database configuration is okay * Just check that the database configuration is okay
*/ */
function checkdatabase($databaseConfig) { function checkdatabase($databaseConfig) {
if($this->requireDatabaseFunction( if($this->requireDatabaseFunctions(
$databaseConfig, $databaseConfig,
array( array(
"Database Configuration", "Database Configuration",
@ -585,122 +599,66 @@ class InstallRequirements {
} }
} }
function requireDatabaseFunction($databaseConfig, $testDetails) {
$this->testing($testDetails);
$okay = false;
if($databaseConfig['type'] == 'MySQLDatabase') {
if(function_exists('mysql_connect')) {
$okay = true;
}
} elseif($databaseConfig['type'] == 'MSSQLDatabase') {
if(function_exists('mssql_connect') || function_exists('sqlsrv_connect')) {
$okay = true;
}
} elseif($databaseConfig['type'] = 'PostgreSQLDatabase') {
if(function_exists('pg_connect')) {
$okay = true;
}
}
if(!$okay) {
$this->error($testDetails);
return false;
} else {
return true;
}
}
/** /**
* The established database connection is cached to $dbConn on the instance * Get an instance of a helper class for the specific database.
* of this class so various queries can be run via {@link requireDatabaseOrCreatePermissions()) * @param string $databaseClass e.g. MySQLDatabase or MSSQLDatabase
*/ */
function getDatabaseConfigurationHelper($databaseClass) {
$class = $databaseClass . 'ConfigurationHelper';
return new $class();
}
function requireDatabaseFunctions($databaseConfig, $testDetails) {
$this->testing($testDetails);
$helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']);
$result = $helper->requireDatabaseFunctions($databaseConfig);
if($result) {
return true;
} else {
return false;
}
}
function requireDatabaseConnection($databaseConfig, $testDetails) { function requireDatabaseConnection($databaseConfig, $testDetails) {
$this->testing($testDetails); $this->testing($testDetails);
$helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']);
if($databaseConfig['type'] == 'MySQLDatabase') { $result = $helper->requireDatabaseConnection($databaseConfig);
$this->dbConn = $conn = @mysql_connect($databaseConfig['server'], $databaseConfig['username'], $databaseConfig['password']); if($result['okay']) {
if($conn) { $result['connection'];
return true; return true;
} else { } else {
$testDetails[2] .= ": " . mysql_error(); $testDetails[2] .= ": " . $result['error'];
$this->error($testDetails); $this->error($testDetails);
} return false;
} elseif($databaseConfig['type'] == 'MSSQLDatabase') {
if(function_exists('mssql_connect')) {
$this->dbConn = $conn = @mssql_connect($databaseConfig['server'], $databaseConfig['username'], $databaseConfig['password'], true);
} else {
$connectionInfo = array(
'UID' => $databaseConfig['username'],
'PWD' => $databaseConfig['password'],
);
$this->dbConn = $conn = @sqlsrv_connect($databaseConfig['server'], $connectionInfo);
}
if($conn) {
return true;
} else {
$this->error($testDetails);
}
} elseif($databaseConfig['type'] == 'PostgreSQLDatabase') {
$username = $databaseConfig['username'] ? $databaseConfig['username'] : '';
$password = $databaseConfig['password'] ? $databaseConfig['password'] : '';
$server = $databaseConfig['server'];
$userPart = $username ? " user=$username" : '';
$passwordPart = $password ? " password=$password" : '';
$connstring = "host=$server port=5432 {$userPart}{$passwordPart}";
$this->dbConn = $conn = @pg_connect($connstring);
if($conn) {
return true;
} else {
$this->error($testDetails);
}
} }
} }
function requireDatabaseServer($databaseConfig, $testDetails) { function requireDatabaseServer($databaseConfig, $testDetails) {
$this->testing($testDetails); $this->testing($testDetails);
$helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']);
if($databaseConfig['type'] == 'MySQLDatabase') { $result = $helper->requireDatabaseServer($databaseConfig);
$conn = @mysql_connect($databaseConfig['server'], null, null); if($result['okay']) {
if($conn || mysql_errno() < 2000) {
return true; return true;
} else { } else {
$testDetails[2] .= ": " . mysql_error(); $testDetails[2] .= ": " . $result['error'];
$this->error($testDetails); $this->error($testDetails);
return false;
} }
} elseif($databaseConfig['type'] == 'MSSQLDatabase') {
if(function_exists('mssql_connect')) {
$conn = @mssql_connect($databaseConfig['server'], $databaseConfig['username'], $databaseConfig['password'], true);
} else {
$connectionInfo = array(
'UID' => $databaseConfig['username'],
'PWD' => $databaseConfig['password'],
);
$conn = @sqlsrv_connect($databaseConfig['server'], $connectionInfo);
} }
if($conn) { function requireDatabaseOrCreatePermissions($databaseConfig, $testDetails) {
$this->testing($testDetails);
$helper = $this->getDatabaseConfigurationHelper($databaseConfig['type']);
$result = $helper->requireDatabaseOrCreatePermissions($databaseConfig);
if($result['okay']) {
if($result['existsAlready']) $testDetails[3] = "Database $databaseConfig[database] exists";
else $testDetails[3] = "Able to create a new database";
$this->testing($testDetails);
return true; return true;
} else { } else {
$testDetails[2] .= ": SQL Server requires a valid username and password to determine if the server exists."; $testDetails[2] .= " (user '$databaseConfig[username]' doesn't have CREATE DATABASE permissions.)";
$this->error($testDetails); $this->error($testDetails);
} return false;
} elseif($databaseConfig['type'] == 'PostgreSQLDatabase') {
$username = $databaseConfig['username'] ? $databaseConfig['username'] : '';
$password = $databaseConfig['password'] ? $databaseConfig['password'] : '';
$server = $databaseConfig['server'];
$userPart = $username ? " user=$username" : '';
$passwordPart = $password ? " password=$password" : '';
$connstring = "host=$server port=5432 {$userPart}{$passwordPart}";
$conn = @pg_connect($connstring);
if($conn) {
return true;
} else {
$testDetails[2] .= ": PostgreSQL requires a valid username and password to determine if the server exists.";
$this->error($testDetails);
}
} }
} }
@ -726,60 +684,6 @@ class InstallRequirements {
} }
} }
function requireDatabaseOrCreatePermissions($databaseConfig, $testDetails) {
$this->testing($testDetails);
$okay = '';
if($databaseConfig['type'] == 'MySQLDatabase') {
$conn = @mysql_connect($databaseConfig['server'], $databaseConfig['username'], $databaseConfig['password']);
if(@mysql_select_db($databaseConfig['database'], $this->dbConn)) {
$okay = "Database '$databaseConfig[database]' exists";
} else {
if(@mysql_query("CREATE DATABASE testing123", $this->dbConn)) {
mysql_query("DROP DATABASE testing123", $this->dbConn);
$okay = "Able to create a new database";
}
}
} elseif($databaseConfig['type'] == 'MSSQLDatabase') {
if(@mysql_select_db($databaseConfig['database'])) {
$okay = "Database '$databaseConfig[database]' exists";
} else {
if(function_exists('mssql_connect') && @mssql_query("CREATE DATABASE testing123", $this->dbConn)) {
mssql_query($this->dbConn, "DROP DATABASE testing123");
$okay = "Able to create a new database";
} elseif(function_exists('sqlsrv_connect') && @sqlsrv_query($this->dbConn, "CREATE DATABASE testing123")) {
sqlsrv_query($this->dbConn, "DROP DATABASE testing123");
$okay = "Able to create a new database";
}
}
} elseif($databaseConfig['type'] == 'PostgreSQLDatabase') {
$database = $databaseConfig['database'];
$dbExists = false;
$result = pg_query($this->dbConn, "SELECT datname FROM pg_database WHERE datname = '$database'");
if(pg_fetch_array($result)) $dbExists = true;
if($dbExists) {
$okay = "Database '$database' exists";
} else {
if(@pg_query($this->dbConn, "CREATE DATABASE testing123")) {
pg_query($this->dbConn, "DROP DATABASE testing123");
$okay = "Able to create a new database";
}
}
}
if($okay) {
$testDetails[3] = $okay;
$this->testing($testDetails);
return true;
} else {
$testDetails[2] .= " (user '$databaseConfig[username]' doesn't have CREATE DATABASE permissions.)";
$this->error($testDetails);
return false;
}
}
function requireServerVariables($varNames, $errorMessage) { function requireServerVariables($varNames, $errorMessage) {
//$this->testing($testDetails); //$this->testing($testDetails);
foreach($varNames as $varName) { foreach($varNames as $varName) {