Commit Graph

42 Commits

Author SHA1 Message Date
Dylan Wagstaff
b6130c4e11 Add unit tests for new ManyManyThrough support
The previous commit (9fa9ef89) added support for the new SilverStripe 4
feature of Many Many relationships through an intermediary object. After
much head scratching and community testing, the solution was proven to
work, however had no automated tests to confirm as such. This commit
rectifies that by testing both versioned and unversioned DataObjects in
a many_many through style relationship. Some minor tidy and comments
were also added as per feedback on the functionality code changes.
2018-06-26 14:41:39 +12:00
Dylan Wagstaff
9fa9ef8903 NEW Add support for ManyManyThrough relations
Previously relationships defiend as many_many came in a special type
of RelationList - however now this can be one of two types of
RelationList depending on the type of definition, with both being
valid many_many relationships.

This had the unfortunate side effect of seeing the OrderableRows
component in (the least) cease functioning correctly. No longer.

This also has the fortunate bonus of allowing a many_many relationship to
be versioned; where previously while each item in the relationship could
be versioned, the relationship itself could not.
2018-06-01 16:23:00 +12:00
Mojmir Fendek
6b47b6d63a Corrected a case when sort column is located in a table that belongs to ancestor class of the item. 2018-04-27 10:00:34 +12:00
Michael Goldsmith
9009a83ae1 Revert back to previous version check to allow many many version objects to pass through the non-ORM method 2018-03-06 14:45:29 +13:00
Daniel Hensby
cbffc5b935
Merge branch '3' 2018-02-21 13:30:39 +00:00
Daniel Hensby
8c82965e7e
Merge branch '2' into 3 2018-02-21 13:28:13 +00:00
Daniel Hensby
0974e36d57
Merge branch '3.0' into 3.1 2018-02-21 11:49:19 +00:00
Daniel Hensby
51dd4cab65
Merge branch '2.0' into 3.0 2018-02-21 11:25:09 +00:00
Robbie Averill
b192551f30 Merge branch '3' 2018-02-12 11:13:37 +13:00
Priyashantha
6d8b41ee5a Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-02-12 11:08:47 +13:00
Priyashantha
d1021ace51 Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-01-30 20:40:59 +00:00
Daniel Hensby
509abf1532
Merge pull request #233 from silverstripe-terraformers/feature/SS4_upgrade_fixes 2018-01-26 16:34:31 +00:00
Daniel Hensby
64b6fd04f3
Merge pull request #238 from creative-commoners/pulls/3.1/fix-searchbutton
FIX Update GridFieldAddExistinSearchButton and dialog to use Bootstrap classes
2018-01-26 16:31:31 +00:00
Robbie Averill
24db0da047 Fix PSR-2 rule violations and incorrect docblock return type 2018-01-26 13:40:06 +13:00
Robbie Averill
0a16566471 FIX Convert broken add-existing-search-form styles to use Bootstrap lists and pagination 2018-01-26 11:53:40 +13:00
Robbie Averill
8ba5c3435e FIX Switch Add Existing from jQuery UI to use Bootstrap styles 2018-01-26 11:01:24 +13:00
Mojmir Fendek
735cc01270 SS4 upgrade fixes. 2018-01-12 12:00:20 +13:00
Dylan Wagstaff
a7c5283bdd Merge branch 'master' into pulls/3.0/fix-closure-import 2017-10-26 14:34:43 +13:00
Robbie Averill
efdf9dcc13 API Install GridFieldExtensions to vendor folder, remove get_module_dir 2017-10-11 09:34:02 +13:00
Robbie Averill
0ad1fc367e
MINOR Apply PSR-2 linting 2017-09-18 21:06:16 +01:00
Daniel Hensby
9e26e38d75
Merge branch '2' 2017-09-18 17:39:41 +01:00
Damian Mooyman
b7b3678b26
BUG Fix casting for ‘$Attributes’ 2017-09-15 17:03:20 +12:00
Robbie Averill
46b792b27f FIX Import Closure class for type checking, and only set sort if the sort field exists 2017-09-15 16:32:38 +12:00
Damian Mooyman
9421e85483 BUG Fix inline editing / sortable 2017-09-15 16:08:13 +12:00
Robbie Averill
58604a6234 FIX Remove references to Object, replace with Injector calls 2017-08-25 13:46:30 +12:00
Will Rossiter
aaf1130569 Inline fixes 2017-07-28 07:19:28 +12:00
Damian Mooyman
57acb83546
Sanitise GridFieldAddNewMultiClassHandler::Link() 2017-07-06 17:27:07 +12:00
Daniel Hensby
08ccb15bdb
Merge branch '1.4' 2017-07-05 17:45:20 +01:00
Marcus
87cd8ffc6d Merge pull request #194 from dnadesign/fix-multi-class-injector
fix to multi-class for ss4 support
2017-07-03 10:28:57 +10:00
John Milmine
7d3f5acbd7 fix to multi-class for ss4 support 2017-06-26 07:29:43 +12:00
Nathan Glasl
ef48ea9cdd NAMESPACE, updating vendor. 2017-06-16 14:46:31 +10:00
Marcus
1b0abe0ca6 Merge pull request #190 from sachithra-gayan/gridFieldEditableColumns_SS4
Fixes error when inline editing of records SS4
2017-06-06 13:08:30 +10:00
sac
658874419a deny inline editing of records SS4 2017-06-01 13:02:43 +05:30
Ed Linklater
90b1a466c1 FIX support table namespace separator introduced in ss4 alpha 6 2017-05-14 16:17:14 +12:00
Marcus
3f6036b1ae Merge pull request #185 from wilr/patch-1
Fix SearchForm throwing a 404 on search
2017-05-04 11:45:51 +10:00
Marcus
0795113cf4 fix(GridFieldAddNewMultiClass) removed obsolete config param
FIRST_SET has been removed from SS4
2017-05-04 11:41:58 +10:00
Will Rossiter
2c73b802d6 Fix SearchForm throwing a 404 on search
The GridFieldAddExistingSearchHandler search has been converted to namespaces however this causes the FormAction to be incorrect and when performing a search, currently throws an error. The form name does not need to be namespaced.
2017-05-04 05:29:44 +12:00
Jack O'Connor
0907b2f493 Initialising button before attempting to enable or disable it (#177)
* Initialising button before attempting to enable or disable it

* Updating class reference

* Adding exception use case

* Removing unused use case

* Including Exception class for classes where exception is used.
2017-02-17 13:14:50 +11:00
Lee Bradley
cbcb6e57e0 Applies changes from silverstripe-australia/silverstripe-gridfieldextensions#177
JS fix for "Initialising button before attempting to enable or disable it"
Thanks @JackOconnor21
2017-02-14 17:21:29 +00:00
Lee Bradley
1b5e83b7f6 Fix for Exception namespace & CSS image move
Missing '\\' before Exception
Icon has moved in Framework
2017-02-14 17:07:29 +00:00
Robbie Averill
2acf6dee47 PSR-2 code style guidelines 2016-12-21 15:35:19 +13:00
Robbie Averill
3cacb43934 Update composer constraint, branch alias, namespace and add editorconfig 2016-12-21 15:27:49 +13:00