Commit Graph

33 Commits

Author SHA1 Message Date
Chris Penny 23a5154c97
ENH: Update reorderItems() to use ORM where possible (#336)
* ENH: Update reorderItems() to use ORM where possible

* Increase test coverage of orderable rows
2022-08-04 10:51:40 +12:00
Steve Boyd 93e4379c3d ENH PHP 8.1 compatibility 2022-04-13 17:44:44 +12:00
David Toews 6d6cf4a225
ENH applies default sort order to CMS ordering (#325)
* (cms interface) applies default sort order to CMS ordering

This allows secondary sort ordering to be applied when it exists and when the objects have not been sorted manually

* (sort logic) adds additional checks for non DataList or unsorted cases

* Update src/GridFieldOrderableRows.php

Co-authored-by: Michal Kleiner <mk@011.nz>

Co-authored-by: Michal Kleiner <mk@011.nz>
2022-02-02 15:29:57 +13:00
Marcus 719c0ed547
Merge pull request #302 from lpostiglione/patch-1
Fix support for dot notation in GridFieldOrderableRows
2021-05-13 10:09:52 +10:00
Michal Kleiner 9944b67632 FIX GridFieldOrderableRows to support polymorphic ManyManyThroughList 2020-05-18 15:33:43 +12:00
Luca Postiglione 4d94b2748d
Added support for dot notation in GridField name
When you want to have a GridField for a sub-relation on a relation of your DataObject you use dot notation, this breaks the functionality of GridFieldOrderableRows because in the POST request the dot is replaced by an underscore.
2020-01-29 12:57:30 +01:00
Loz Calver 600a39e428 FIX: Remove unnecessary "version mismatch" restriction (fixes #282) 2019-04-05 09:37:41 +13:00
Robbie Averill b221134ce1 FIX Orderable rows now respects actual MMTL sort orders instead of incrementing from SiteTree 2018-09-28 17:38:38 +02:00
Robbie Averill 7fdfe234fd
Merge pull request #260 from creative-commoners/pulls/3.1/many-many-reordering-fix
NEW Add support for ManyManyThrough relations
2018-07-02 09:59:51 +12:00
Dylan Wagstaff b6130c4e11 Add unit tests for new ManyManyThrough support
The previous commit (9fa9ef89) added support for the new SilverStripe 4
feature of Many Many relationships through an intermediary object. After
much head scratching and community testing, the solution was proven to
work, however had no automated tests to confirm as such. This commit
rectifies that by testing both versioned and unversioned DataObjects in
a many_many through style relationship. Some minor tidy and comments
were also added as per feedback on the functionality code changes.
2018-06-26 14:41:39 +12:00
Dylan Wagstaff 9fa9ef8903 NEW Add support for ManyManyThrough relations
Previously relationships defiend as many_many came in a special type
of RelationList - however now this can be one of two types of
RelationList depending on the type of definition, with both being
valid many_many relationships.

This had the unfortunate side effect of seeing the OrderableRows
component in (the least) cease functioning correctly. No longer.

This also has the fortunate bonus of allowing a many_many relationship to
be versioned; where previously while each item in the relationship could
be versioned, the relationship itself could not.
2018-06-01 16:23:00 +12:00
Robbie Averill e898711add
Merge pull request #255 from n8-sd/feature/allow_onAfterReorderItems_sortedIDs
Allow onAfterreorderItems extra variables.
2018-05-11 15:33:18 +12:00
Mojmir Fendek 6b47b6d63a Corrected a case when sort column is located in a table that belongs to ancestor class of the item. 2018-04-27 10:00:34 +12:00
Nathan SD e15f1766bf Allow onAfterreorderItems extra variables. 2018-04-24 14:25:13 +12:00
Michael Goldsmith 9009a83ae1 Revert back to previous version check to allow many many version objects to pass through the non-ORM method 2018-03-06 14:45:29 +13:00
Daniel Hensby cbffc5b935
Merge branch '3' 2018-02-21 13:30:39 +00:00
Daniel Hensby 8c82965e7e
Merge branch '2' into 3 2018-02-21 13:28:13 +00:00
Daniel Hensby 0974e36d57
Merge branch '3.0' into 3.1 2018-02-21 11:49:19 +00:00
Daniel Hensby 51dd4cab65
Merge branch '2.0' into 3.0 2018-02-21 11:25:09 +00:00
Robbie Averill b192551f30 Merge branch '3' 2018-02-12 11:13:37 +13:00
Priyashantha 6d8b41ee5a Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-02-12 11:08:47 +13:00
Priyashantha d1021ace51 Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-01-30 20:40:59 +00:00
Daniel Hensby 509abf1532
Merge pull request #233 from silverstripe-terraformers/feature/SS4_upgrade_fixes 2018-01-26 16:34:31 +00:00
Robbie Averill 24db0da047 Fix PSR-2 rule violations and incorrect docblock return type 2018-01-26 13:40:06 +13:00
Mojmir Fendek 735cc01270 SS4 upgrade fixes. 2018-01-12 12:00:20 +13:00
Robbie Averill 0ad1fc367e
MINOR Apply PSR-2 linting 2017-09-18 21:06:16 +01:00
Daniel Hensby 08ccb15bdb
Merge branch '1.4' 2017-07-05 17:45:20 +01:00
Nathan Glasl ef48ea9cdd NAMESPACE, updating vendor. 2017-06-16 14:46:31 +10:00
Ed Linklater 90b1a466c1 FIX support table namespace separator introduced in ss4 alpha 6 2017-05-14 16:17:14 +12:00
Jack O'Connor 0907b2f493 Initialising button before attempting to enable or disable it (#177)
* Initialising button before attempting to enable or disable it

* Updating class reference

* Adding exception use case

* Removing unused use case

* Including Exception class for classes where exception is used.
2017-02-17 13:14:50 +11:00
Lee Bradley 1b5e83b7f6 Fix for Exception namespace & CSS image move
Missing '\\' before Exception
Icon has moved in Framework
2017-02-14 17:07:29 +00:00
Robbie Averill 2acf6dee47 PSR-2 code style guidelines 2016-12-21 15:35:19 +13:00
Robbie Averill 3cacb43934 Update composer constraint, branch alias, namespace and add editorconfig 2016-12-21 15:27:49 +13:00