Commit Graph

81 Commits

Author SHA1 Message Date
Guy Sartorelli d34c92dba7
Merge branch '3.6' into 3 2024-02-27 13:44:19 +13:00
Tom Oude Rengerink 78fa8ba747
ENH Make toast message "Records reordered." localisable (#321)
Co-authored-by: Tom Oude Rengerink <tom@cube.nl>
2024-01-24 11:41:14 +13:00
Guy Sartorelli 9c70b0175b
Merge branch '3.6' into 3 2023-08-30 10:18:58 +12:00
Guy Sartorelli 47171ee4c2
FIX Allow editing extra fields from ManyManyThroughList. 2023-08-21 09:02:42 +12:00
Sabina Talipova a2ea473369
MNT Replaced SearchContext::getQuery limit param with null (#367) 2023-07-05 17:20:56 +12:00
Guy Sartorelli bb6c0396f1
Merge branch '3.5' into 3.6 2023-04-06 10:40:35 +12:00
Steve Boyd 17f92d08ba FIX Handle arrays in default_sort 2023-04-06 10:30:12 +12:00
Maxime Rainville d5d438c5cc
Merge pull request #334 from josephlewisnz/feature/republish-live-records-3
Feature/republish live records 3
2022-11-18 15:38:05 +13:00
Steve Boyd aa6ac7a1a2 API Stop using deprecated API 2022-11-03 11:45:10 +13:00
Chris Penny 23a5154c97
ENH: Update reorderItems() to use ORM where possible (#336)
* ENH: Update reorderItems() to use ORM where possible

* Increase test coverage of orderable rows
2022-08-04 10:51:40 +12:00
bumbus f56bf67e40
FIX Fixes GridFieldEditableColumns::isChanged method for non-string values (e.g. arrays for has_many / many_many relations) (#343)
* fixes GridFieldEditableColumns::isChanged method for non-string values (e.g. arrays for has_many / many_many relations)

* revert formatting

Co-authored-by: Bumbus <sf@arillo.ch>
2022-08-01 13:22:09 +12:00
Mo Alsharaf 547ec8aa50 ENH: Add performance fixes on saving editable columns
- Use one query to fetch all items needed to be saved.
- Only save items that are changed.
2022-06-16 13:02:16 +12:00
Steve Boyd 93e4379c3d ENH PHP 8.1 compatibility 2022-04-13 17:44:44 +12:00
Guy Sartorelli ec93c994f8
NEW Extend new AbstractGridFieldComponent class (#332)
This makes this module's `GridFieldComponent` classes `Injectable`, and allows any future enhancements in the new abstract class to automatically apply without requiring additional changes in this module.

The class is introduced in silverstripe/framework 4.11.0 so the dependency constraint needs to be updated.

Also update docs to encourage use of dependency injection.
2022-03-04 10:12:24 +13:00
Guy Sartorelli 8c4e924bfa
ENH: Prefer dependency injection over use of `new` keyword. (#333)
* ENH: Prefer dependency injection over use of `new` keyword.

* MNT Fix phpcs linting error.
2022-02-18 16:44:54 +13:00
josephlewisnz 2928504b3c removed param 2022-02-18 08:39:59 +13:00
josephlewisnz 8e77095de0 updated to create syntax 2022-02-17 13:10:44 +13:00
josephlewisnz 07c97e45b2 Added the ability to autopublish items that are already live 2022-02-17 12:53:13 +13:00
David Toews 6d6cf4a225
ENH applies default sort order to CMS ordering (#325)
* (cms interface) applies default sort order to CMS ordering

This allows secondary sort ordering to be applied when it exists and when the objects have not been sorted manually

* (sort logic) adds additional checks for non DataList or unsorted cases

* Update src/GridFieldOrderableRows.php

Co-authored-by: Michal Kleiner <mk@011.nz>

Co-authored-by: Michal Kleiner <mk@011.nz>
2022-02-02 15:29:57 +13:00
Marcus 7738a0b89b
Merge pull request #319 from ntd/inline-row-with-defaults
FIX: use default values in new inline rows (#64)
2021-05-13 10:11:36 +10:00
Marcus 719c0ed547
Merge pull request #302 from lpostiglione/patch-1
Fix support for dot notation in GridFieldOrderableRows
2021-05-13 10:09:52 +10:00
Nicola Fontana 3d4986432c FIX: use default values in new inline rows (#64) 2021-03-24 20:32:02 +01:00
Steve Boyd 74126ed6a7 Merge branch '3.2' into 3 2021-03-20 14:14:24 +13:00
Sam Minnee 229a23a2f4 FIX: Transfrom editable columns to readonly on a readonly gridfield also. 2020-09-08 14:57:59 +12:00
Sam Minnee 08f89ea4b5 FIX: Fixed handling of uneditable records in GridFieldEditableColumns
Fixes #312
2020-08-07 12:30:21 +12:00
Garion Herman 4105d6330f FIX Reinstate previous field fetch logic as fallback
Fixes some cases where a field is not retrievable via dataFieldByName()
2020-07-30 10:54:53 +12:00
Marcus 2fc085bbd0
Merge pull request #294 from sminnee/allow-inline-dot-syntax
FIX: Let GridFieldEditableColumns edit relations via dot syntax
2020-06-17 16:42:26 +10:00
Michal Kleiner 9944b67632 FIX GridFieldOrderableRows to support polymorphic ManyManyThroughList 2020-05-18 15:33:43 +12:00
Luca Postiglione 4d94b2748d
Added support for dot notation in GridField name
When you want to have a GridField for a sub-relation on a relation of your DataObject you use dot notation, this breaks the functionality of GridFieldOrderableRows because in the POST request the dot is replaced by an underscore.
2020-01-29 12:57:30 +01:00
Lee Bradley 4afe5dcfd3 Tweaks to pass tests 2019-12-12 16:18:09 +00:00
Lee Bradley 04c42273cf Add Multi Class to inline add button
Raised in Issue #300
2019-12-12 16:10:11 +00:00
Sam Minnee 0b37e97b42 FIX: Fix insertion of new records in many-many-through list.
This change is specially important when using dot-syntax fieldnames to
access the join record of a many-many-through.
2019-08-26 18:11:36 +12:00
Sam Minnee d357479421 FIX: Let GridFieldEditableColumns edit relations via dot syntax
This is a companion to https://github.com/silverstripe/silverstripe-framework/pull/9192 to provide the same functionality for inline
editing in GridFields

A valuable use of this is editing fields in the join-object of
a many-many-through relation.
2019-08-26 12:37:19 +12:00
Loz Calver 600a39e428 FIX: Remove unnecessary "version mismatch" restriction (fixes #282) 2019-04-05 09:37:41 +13:00
Ivo Bathke 088e7f16a8 FIX Fixed unload modal in GridFieldConfigurablePaginator 2019-03-01 15:39:26 +13:00
Robbie Averill b221134ce1 FIX Orderable rows now respects actual MMTL sort orders instead of incrementing from SiteTree 2018-09-28 17:38:38 +02:00
Robbie Averill 7fdfe234fd
Merge pull request #260 from creative-commoners/pulls/3.1/many-many-reordering-fix
NEW Add support for ManyManyThrough relations
2018-07-02 09:59:51 +12:00
Dylan Wagstaff b6130c4e11 Add unit tests for new ManyManyThrough support
The previous commit (9fa9ef89) added support for the new SilverStripe 4
feature of Many Many relationships through an intermediary object. After
much head scratching and community testing, the solution was proven to
work, however had no automated tests to confirm as such. This commit
rectifies that by testing both versioned and unversioned DataObjects in
a many_many through style relationship. Some minor tidy and comments
were also added as per feedback on the functionality code changes.
2018-06-26 14:41:39 +12:00
Dylan Wagstaff 9fa9ef8903 NEW Add support for ManyManyThrough relations
Previously relationships defiend as many_many came in a special type
of RelationList - however now this can be one of two types of
RelationList depending on the type of definition, with both being
valid many_many relationships.

This had the unfortunate side effect of seeing the OrderableRows
component in (the least) cease functioning correctly. No longer.

This also has the fortunate bonus of allowing a many_many relationship to
be versioned; where previously while each item in the relationship could
be versioned, the relationship itself could not.
2018-06-01 16:23:00 +12:00
Robbie Averill e898711add
Merge pull request #255 from n8-sd/feature/allow_onAfterReorderItems_sortedIDs
Allow onAfterreorderItems extra variables.
2018-05-11 15:33:18 +12:00
Mojmir Fendek 6b47b6d63a Corrected a case when sort column is located in a table that belongs to ancestor class of the item. 2018-04-27 10:00:34 +12:00
Nathan SD e15f1766bf Allow onAfterreorderItems extra variables. 2018-04-24 14:25:13 +12:00
Michael Goldsmith 9009a83ae1 Revert back to previous version check to allow many many version objects to pass through the non-ORM method 2018-03-06 14:45:29 +13:00
Daniel Hensby cbffc5b935
Merge branch '3' 2018-02-21 13:30:39 +00:00
Daniel Hensby 8c82965e7e
Merge branch '2' into 3 2018-02-21 13:28:13 +00:00
Daniel Hensby 0974e36d57
Merge branch '3.0' into 3.1 2018-02-21 11:49:19 +00:00
Daniel Hensby 51dd4cab65
Merge branch '2.0' into 3.0 2018-02-21 11:25:09 +00:00
Robbie Averill b192551f30 Merge branch '3' 2018-02-12 11:13:37 +13:00
Priyashantha 6d8b41ee5a Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-02-12 11:08:47 +13:00
Priyashantha d1021ace51 Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many (#243)
* Fixed GridFieldOrderableRows issue when data class is Versioned and relation is has_many

* just compare table names rather than updating existing getSortTable() func
2018-01-30 20:40:59 +00:00