From 4105d6330fad9e1d2d73ed16d6e7860a347f25e2 Mon Sep 17 00:00:00 2001 From: Garion Herman Date: Thu, 30 Jul 2020 10:54:53 +1200 Subject: [PATCH] FIX Reinstate previous field fetch logic as fallback Fixes some cases where a field is not retrievable via dataFieldByName() --- src/GridFieldEditableColumns.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/GridFieldEditableColumns.php b/src/GridFieldEditableColumns.php index 55fa648..7dc89cf 100644 --- a/src/GridFieldEditableColumns.php +++ b/src/GridFieldEditableColumns.php @@ -84,6 +84,12 @@ class GridFieldEditableColumns extends GridFieldDataColumns implements $value = $grid->getDataFieldValue($record, $col); $field = $fields->dataFieldByName($col); + // Fall back to previous logic + if (!$field) { + $rel = (strpos($col, '.') === false); // field references a relation value + $field = ($rel) ? clone $fields->fieldByName($col) : new ReadonlyField($col); + } + if (!$field) { throw new Exception("Could not find the field '$col'"); }