tonyair
/
silverstripe-gridfieldextensions
mirror of https://github.com/symbiote/silverstripe-gridfieldextensions.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #207 from creative-commoners/pulls/1.5/reset-page-size 

FIX When setting the page sizes, reset items per page to the first value
This commit is contained in:
Franco Springveldt 2017-08-31 14:43:19 +12:00 committed by GitHub
parent e14ed0b47a 320a6198e5
commit bb4bb62be3
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/GridFieldConfigurablePaginator.php
View File

@ -159,6 +159,10 @@ class GridFieldConfigurablePaginator extends GridFieldPaginator
public function setPageSizes(array $pageSizes)
{
$this->pageSizes = $pageSizes;
// Reset items per page
$this->setItemsPerPage(current($pageSizes));
return $this;
}

14
tests/GridFieldConfigurablePaginatorTest.php
View File

@ -80,6 +80,20 @@ class GridFieldConfigurablePaginatorTest extends SapphireTest
$this->assertSame(3, $paginator->getTotalPages());
}
public function testItemsPerPageIsSetToFirstInPageSizesListWhenChanged()
{
$paginator = new GridFieldConfigurablePaginator(20, array(20, 40, 60));
$paginator->setGridField($this->gridField);
// Initial state, should be what was provided to the constructor
$this->assertSame(20, $paginator->getItemsPerPage());
$paginator->setPageSizes(array(50, 100, 200));
// Set via public API, should now be set to 50
$this->assertSame(50, $paginator->getItemsPerPage());
}
public function testGetCurrentPreviousAndNextPages()
{
$paginator = new GridFieldConfigurablePaginator(20, array(20, 40, 60));