tonyair/silverstripe-gridfieldextensions
1
0
Fork 0
mirror of https://github.com/symbiote/silverstripe-gridfieldextensions.git synced 2024-10-22 15:05:39 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #283 from kinglozzer/many-many-through-the-fire-and-flames

Browse Source 
FIX: Remove unnecessary "version mismatch" restriction (fixes #282)
This commit is contained in:
Robbie Averill 2019-04-05 09:44:32 +13:00 committed by GitHub
commit 6a26d76c6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/GridFieldOrderableRows.php
View File

@ -588,25 +588,11 @@ class GridFieldOrderableRows extends RequestHandler implements
// Model has sort column and is versioned - handle as versioned // Model has sort column and is versioned - handle as versioned
// Model has sort column and is NOT versioned - handle as NOT versioned // Model has sort column and is NOT versioned - handle as NOT versioned
// Model doesn't have sort column because sort column is on ManyManyList - handle as NOT versioned // Model doesn't have sort column because sort column is on ManyManyList - handle as NOT versioned
// Model doesn't have sort column because sort column is on ManyManyThroughList... // Model doesn't have sort column because sort column is on ManyManyThroughList - inspect through object
// - Related item is not versioned:
// - Through object is versioned: THROW an error.
// - Through object is NOT versioned: handle as NOT versioned
// - Related item is versioned...
// - Through object is versioned: handle as versioned
// - Through object is NOT versioned: THROW an error.
if ($list instanceof ManyManyThroughList) { if ($list instanceof ManyManyThroughList) {
$listClassVersioned = $class::create()->hasExtension(Versioned::class);
// We'll be updating the join class, not the relation class. // We'll be updating the join class, not the relation class.
$class = $this->getManyManyInspector($list)->getJoinClass(); $class = $this->getManyManyInspector($list)->getJoinClass();
$isVersioned = $class::create()->hasExtension(Versioned::class); $isVersioned = $class::create()->hasExtension(Versioned::class);
// If one side of the relationship is versioned and the other is not, throw an error.
if ($listClassVersioned xor $isVersioned) {
throw new Exception(
'ManyManyThrough cannot mismatch Versioning between join class and related class'
);
}
} elseif (!$this->isManyMany($list)) { } elseif (!$this->isManyMany($list)) {
$isVersioned = $class::create()->hasExtension(Versioned::class); $isVersioned = $class::create()->hasExtension(Versioned::class);
} }