From 5af8f1086923a606c138503f503fffcfe0e3f6c8 Mon Sep 17 00:00:00 2001 From: John Milmine Date: Thu, 29 Jan 2015 16:18:24 +1300 Subject: [PATCH] refactored to make code cleaner --- code/GridFieldOrderableRows.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/code/GridFieldOrderableRows.php b/code/GridFieldOrderableRows.php index d996152..5923cd5 100755 --- a/code/GridFieldOrderableRows.php +++ b/code/GridFieldOrderableRows.php @@ -138,14 +138,15 @@ class GridFieldOrderableRows extends RequestHandler implements * Handles requests to reorder a set of IDs in a specific order. */ public function handleReorder($grid, $request) { - if (is_a($grid->getList(), 'ManyManyList') && !singleton($grid->getModelClass())->canView()) { + $list = $grid->getList(); + $modelClass = $grid->getModelClass(); + if ($list instanceof ManyManyList && !singleton($modelClass)->canView()) { $this->httpError(403); - } else if(!is_a($grid->getList(), 'ManyManyList') && !singleton($grid->getModelClass())->canEdit()) { + } else if(!($list instanceof ManyManyList) && !singleton($modelClass)->canEdit()) { $this->httpError(403); } $ids = $request->postVar('order'); - $list = $grid->getList(); $field = $this->getSortField(); if(!is_array($ids)) {