tonyair/silverstripe-googlesitemaps
1
0
Fork 0
mirror of https://github.com/wilr/silverstripe-googlesitemaps.git synced 2024-10-22 11:05:48 +02:00
Code Issues Projects Releases Wiki Activity

If invokeWithExtensions returns an empty array, don't override

Browse Source
This commit is contained in:
Will Rossiter 2019-04-30 15:45:39 +12:00
parent 710b8c3518
commit 2860c390b0
No known key found for this signature in database
GPG Key ID: F24330E3B4B95B75
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Extensions/GoogleSitemapExtension.php
View File

@ -58,7 +58,9 @@ class GoogleSitemapExtension extends DataExtension
if ($override !== null) { if ($override !== null) {
if (is_array($override)) { if (is_array($override)) {
if (!empty($override)) {
$can = min($override, $can); $can = min($override, $can);
}
} else { } else {
$can = $override; $can = $override;
} }

1
tests/GoogleSitemapTest.php
View File

@ -60,6 +60,7 @@ class GoogleSitemapTest extends FunctionalTest
$this->assertFalse($unused->canIncludeInGoogleSitemap()); $this->assertFalse($unused->canIncludeInGoogleSitemap());
$used = $this->objFromFixture(TestDataObject::class, 'DataObjectTest2'); $used = $this->objFromFixture(TestDataObject::class, 'DataObjectTest2');
$this->assertTrue($used->canIncludeInGoogleSitemap()); $this->assertTrue($used->canIncludeInGoogleSitemap());
} }