From 2ee17c33a3868628394cc4e2d986565acafb0d5e Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Tue, 30 Nov 2021 13:55:38 +1300 Subject: [PATCH 1/2] MNT Remove obsolete branch-alias --- composer.json | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/composer.json b/composer.json index 75183dc..7876b6e 100644 --- a/composer.json +++ b/composer.json @@ -26,7 +26,7 @@ "monolog/monolog": "~1.15", "ptcinc/solr-php-client": "^1.0", "symfony/process": "^3.2", - "tractorcow/silverstripe-proxy-db" : "~0.1" + "tractorcow/silverstripe-proxy-db": "~0.1" }, "require-dev": { "silverstripe/cms": "^4.0", @@ -42,11 +42,7 @@ "bin": [ "bin/fulltextsearch_quickstart" ], - "extra": { - "branch-alias": { - "3.x-dev": "3.7.x-dev" - } - }, + "extra": [], "scripts": { "lint": "phpcs -s src/ tests/", "lint-clean": "phpcbf src/ tests/" @@ -57,4 +53,4 @@ }, "minimum-stability": "dev", "prefer-stable": true -} +} \ No newline at end of file From 34e0594e48f8f5c140e3b41544d39c8f88184114 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Wed, 8 Dec 2021 15:24:29 +1300 Subject: [PATCH 2/2] DEP Allow symfony 4 --- composer.json | 2 +- .../Handlers/SolrReindexImmediateHandler.php | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/composer.json b/composer.json index 7876b6e..b30882f 100644 --- a/composer.json +++ b/composer.json @@ -25,7 +25,7 @@ "silverstripe/framework": "^4.10", "monolog/monolog": "~1.15", "ptcinc/solr-php-client": "^1.0", - "symfony/process": "^3.2", + "symfony/process": "^3.2 || ^4", "tractorcow/silverstripe-proxy-db": "~0.1" }, "require-dev": { diff --git a/src/Solr/Reindex/Handlers/SolrReindexImmediateHandler.php b/src/Solr/Reindex/Handlers/SolrReindexImmediateHandler.php index 8bd2520..ca610cd 100644 --- a/src/Solr/Reindex/Handlers/SolrReindexImmediateHandler.php +++ b/src/Solr/Reindex/Handlers/SolrReindexImmediateHandler.php @@ -95,9 +95,16 @@ class SolrReindexImmediateHandler extends SolrReindexBase $scriptPath = sprintf("%s%scli-script.php", $frameworkPath, DIRECTORY_SEPARATOR); $scriptTask = "{$php} {$scriptPath} dev/tasks/{$taskName}"; - $cmd = "{$scriptTask} index={$indexClassEscaped} class={$class} group={$group} groups={$groups} variantstate={$statevar}"; - $cmd .= " verbose=1"; - $logger->info("Running '$cmd'"); + $cmd = [ + $scriptTask, + "index={$indexClassEscaped}", + "class={$class}", + "group={$group}", + "groups={$groups}", + "variantstate={$statevar}", + "verbose=1" + ]; + $logger->info('Running ' . implode(' ', $cmd)); // Execute script via shell $process = new Process($cmd);