tonyair/silverstripe-frameworktest
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-frameworktest synced 2024-10-22 11:06:02 +02:00
Code Issues Projects Releases Wiki Activity

Require silverstripe/registry

Browse Source 
Those class_exists() check don't work with class manifests.
Check the logic in ClassManifestVisitor - it just parses PHP until it finds
class definitions. Which means you'll have those files in the manifest,
but when dev/build tries to instantiate them it fails
with an InjectorNotFoundException.

We could argue that this should be fixed in core,
but I'm not sure that this style of conditional classes
needs to be supported.
This commit is contained in:
Ingo Schommer 2020-08-13 20:48:30 +12:00
parent dc3f096e20
commit 82a660dadc
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
composer.json
View File

@ -16,7 +16,8 @@
"silverstripe/cms": "~4.0",
"guzzlehttp/guzzle": "~6.0",
"fzaninotto/faker": "^1.7",
"silverstripe/vendor-plugin": "^1.0"
"silverstripe/vendor-plugin": "^1.0",
"silverstripe/registry": "~2"
},
"extra": {
"expose": [