mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 12:05:37 +00:00
0e40b779c9
Doesn't have much effect in practice, because charset and collation are already hardcoded on an ALTER TABLE level (field definitions), which take priority. Since most MySQL installs will still default to a latin1 encoding, this propagates to the table though, confusing devs and in some cases causing wrong data. Example: A MSSQL->MySQL DB migration tool used the table metadata to determine the charset, creating encoding issues. In terms of hardcoding, we don't really support anything other than UTF8, and the field-level settings are already hardcoded. We should probably remove the field-specific settings and rely on the DB defaults, but that's a sensitive API change (need to set on existing DBs during upgrade).