tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
d747334737
silverstripe-framework/tests
History
Sean Harvey 95bb799e6f BUG Fixing SQLQuery::aggregate() adding ORDER BY when no limit. 
DataQuery::initialiseQuery() will add a default sort to a query,
and when calling up an aggregate it will make a query like this
which doesn't make sense:

SELECT MAX("LastEdited") FROM "Member" ORDER BY "ID"

In this case there is no need to add the ORDER BY, and it will
break databases like MSSQL in cases such as
GenericTemplateGlobalProvider
which provides a default List() function for adding aggregates
into SSViewer template cacheblocks.

If we add a limit, however, then it does make sense:

SELECT MAX("LastEdited") FROM "Member" ORDER BY "ID" LIMIT 10

This fixes SQLQuery::aggregate() to NOT add an ORDER BY to an
aggregate call if there is no limit.
2013-09-06 18:11:11 +12:00
..
api Adding test to prove issue with HTTP Header parsing in RestfulService 2013-07-10 12:47:13 +01:00
assets FIX extra_requirements to accept non associative arrays. 2013-06-02 13:37:34 +12:00
behat Fixed 3.1-specific switchToWindow() behat feature 2013-08-22 14:10:54 +02:00
cache Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
control Merge remote-tracking branch 'origin/3.0' into 3.1.0 2013-08-22 12:55:47 +02:00
core Merge remote-tracking branch 'origin/3.1.0' into 3.1 2013-08-22 13:00:25 +02:00
dev FIX: If CSV column mapping maps to function, keep key value as key. 2013-05-14 22:00:52 +12:00
filesystem Updating FileTest to use the correct shortcode format with commas 2013-06-01 11:25:10 +12:00
forms Correct line length and indentation 2013-08-21 18:54:05 +12:00
i18n Merge remote-tracking branch 'origin/3.0' into 3.1 2013-08-07 17:14:47 +02:00
injector Remove duplicate parse_class_spec method. 2013-05-05 11:43:56 +12:00
integration FIX We still need XML escaping on href attributes in HTML4Value 2013-04-18 09:13:24 +12:00
javascript Add codesniffer that ensures indentation is with tabs. 2012-12-12 17:33:31 +13:00
model BUG Fixing SQLQuery::aggregate() adding ORDER BY when no limit. 2013-09-06 18:11:11 +12:00
oembed FIX Remove instances of lines longer than 120c 2012-09-30 17:18:13 +13:00
parsers Correct line length and indentation 2013-08-21 18:54:05 +12:00
phpcs Add code-sniffs other than line length to scrutinizer 2013-05-23 10:39:01 +12:00
search Coding conventions, PHPDoc cleanup 2013-06-15 12:06:24 +12:00
security Member.lock_out_delay_mins configurable, password security docs 2013-07-11 09:47:28 +02:00
tasks Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
templates FEATURE: <% include %> inherits iterator scope of parent template 2013-07-07 12:39:42 +00:00
testing API Marked statics private, use Config API instead (#8317) 2013-03-24 17:20:53 +01:00
view FEATURE: <% include %> inherits iterator scope of parent template 2013-07-07 12:39:42 +00:00
Bare.yml MINOR: Added small fixture YML that just lets you log in, for bootstrapping browser automation tests. 2011-02-02 14:17:57 +13:00
bootstrap.php Setting SapphireTest::is_running_test() in PHPUnit bootstrap 2013-01-09 23:31:10 +01:00
FakeController.php FIX Remove instances of lines longer than 120c 2012-09-30 17:18:13 +13:00
MemoryLimitTest.php Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
phpcs_runner.php Only have Scrutinizer check PHP files 2013-08-21 21:02:12 +12:00
PhpSyntaxTest.php FIX Remove instances of lines longer than 120c 2012-09-30 17:18:13 +13:00