mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-07-06 11:29:27 +02:00
cd8904e045
When you want to add a button to the CMS but don't want LeftAndMain to apply jQuery UI button to it we add the `data-button="true"` attribute to our button.
The `onadd` function checks that this attribute does not exist before calling `this.button()`.
The `onremove` incorrectly checks that this attribute does exist before calling `this.button('destroy')`. This should be checking that this attribute does not exist, just like the `onadd` function.
What this causes is when you have a button with the `data-button` attribute a button is not created, but when you leave the page `destory` gets called on an item which doesn't exist. We end up with the following error:
> Uncaught Error: cannot call methods on button prior to initialization; attempted to call method 'destroy'
The other issue with this logic is buttons are never getting destroyed when `onremove` is called.
The whole issue is caused by a missing `!` in the if statement. This change adds it in to fix the problem.
|
||
|---|---|---|
| .. | ||
| jquery-changetracker | ||
| jquery-fitheighttoparent | ||
| lang | ||
| CMSSecurity.js | ||
| leaktools.js | ||
| LeftAndMain.ActionTabSet.js | ||
| LeftAndMain.BatchActions.js | ||
| LeftAndMain.Content.js | ||
| LeftAndMain.EditForm.js | ||
| LeftAndMain.FieldDescriptionToggle.js | ||
| LeftAndMain.FieldHelp.js | ||
| LeftAndMain.js | ||
| LeftAndMain.Layout.js | ||
| LeftAndMain.Menu.js | ||
| LeftAndMain.Panel.js | ||
| LeftAndMain.Ping.js | ||
| LeftAndMain.Preview.js | ||
| LeftAndMain.Tree.js | ||
| LeftAndMain.TreeDropdownField.js | ||
| lib.js | ||
| MemberDatetimeOptionsetField.js | ||
| MemberImportForm.js | ||
| ModelAdmin.js | ||
| SecurityAdmin.js | ||
| ssui.core.js | ||