mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-08-26 20:45:47 +02:00
API: Deprecate SS_Datetime. The DBField subclasses are have all been renamed to start with “DB” and be in the SilverStripe\Model\FieldType namespace. To keep DataObject definitions concise, the original short variations of their names are preserved as service definitions. Most of the field generation code doesn’t need to change, but where field classes are referenced directly, changes will be needed. SS_Datetime, which is commonly referenced outside the model system itself, has been preserved as a subclass of DBDatetime. This has been marked as deprecated and can be removed in SilverStripe 5. A few places that referred to $db and $casting values weren’t using the Injector to instantiate the relevant classes. This meant that the remapping we have created as part of moving classes into a namespace didn’t work.
235 lines
7.2 KiB
PHP
235 lines
7.2 KiB
PHP
<?php
|
|
|
|
use SilverStripe\Model\FieldType\DBClassName;
|
|
|
|
class DataObjectSchemaGenerationTest extends SapphireTest {
|
|
protected $extraDataObjects = array(
|
|
'DataObjectSchemaGenerationTest_DO',
|
|
'DataObjectSchemaGenerationTest_IndexDO'
|
|
);
|
|
|
|
public function setUpOnce() {
|
|
|
|
// enable fulltext option on this table
|
|
Config::inst()->update('DataObjectSchemaGenerationTest_IndexDO', 'create_table_options',
|
|
array(MySQLSchemaManager::ID => 'ENGINE=MyISAM'));
|
|
|
|
parent::setUpOnce();
|
|
}
|
|
|
|
/**
|
|
* Check that once a schema has been generated, then it doesn't need any more updating
|
|
*/
|
|
public function testFieldsDontRerequestChanges() {
|
|
$schema = DB::get_schema();
|
|
$test = $this;
|
|
DB::quiet();
|
|
|
|
// Table will have been initially created by the $extraDataObjects setting
|
|
|
|
// Verify that it doesn't need to be recreated
|
|
$schema->schemaUpdate(function() use ($test, $schema) {
|
|
$obj = new DataObjectSchemaGenerationTest_DO();
|
|
$obj->requireTable();
|
|
$needsUpdating = $schema->doesSchemaNeedUpdating();
|
|
$schema->cancelSchemaUpdate();
|
|
$test->assertFalse($needsUpdating);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Check that updates to a class fields are reflected in the database
|
|
*/
|
|
public function testFieldsRequestChanges() {
|
|
$schema = DB::get_schema();
|
|
$test = $this;
|
|
DB::quiet();
|
|
|
|
// Table will have been initially created by the $extraDataObjects setting
|
|
|
|
// Let's insert a new field here
|
|
Config::inst()->update('DataObjectSchemaGenerationTest_DO', 'db', array(
|
|
'SecretField' => 'Varchar(100)'
|
|
));
|
|
|
|
// Verify that the above extra field triggered a schema update
|
|
$schema->schemaUpdate(function() use ($test, $schema) {
|
|
$obj = new DataObjectSchemaGenerationTest_DO();
|
|
$obj->requireTable();
|
|
$needsUpdating = $schema->doesSchemaNeedUpdating();
|
|
$schema->cancelSchemaUpdate();
|
|
$test->assertTrue($needsUpdating);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Check that indexes on a newly generated class do not subsequently request modification
|
|
*/
|
|
public function testIndexesDontRerequestChanges() {
|
|
$schema = DB::get_schema();
|
|
$test = $this;
|
|
DB::quiet();
|
|
|
|
// Table will have been initially created by the $extraDataObjects setting
|
|
|
|
// Verify that it doesn't need to be recreated
|
|
$schema->schemaUpdate(function() use ($test, $schema) {
|
|
$obj = new DataObjectSchemaGenerationTest_IndexDO();
|
|
$obj->requireTable();
|
|
$needsUpdating = $schema->doesSchemaNeedUpdating();
|
|
$schema->cancelSchemaUpdate();
|
|
$test->assertFalse($needsUpdating);
|
|
});
|
|
|
|
// Test with alternate index format, although these indexes are the same
|
|
Config::inst()->remove('DataObjectSchemaGenerationTest_IndexDO', 'indexes');
|
|
Config::inst()->update('DataObjectSchemaGenerationTest_IndexDO', 'indexes',
|
|
Config::inst()->get('DataObjectSchemaGenerationTest_IndexDO', 'indexes_alt')
|
|
);
|
|
|
|
// Verify that it still doesn't need to be recreated
|
|
$schema->schemaUpdate(function() use ($test, $schema) {
|
|
$obj2 = new DataObjectSchemaGenerationTest_IndexDO();
|
|
$obj2->requireTable();
|
|
$needsUpdating = $schema->doesSchemaNeedUpdating();
|
|
$schema->cancelSchemaUpdate();
|
|
$test->assertFalse($needsUpdating);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Check that updates to a dataobject's indexes are reflected in DDL
|
|
*/
|
|
public function testIndexesRerequestChanges() {
|
|
$schema = DB::get_schema();
|
|
$test = $this;
|
|
DB::quiet();
|
|
|
|
// Table will have been initially created by the $extraDataObjects setting
|
|
|
|
// Update the SearchFields index here
|
|
Config::inst()->update('DataObjectSchemaGenerationTest_IndexDO', 'indexes', array(
|
|
'SearchFields' => array(
|
|
'value' => 'Title'
|
|
)
|
|
));
|
|
|
|
// Verify that the above index change triggered a schema update
|
|
$schema->schemaUpdate(function() use ($test, $schema) {
|
|
$obj = new DataObjectSchemaGenerationTest_IndexDO();
|
|
$obj->requireTable();
|
|
$needsUpdating = $schema->doesSchemaNeedUpdating();
|
|
$schema->cancelSchemaUpdate();
|
|
$test->assertTrue($needsUpdating);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Tests the generation of the ClassName spec and ensure it's not unnecessarily influenced
|
|
* by the order of classnames of existing records
|
|
*/
|
|
public function testClassNameSpecGeneration() {
|
|
|
|
// Test with blank entries
|
|
DBClassName::clear_classname_cache();
|
|
$do1 = new DataObjectSchemaGenerationTest_DO();
|
|
$fields = DataObject::database_fields('DataObjectSchemaGenerationTest_DO');
|
|
$this->assertEquals("DBClassName", $fields['ClassName']);
|
|
$this->assertEquals(
|
|
array(
|
|
'DataObjectSchemaGenerationTest_DO' => 'DataObjectSchemaGenerationTest_DO',
|
|
'DataObjectSchemaGenerationTest_IndexDO' => 'DataObjectSchemaGenerationTest_IndexDO'
|
|
),
|
|
$do1->dbObject('ClassName')->getEnum()
|
|
);
|
|
|
|
|
|
// Test with instance of subclass
|
|
$item1 = new DataObjectSchemaGenerationTest_IndexDO();
|
|
$item1->write();
|
|
DBClassName::clear_classname_cache();
|
|
$fields = DataObject::database_fields('DataObjectSchemaGenerationTest_DO');
|
|
$this->assertEquals("DBClassName", $fields['ClassName']);
|
|
$this->assertEquals(
|
|
array(
|
|
'DataObjectSchemaGenerationTest_DO' => 'DataObjectSchemaGenerationTest_DO',
|
|
'DataObjectSchemaGenerationTest_IndexDO' => 'DataObjectSchemaGenerationTest_IndexDO'
|
|
),
|
|
$item1->dbObject('ClassName')->getEnum()
|
|
);
|
|
$item1->delete();
|
|
|
|
// Test with instance of main class
|
|
$item2 = new DataObjectSchemaGenerationTest_DO();
|
|
$item2->write();
|
|
DBClassName::clear_classname_cache();
|
|
$fields = DataObject::database_fields('DataObjectSchemaGenerationTest_DO');
|
|
$this->assertEquals("DBClassName", $fields['ClassName']);
|
|
$this->assertEquals(
|
|
array(
|
|
'DataObjectSchemaGenerationTest_DO' => 'DataObjectSchemaGenerationTest_DO',
|
|
'DataObjectSchemaGenerationTest_IndexDO' => 'DataObjectSchemaGenerationTest_IndexDO'
|
|
),
|
|
$item2->dbObject('ClassName')->getEnum()
|
|
);
|
|
$item2->delete();
|
|
|
|
// Test with instances of both classes
|
|
$item1 = new DataObjectSchemaGenerationTest_IndexDO();
|
|
$item1->write();
|
|
$item2 = new DataObjectSchemaGenerationTest_DO();
|
|
$item2->write();
|
|
DBClassName::clear_classname_cache();
|
|
$fields = DataObject::database_fields('DataObjectSchemaGenerationTest_DO');
|
|
$this->assertEquals("DBClassName", $fields['ClassName']);
|
|
$this->assertEquals(
|
|
array(
|
|
'DataObjectSchemaGenerationTest_DO' => 'DataObjectSchemaGenerationTest_DO',
|
|
'DataObjectSchemaGenerationTest_IndexDO' => 'DataObjectSchemaGenerationTest_IndexDO'
|
|
),
|
|
$item1->dbObject('ClassName')->getEnum()
|
|
);
|
|
$item1->delete();
|
|
$item2->delete();
|
|
}
|
|
}
|
|
|
|
class DataObjectSchemaGenerationTest_DO extends DataObject implements TestOnly {
|
|
private static $db = array(
|
|
'Enum1' => 'Enum("A, B, C, D","")',
|
|
'Enum2' => 'Enum("A, B, C, D","A")',
|
|
'NumberField' => 'Decimal',
|
|
'FloatingField' => 'Decimal(10,3,1.1)',
|
|
'TextValue' => 'Varchar',
|
|
'Date' => 'SS_Datetime',
|
|
'MyNumber' => 'Int'
|
|
);
|
|
}
|
|
|
|
|
|
class DataObjectSchemaGenerationTest_IndexDO extends DataObjectSchemaGenerationTest_DO implements TestOnly {
|
|
private static $db = array(
|
|
'Title' => 'Varchar(255)',
|
|
'Content' => 'Text'
|
|
);
|
|
|
|
private static $indexes = array(
|
|
'NameIndex' => 'unique ("Title")',
|
|
'SearchFields' => array(
|
|
'type' => 'fulltext',
|
|
'name' => 'SearchFields',
|
|
'value' => '"Title","Content"'
|
|
)
|
|
);
|
|
|
|
/** @config */
|
|
private static $indexes_alt = array(
|
|
'NameIndex' => array(
|
|
'type' => 'unique',
|
|
'name' => 'NameIndex',
|
|
'value' => '"Title"'
|
|
),
|
|
'SearchFields' => 'fulltext ("Title","Content")'
|
|
);
|
|
}
|