mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-09-18 23:46:21 +02:00
3873e4ba00
See https://github.com/silverstripe/silverstripe-framework/pull/7037 and https://github.com/silverstripe/silverstripe-framework/issues/6681 Squashed commit of the following: commit8f65e56532
Author: Ingo Schommer <me@chillu.com> Date: Thu Jun 22 22:25:50 2017 +1200 Fixed upgrade guide spelling commit76f95944fa
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 16:38:34 2017 +1200 BUG Fix non-test class manifest including sapphiretest / functionaltest commit9379834cb4
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:50:47 2017 +1200 BUG Fix nesting bug in Kernel commit188ce35d82
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:14:51 2017 +1200 BUG fix db bootstrapping issues commit7ed4660e7a
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 14:49:07 2017 +1200 BUG Fix issue in DetailedErrorFormatter commit738f50c497
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:49:19 2017 +1200 Upgrading notes on mysite/_config.php commit6279d28e5e
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:43:28 2017 +1200 Update developer documentation commit5c90d53a84
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 10:48:44 2017 +1200 Update installer to not use global databaseConfig commitf9b2ba4755
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 21:04:39 2017 +1200 Fix behat issues commit5b59a912b6
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 17:07:11 2017 +1200 Move HTTPApplication to SilverStripe\Control namespace commite2c4a18f63
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 16:29:03 2017 +1200 More documentation Fix up remaining tests Refactor temp DB into TempDatabase class so it’s available outside of unit tests. commit5d235e64f3
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 12:13:15 2017 +1200 API HTTPRequestBuilder::createFromEnvironment() now cleans up live globals BUG Fix issue with SSViewer Fix Security / View tests commitd88d4ed4e4
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:39:43 2017 +1200 API Refactor AppKernel into CoreKernel commitf7946aec33
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:00:40 2017 +1200 Docs and minor cleanup commit12bd31f936
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 15:34:34 2017 +1200 API Remove OutputMiddleware API Move environment / global / ini management into Environment class API Move getTempFolder into TempFolder class API Implement HTTPRequestBuilder / CLIRequestBuilder BUG Restore SS_ALLOWED_HOSTS check in original location API CoreKernel now requires $basePath to be passed in API Refactor installer.php to use application to bootstrap API move memstring conversion globals to Convert BUG Fix error in CoreKernel nesting not un-nesting itself properly. commitbba9791146
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 18:07:53 2017 +1200 API Create HTTPMiddleware and standardise middleware for request handling commit2a10c2397b
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:42:42 2017 +1200 Fixed ORM tests commitd75a8d1d93
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:15:07 2017 +1200 FIx i18n tests commit06364af3c3
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 16:59:34 2017 +1200 Fix controller namespace Move states to sub namespace commit2a278e2953
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 12:49:45 2017 +1200 Fix forms namespace commitb65c21241b
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:56:48 2017 +1200 Update API usages commitd1d4375c95
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:41:44 2017 +1200 API Refactor $flush into HTPPApplication API Enforce health check in Controller::pushCurrent() API Better global backup / restore Updated Director::test() to use new API commitb220534f06
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 22:05:57 2017 +1200 Move app nesting to a test state helper commit603704165c
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 21:46:04 2017 +1200 Restore kernel stack to fix multi-level nesting commit2f6336a15b
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 17:23:21 2017 +1200 API Implement kernel nesting commitfc7188da7d
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:43:13 2017 +1200 Fix core tests commita0ae723514
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:23:52 2017 +1200 Fix manifest tests commitca03395251
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:00:00 2017 +1200 API Move extension management into test state commitc66d433977
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 14:10:59 2017 +1200 API Refactor SapphireTest state management into SapphireTestState API Remove Injector::unregisterAllObjects() API Remove FakeController commitf26ae75c6e
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 18:04:34 2017 +1200 Implement basic CLI application object commit001d559662
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 17:39:38 2017 +1200 Remove references to SapphireTest::is_running_test() Upgrade various code commitde079c041d
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 7 18:07:33 2017 +1200 API Implement APP object API Refactor of Session
326 lines
10 KiB
PHP
326 lines
10 KiB
PHP
<?php
|
|
|
|
namespace SilverStripe\Core\Tests\Startup;
|
|
|
|
use Exception;
|
|
use Foo;
|
|
use SilverStripe\Core\Startup\ErrorControlChain;
|
|
use SilverStripe\Dev\SapphireTest;
|
|
|
|
class ErrorControlChainTest extends SapphireTest
|
|
{
|
|
|
|
protected function setUp()
|
|
{
|
|
|
|
// Check we can run PHP at all
|
|
$null = is_writeable('/dev/null') ? '/dev/null' : 'NUL';
|
|
exec("php -v 2> $null", $out, $rv);
|
|
|
|
if ($rv != 0) {
|
|
$this->markTestSkipped("Can't run PHP from the command line - is it in your path?");
|
|
}
|
|
|
|
parent::setUp();
|
|
}
|
|
|
|
public function testErrorSuppression()
|
|
{
|
|
|
|
// Errors disabled by default
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
$chain->setDisplayErrors('Off'); // mocks display_errors: Off
|
|
$initialValue = null;
|
|
$whenNotSuppressed = null;
|
|
$whenSuppressed = null;
|
|
$chain->then(function (ErrorControlChainTest\ErrorControlChainTest_Chain $chain) use (
|
|
&$initialValue,
|
|
&$whenNotSuppressed,
|
|
&$whenSuppressed
|
|
) {
|
|
$initialValue = $chain->getDisplayErrors();
|
|
$chain->setSuppression(false);
|
|
$whenNotSuppressed = $chain->getDisplayErrors();
|
|
$chain->setSuppression(true);
|
|
$whenSuppressed = $chain->getDisplayErrors();
|
|
})->execute();
|
|
|
|
// Disabled errors never un-disable
|
|
$this->assertEquals(0, $initialValue); // Chain starts suppressed
|
|
$this->assertEquals(0, $whenSuppressed); // false value used internally when suppressed
|
|
$this->assertEquals('Off', $whenNotSuppressed); // false value set by php ini when suppression lifted
|
|
$this->assertEquals('Off', $chain->getDisplayErrors()); // Correctly restored after run
|
|
|
|
// Errors enabled by default
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
$chain->setDisplayErrors('Yes'); // non-falsey ini value
|
|
$initialValue = null;
|
|
$whenNotSuppressed = null;
|
|
$whenSuppressed = null;
|
|
$chain->then(function (ErrorControlChainTest\ErrorControlChainTest_Chain $chain) use (
|
|
&$initialValue,
|
|
&$whenNotSuppressed,
|
|
&$whenSuppressed
|
|
) {
|
|
$initialValue = $chain->getDisplayErrors();
|
|
$chain->setSuppression(true);
|
|
$whenSuppressed = $chain->getDisplayErrors();
|
|
$chain->setSuppression(false);
|
|
$whenNotSuppressed = $chain->getDisplayErrors();
|
|
})->execute();
|
|
|
|
// Errors can be suppressed an un-suppressed when initially enabled
|
|
$this->assertEquals(0, $initialValue); // Chain starts suppressed
|
|
$this->assertEquals(0, $whenSuppressed); // false value used internally when suppressed
|
|
$this->assertEquals('Yes', $whenNotSuppressed); // false value set by php ini when suppression lifted
|
|
$this->assertEquals('Yes', $chain->getDisplayErrors()); // Correctly restored after run
|
|
|
|
// Fatal error
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
Foo::bar(); // Non-existant class causes fatal error
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
|
|
// User error
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
user_error('Error', E_USER_ERROR);
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
|
|
// Recoverable error
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
$x = function (ErrorControlChain $foo) {
|
|
};
|
|
$x(1); // Calling against type
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
|
|
// Memory exhaustion
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
ini_set('memory_limit', '10M');
|
|
$a = array();
|
|
while (1) {
|
|
$a[] = 1;
|
|
}
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
|
|
// Exceptions
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
throw new Exception("bob");
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
}
|
|
|
|
public function testExceptionSuppression()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
throw new Exception('This exception should be suppressed');
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Done";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals('Done', $out);
|
|
}
|
|
|
|
public function testErrorControl()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
echo 'preThen,';
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo 'preThenIfErrored,';
|
|
})
|
|
->thenAlways(function () {
|
|
echo 'preThenAlways,';
|
|
})
|
|
->then(function () {
|
|
user_error('An error', E_USER_ERROR);
|
|
})
|
|
->then(function () {
|
|
echo 'postThen,';
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo 'postThenIfErrored,';
|
|
})
|
|
->thenAlways(function () {
|
|
echo 'postThenAlways,';
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertEquals(
|
|
"preThen,preThenAlways,postThenIfErrored,postThenAlways,",
|
|
$out
|
|
);
|
|
}
|
|
|
|
public function testSuppressionControl()
|
|
{
|
|
// Turning off suppression before execution
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
$chain->setSuppression(false);
|
|
|
|
list($out, $code) = $chain
|
|
->then(function ($chain) {
|
|
Foo::bar(); // Non-existant class causes fatal error
|
|
})
|
|
->executeInSubprocess(true);
|
|
|
|
$this->assertContains('Fatal error', $out);
|
|
$this->assertContains('Foo', $out);
|
|
|
|
// Turning off suppression during execution
|
|
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function ($chain) {
|
|
$chain->setSuppression(false);
|
|
Foo::bar(); // Non-existent class causes fatal error
|
|
})
|
|
->executeInSubprocess(true);
|
|
|
|
$this->assertContains('Fatal error', $out);
|
|
$this->assertContains('Foo', $out);
|
|
}
|
|
|
|
public function testDoesntAffectNonFatalErrors()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
$array = null;
|
|
if (@$array['key'] !== null) {
|
|
user_error('Error', E_USER_ERROR);
|
|
}
|
|
})
|
|
->then(function () {
|
|
echo "Good";
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Bad";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertContains("Good", $out);
|
|
}
|
|
|
|
public function testDoesntAffectCaughtExceptions()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
try {
|
|
throw new Exception('Error');
|
|
} catch (Exception $e) {
|
|
echo "Good";
|
|
}
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Bad";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertContains("Good", $out);
|
|
}
|
|
|
|
public function testDoesntAffectHandledErrors()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
list($out, $code) = $chain
|
|
->then(function () {
|
|
set_error_handler(
|
|
function () {
|
|
/* NOP */
|
|
}
|
|
);
|
|
user_error('Error', E_USER_ERROR);
|
|
})
|
|
->then(function () {
|
|
echo "Good";
|
|
})
|
|
->thenIfErrored(function () {
|
|
echo "Bad";
|
|
})
|
|
->executeInSubprocess();
|
|
|
|
$this->assertContains("Good", $out);
|
|
}
|
|
|
|
public function testMemoryConversion()
|
|
{
|
|
$chain = new ErrorControlChainTest\ErrorControlChainTest_Chain();
|
|
|
|
$this->assertEquals(200, $chain->translateMemstring('200'));
|
|
$this->assertEquals(300, $chain->translateMemstring('300'));
|
|
|
|
$this->assertEquals(2 * 1024, $chain->translateMemstring('2k'));
|
|
$this->assertEquals(3 * 1024, $chain->translateMemstring('3K'));
|
|
|
|
$this->assertEquals(2 * 1024 * 1024, $chain->translateMemstring('2m'));
|
|
$this->assertEquals(3 * 1024 * 1024, $chain->translateMemstring('3M'));
|
|
|
|
$this->assertEquals(2 * 1024 * 1024 * 1024, $chain->translateMemstring('2g'));
|
|
$this->assertEquals(3 * 1024 * 1024 * 1024, $chain->translateMemstring('3G'));
|
|
|
|
$this->assertEquals(200, $chain->translateMemstring('200foo'));
|
|
$this->assertEquals(300, $chain->translateMemstring('300foo'));
|
|
}
|
|
}
|