mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
01d3b4fd96
When many-many-through relations are queried, a joinRecord is set on each DataObject in the list to provide the extra fields defined on the connector object. This didn’t previously happen when the record was first add()ed to a list. This fixes that bug.
366 lines
13 KiB
PHP
366 lines
13 KiB
PHP
<?php
|
|
|
|
namespace SilverStripe\ORM\Tests;
|
|
|
|
use SilverStripe\Core\Config\Config;
|
|
use SilverStripe\Dev\SapphireTest;
|
|
use SilverStripe\ORM\DataObject;
|
|
use SilverStripe\ORM\ManyManyThroughList;
|
|
use SilverStripe\ORM\Tests\ManyManyThroughListTest\Item;
|
|
use SilverStripe\ORM\Tests\ManyManyThroughListTest\PolyItem;
|
|
use SilverStripe\ORM\Tests\ManyManyThroughListTest\PolyJoinObject;
|
|
use SilverStripe\ORM\Tests\ManyManyThroughListTest\Locale;
|
|
use SilverStripe\ORM\Tests\ManyManyThroughListTest\FallbackLocale;
|
|
|
|
class ManyManyThroughListTest extends SapphireTest
|
|
{
|
|
protected static $fixture_file = 'ManyManyThroughListTest.yml';
|
|
|
|
protected static $extra_dataobjects = [
|
|
ManyManyThroughListTest\Item::class,
|
|
ManyManyThroughListTest\JoinObject::class,
|
|
ManyManyThroughListTest\TestObject::class,
|
|
ManyManyThroughListTest\PolyItem::class,
|
|
ManyManyThroughListTest\PolyJoinObject::class,
|
|
ManyManyThroughListTest\PolyObjectA::class,
|
|
ManyManyThroughListTest\PolyObjectB::class,
|
|
ManyManyThroughListTest\Locale::class,
|
|
ManyManyThroughListTest\FallbackLocale::class,
|
|
];
|
|
|
|
protected function setUp()
|
|
{
|
|
parent::setUp();
|
|
DataObject::reset();
|
|
}
|
|
|
|
protected function tearDown()
|
|
{
|
|
DataObject::reset();
|
|
parent::tearDown();
|
|
}
|
|
|
|
public function testSelectJoin()
|
|
{
|
|
/** @var ManyManyThroughListTest\TestObject $parent */
|
|
$parent = $this->objFromFixture(ManyManyThroughListTest\TestObject::class, 'parent1');
|
|
$this->assertListEquals(
|
|
[
|
|
['Title' => 'item 1'],
|
|
['Title' => 'item 2']
|
|
],
|
|
$parent->Items()
|
|
);
|
|
// Check filters on list work
|
|
$item1 = $parent->Items()->filter('Title', 'item 1')->first();
|
|
$this->assertNotNull($item1);
|
|
$this->assertNotNull($item1->getJoin());
|
|
$this->assertEquals('join 1', $item1->getJoin()->Title);
|
|
$this->assertInstanceOf(
|
|
ManyManyThroughListTest\JoinObject::class,
|
|
$item1->ManyManyThroughListTest_JoinObject
|
|
);
|
|
$this->assertEquals('join 1', $item1->ManyManyThroughListTest_JoinObject->Title);
|
|
|
|
// Check filters on list work
|
|
$item2 = $parent->Items()->filter('Title', 'item 2')->first();
|
|
$this->assertNotNull($item2);
|
|
$this->assertNotNull($item2->getJoin());
|
|
$this->assertEquals('join 2', $item2->getJoin()->Title);
|
|
$this->assertEquals('join 2', $item2->ManyManyThroughListTest_JoinObject->Title);
|
|
|
|
// To filter on join table need to use some raw sql
|
|
$item2 = $parent->Items()->where(['"ManyManyThroughListTest_JoinObject"."Title"' => 'join 2'])->first();
|
|
$this->assertNotNull($item2);
|
|
$this->assertEquals('item 2', $item2->Title);
|
|
$this->assertNotNull($item2->getJoin());
|
|
$this->assertEquals('join 2', $item2->getJoin()->Title);
|
|
$this->assertEquals('join 2', $item2->ManyManyThroughListTest_JoinObject->Title);
|
|
|
|
// Check that the join record is set for new records added
|
|
$item3 = new Item;
|
|
$this->assertNull($item3->getJoin());
|
|
$parent->Items()->add($item3);
|
|
$expectedJoinObject = ManyManyThroughListTest\JoinObject::get()->filter(['ParentID' => $parent->ID, 'ChildID' => $item3->ID ])->first();
|
|
$this->assertEquals($expectedJoinObject->ID, $item3->getJoin()->ID);
|
|
$this->assertEquals(get_class($expectedJoinObject), get_class($item3->getJoin()));
|
|
}
|
|
|
|
/**
|
|
* @param string $sort
|
|
* @param array $expected
|
|
* @dataProvider sortingProvider
|
|
*/
|
|
public function testSorting($sort, $expected)
|
|
{
|
|
/** @var ManyManyThroughListTest\TestObject $parent */
|
|
$parent = $this->objFromFixture(ManyManyThroughListTest\TestObject::class, 'parent1');
|
|
|
|
$items = $parent->Items();
|
|
if ($sort) {
|
|
$items = $items->sort($sort);
|
|
}
|
|
$this->assertSame($expected, $items->column('Title'));
|
|
}
|
|
|
|
/**
|
|
* @return array[]
|
|
*/
|
|
public function sortingProvider()
|
|
{
|
|
return [
|
|
'nothing passed (default)' => [
|
|
null,
|
|
['item 2', 'item 1'],
|
|
],
|
|
'table with default column' => [
|
|
'"ManyManyThroughListTest_JoinObject"."Sort"',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'table with default column ascending' => [
|
|
'"ManyManyThroughListTest_JoinObject"."Sort" ASC',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'table with default column descending' => [
|
|
'"ManyManyThroughListTest_JoinObject"."Sort" DESC',
|
|
['item 1', 'item 2'],
|
|
],
|
|
'table with column descending' => [
|
|
'"ManyManyThroughListTest_JoinObject"."Title" DESC',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'table with column ascending' => [
|
|
'"ManyManyThroughListTest_JoinObject"."Title" ASC',
|
|
['item 1', 'item 2'],
|
|
],
|
|
'default column' => [
|
|
'"Sort"',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'default column ascending' => [
|
|
'"Sort" ASC',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'default column descending' => [
|
|
'"Sort" DESC',
|
|
['item 1', 'item 2'],
|
|
],
|
|
'column descending' => [
|
|
'"Title" DESC',
|
|
['item 2', 'item 1'],
|
|
],
|
|
'column ascending' => [
|
|
'"Title" ASC',
|
|
['item 1', 'item 2'],
|
|
],
|
|
];
|
|
}
|
|
|
|
public function testAdd()
|
|
{
|
|
/** @var ManyManyThroughListTest\TestObject $parent */
|
|
$parent = $this->objFromFixture(ManyManyThroughListTest\TestObject::class, 'parent1');
|
|
$newItem = new ManyManyThroughListTest\Item();
|
|
$newItem->Title = 'my new item';
|
|
$newItem->write();
|
|
$parent->Items()->add($newItem, ['Title' => 'new join record']);
|
|
|
|
// Check select
|
|
$newItem = $parent->Items()->filter(['Title' => 'my new item'])->first();
|
|
$this->assertNotNull($newItem);
|
|
$this->assertEquals('my new item', $newItem->Title);
|
|
$this->assertInstanceOf(
|
|
ManyManyThroughListTest\JoinObject::class,
|
|
$newItem->getJoin()
|
|
);
|
|
$this->assertInstanceOf(
|
|
ManyManyThroughListTest\JoinObject::class,
|
|
$newItem->ManyManyThroughListTest_JoinObject
|
|
);
|
|
$this->assertEquals('new join record', $newItem->ManyManyThroughListTest_JoinObject->Title);
|
|
}
|
|
|
|
public function testRemove()
|
|
{
|
|
/** @var ManyManyThroughListTest\TestObject $parent */
|
|
$parent = $this->objFromFixture(ManyManyThroughListTest\TestObject::class, 'parent1');
|
|
$this->assertListEquals(
|
|
[
|
|
['Title' => 'item 1'],
|
|
['Title' => 'item 2']
|
|
],
|
|
$parent->Items()
|
|
);
|
|
$item1 = $parent->Items()->filter(['Title' => 'item 1'])->first();
|
|
$parent->Items()->remove($item1);
|
|
$this->assertListEquals(
|
|
[['Title' => 'item 2']],
|
|
$parent->Items()
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test validation
|
|
*
|
|
* @expectedException \InvalidArgumentException
|
|
*/
|
|
public function testValidateModelValidatesJoinType()
|
|
{
|
|
DataObject::reset();
|
|
ManyManyThroughListTest\Item::config()->update(
|
|
'db',
|
|
[
|
|
ManyManyThroughListTest\JoinObject::class => 'Text'
|
|
]
|
|
);
|
|
|
|
DataObject::getSchema()->manyManyComponent(ManyManyThroughListTest\TestObject::class, 'Items');
|
|
}
|
|
|
|
public function testRelationParsing()
|
|
{
|
|
$schema = DataObject::getSchema();
|
|
|
|
// Parent components
|
|
$this->assertEquals(
|
|
[
|
|
'relationClass' => ManyManyThroughList::class,
|
|
'parentClass' => ManyManyThroughListTest\TestObject::class,
|
|
'childClass' => ManyManyThroughListTest\Item::class,
|
|
'parentField' => 'ParentID',
|
|
'childField' => 'ChildID',
|
|
'join' => ManyManyThroughListTest\JoinObject::class
|
|
],
|
|
$schema->manyManyComponent(ManyManyThroughListTest\TestObject::class, 'Items')
|
|
);
|
|
|
|
// Belongs_many_many is the same, but with parent/child substituted
|
|
$this->assertEquals(
|
|
[
|
|
'relationClass' => ManyManyThroughList::class,
|
|
'parentClass' => ManyManyThroughListTest\Item::class,
|
|
'childClass' => ManyManyThroughListTest\TestObject::class,
|
|
'parentField' => 'ChildID',
|
|
'childField' => 'ParentID',
|
|
'join' => ManyManyThroughListTest\JoinObject::class
|
|
],
|
|
$schema->manyManyComponent(ManyManyThroughListTest\Item::class, 'Objects')
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Note: polymorphic many_many support is currently experimental
|
|
*/
|
|
public function testPolymorphicManyMany()
|
|
{
|
|
/** @var ManyManyThroughListTest\PolyObjectA $objA1 */
|
|
$objA1 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectA::class, 'obja1');
|
|
/** @var ManyManyThroughListTest\PolyObjectB $objB1 */
|
|
$objB1 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectB::class, 'objb1');
|
|
/** @var ManyManyThroughListTest\PolyObjectB $objB2 */
|
|
$objB2 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectB::class, 'objb2');
|
|
|
|
// Test various parent class queries
|
|
$this->assertListEquals([
|
|
['Title' => 'item 1'],
|
|
['Title' => 'item 2'],
|
|
], $objA1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 2'],
|
|
], $objB1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 2'],
|
|
], $objB2->Items());
|
|
|
|
// Test adding items
|
|
$newItem = new PolyItem();
|
|
$newItem->Title = 'New Item';
|
|
$objA1->Items()->add($newItem);
|
|
$objB2->Items()->add($newItem);
|
|
$this->assertListEquals([
|
|
['Title' => 'item 1'],
|
|
['Title' => 'item 2'],
|
|
['Title' => 'New Item'],
|
|
], $objA1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 2'],
|
|
], $objB1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 2'],
|
|
['Title' => 'New Item'],
|
|
], $objB2->Items());
|
|
|
|
// Test removing items
|
|
$item2 = $this->objFromFixture(ManyManyThroughListTest\PolyItem::class, 'child2');
|
|
$objA1->Items()->remove($item2);
|
|
$objB1->Items()->remove($item2);
|
|
$this->assertListEquals([
|
|
['Title' => 'item 1'],
|
|
['Title' => 'New Item'],
|
|
], $objA1->Items());
|
|
$this->assertListEquals([], $objB1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 2'],
|
|
['Title' => 'New Item'],
|
|
], $objB2->Items());
|
|
|
|
// Test set-by-id-list
|
|
$objB2->Items()->setByIDList([
|
|
$newItem->ID,
|
|
$this->idFromFixture(ManyManyThroughListTest\PolyItem::class, 'child1'),
|
|
]);
|
|
$this->assertListEquals([
|
|
['Title' => 'item 1'],
|
|
['Title' => 'New Item'],
|
|
], $objA1->Items());
|
|
$this->assertListEquals([], $objB1->Items());
|
|
$this->assertListEquals([
|
|
['Title' => 'item 1'],
|
|
['Title' => 'New Item'],
|
|
], $objB2->Items());
|
|
}
|
|
|
|
public function testGetJoinTable()
|
|
{
|
|
$joinTable = DataObject::getSchema()->tableName(PolyJoinObject::class);
|
|
/** @var ManyManyThroughListTest\PolyObjectA $objA1 */
|
|
$objA1 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectA::class, 'obja1');
|
|
/** @var ManyManyThroughListTest\PolyObjectB $objB1 */
|
|
$objB1 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectB::class, 'objb1');
|
|
/** @var ManyManyThroughListTest\PolyObjectB $objB2 */
|
|
$objB2 = $this->objFromFixture(ManyManyThroughListTest\PolyObjectB::class, 'objb2');
|
|
|
|
$this->assertEquals($joinTable, $objA1->Items()->getJoinTable());
|
|
$this->assertEquals($joinTable, $objB1->Items()->getJoinTable());
|
|
$this->assertEquals($joinTable, $objB2->Items()->getJoinTable());
|
|
}
|
|
|
|
/**
|
|
* This tests that default sort works when the join table has a default sort set, and the main
|
|
* dataobject has a default sort set.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function testDefaultSortOnJoinAndMain()
|
|
{
|
|
// We have spanish mexico with two fall back locales; argentina and international sorted in that order.
|
|
$mexico = $this->objFromFixture(Locale::class, 'mexico');
|
|
|
|
$fallbacks = $mexico->Fallbacks();
|
|
$this->assertCount(2, $fallbacks);
|
|
|
|
// Ensure the default sort is is correct
|
|
list($first, $second) = $fallbacks;
|
|
$this->assertSame('Argentina', $first->Title);
|
|
$this->assertSame('International', $second->Title);
|
|
|
|
// Ensure that we're respecting the default sort by reversing it
|
|
Config::inst()->update(FallbackLocale::class, 'default_sort', '"ManyManyThroughTest_FallbackLocale"."Sort" DESC');
|
|
|
|
$reverse = $mexico->Fallbacks();
|
|
list($firstReverse, $secondReverse) = $reverse;
|
|
$this->assertSame('International', $firstReverse->Title);
|
|
$this->assertSame('Argentina', $secondReverse->Title);
|
|
}
|
|
}
|