mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
3873e4ba00
See https://github.com/silverstripe/silverstripe-framework/pull/7037 and https://github.com/silverstripe/silverstripe-framework/issues/6681 Squashed commit of the following: commit8f65e56532
Author: Ingo Schommer <me@chillu.com> Date: Thu Jun 22 22:25:50 2017 +1200 Fixed upgrade guide spelling commit76f95944fa
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 16:38:34 2017 +1200 BUG Fix non-test class manifest including sapphiretest / functionaltest commit9379834cb4
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:50:47 2017 +1200 BUG Fix nesting bug in Kernel commit188ce35d82
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:14:51 2017 +1200 BUG fix db bootstrapping issues commit7ed4660e7a
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 14:49:07 2017 +1200 BUG Fix issue in DetailedErrorFormatter commit738f50c497
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:49:19 2017 +1200 Upgrading notes on mysite/_config.php commit6279d28e5e
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:43:28 2017 +1200 Update developer documentation commit5c90d53a84
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 10:48:44 2017 +1200 Update installer to not use global databaseConfig commitf9b2ba4755
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 21:04:39 2017 +1200 Fix behat issues commit5b59a912b6
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 17:07:11 2017 +1200 Move HTTPApplication to SilverStripe\Control namespace commite2c4a18f63
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 16:29:03 2017 +1200 More documentation Fix up remaining tests Refactor temp DB into TempDatabase class so it’s available outside of unit tests. commit5d235e64f3
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 12:13:15 2017 +1200 API HTTPRequestBuilder::createFromEnvironment() now cleans up live globals BUG Fix issue with SSViewer Fix Security / View tests commitd88d4ed4e4
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:39:43 2017 +1200 API Refactor AppKernel into CoreKernel commitf7946aec33
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:00:40 2017 +1200 Docs and minor cleanup commit12bd31f936
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 15:34:34 2017 +1200 API Remove OutputMiddleware API Move environment / global / ini management into Environment class API Move getTempFolder into TempFolder class API Implement HTTPRequestBuilder / CLIRequestBuilder BUG Restore SS_ALLOWED_HOSTS check in original location API CoreKernel now requires $basePath to be passed in API Refactor installer.php to use application to bootstrap API move memstring conversion globals to Convert BUG Fix error in CoreKernel nesting not un-nesting itself properly. commitbba9791146
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 18:07:53 2017 +1200 API Create HTTPMiddleware and standardise middleware for request handling commit2a10c2397b
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:42:42 2017 +1200 Fixed ORM tests commitd75a8d1d93
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:15:07 2017 +1200 FIx i18n tests commit06364af3c3
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 16:59:34 2017 +1200 Fix controller namespace Move states to sub namespace commit2a278e2953
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 12:49:45 2017 +1200 Fix forms namespace commitb65c21241b
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:56:48 2017 +1200 Update API usages commitd1d4375c95
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:41:44 2017 +1200 API Refactor $flush into HTPPApplication API Enforce health check in Controller::pushCurrent() API Better global backup / restore Updated Director::test() to use new API commitb220534f06
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 22:05:57 2017 +1200 Move app nesting to a test state helper commit603704165c
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 21:46:04 2017 +1200 Restore kernel stack to fix multi-level nesting commit2f6336a15b
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 17:23:21 2017 +1200 API Implement kernel nesting commitfc7188da7d
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:43:13 2017 +1200 Fix core tests commita0ae723514
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:23:52 2017 +1200 Fix manifest tests commitca03395251
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:00:00 2017 +1200 API Move extension management into test state commitc66d433977
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 14:10:59 2017 +1200 API Refactor SapphireTest state management into SapphireTestState API Remove Injector::unregisterAllObjects() API Remove FakeController commitf26ae75c6e
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 18:04:34 2017 +1200 Implement basic CLI application object commit001d559662
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 17:39:38 2017 +1200 Remove references to SapphireTest::is_running_test() Upgrade various code commitde079c041d
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 7 18:07:33 2017 +1200 API Implement APP object API Refactor of Session
521 lines
16 KiB
PHP
521 lines
16 KiB
PHP
<?php
|
|
|
|
namespace SilverStripe\Forms\Tests;
|
|
|
|
use SilverStripe\Control\Controller;
|
|
use SilverStripe\ORM\ArrayList;
|
|
use SilverStripe\Dev\CSSContentParser;
|
|
use SilverStripe\Dev\SapphireTest;
|
|
use SilverStripe\Forms\DropdownField;
|
|
use SilverStripe\Forms\RequiredFields;
|
|
use SilverStripe\Forms\FieldList;
|
|
use SilverStripe\Forms\Form;
|
|
use SilverStripe\View\ArrayData;
|
|
use SilverStripe\ORM\Map;
|
|
|
|
class DropdownFieldTest extends SapphireTest
|
|
{
|
|
|
|
public function testGetSource()
|
|
{
|
|
$source = array(1=>'one', 2 => 'two');
|
|
$field = new DropdownField('Field', null, $source);
|
|
$this->assertEquals(
|
|
$source,
|
|
$field->getSource()
|
|
);
|
|
$this->assertEquals(
|
|
$source,
|
|
$field->getSource()
|
|
);
|
|
|
|
$items = new ArrayList(
|
|
array(
|
|
array( 'ID' => 1, 'Title' => 'ichi', 'OtherField' => 'notone' ),
|
|
array( 'ID' => 2, 'Title' => 'ni', 'OtherField' => 'nottwo' ),
|
|
)
|
|
);
|
|
$field->setSource($items);
|
|
$this->assertEquals(
|
|
$field->getSource(),
|
|
array(
|
|
1 => 'ichi',
|
|
2 => 'ni',
|
|
)
|
|
);
|
|
|
|
$map = new Map($items, 'ID', 'OtherField');
|
|
$field->setSource($map);
|
|
$this->assertEquals(
|
|
$field->getSource(),
|
|
array(
|
|
1 => 'notone',
|
|
2 => 'nottwo',
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test different data sources
|
|
*/
|
|
public function testSources()
|
|
{
|
|
// Array
|
|
$items = array('a' => 'Apple', 'b' => 'Banana', 'c' => 'Cranberry');
|
|
$field = new DropdownField('Field', null, $items);
|
|
$this->assertEquals($items, $field->getSource());
|
|
|
|
// SS_List
|
|
$list = new ArrayList(
|
|
array(
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'a',
|
|
'Title' => 'Apple'
|
|
)
|
|
),
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'b',
|
|
'Title' => 'Banana'
|
|
)
|
|
),
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'c',
|
|
'Title' => 'Cranberry'
|
|
)
|
|
)
|
|
)
|
|
);
|
|
$field2 = new DropdownField('Field', null, $list);
|
|
$this->assertEquals($items, $field2->getSource());
|
|
|
|
$field3 = new DropdownField('Field', null, $list->map());
|
|
$this->assertEquals($items, $field3->getSource());
|
|
}
|
|
|
|
public function testReadonlyField()
|
|
{
|
|
$field = new DropdownField('FeelingOk', 'Are you feeling ok?', array(0 => 'No', 1 => 'Yes'));
|
|
$field->setEmptyString('(Select one)');
|
|
$field->setValue(1);
|
|
$readonlyField = $field->performReadonlyTransformation();
|
|
preg_match('/Yes/', $field->Field(), $matches);
|
|
$this->assertEquals($matches[0], 'Yes');
|
|
}
|
|
|
|
public function testHasEmptyDefault()
|
|
{
|
|
$source = array(1 => 'one');
|
|
|
|
// Test getSource with empty
|
|
$field = new DropdownField('Field', null, $source);
|
|
$field->setHasEmptyDefault(true);
|
|
|
|
$this->assertEquals(
|
|
$field->getSource(),
|
|
array(
|
|
1 => 'one'
|
|
)
|
|
);
|
|
|
|
// Test that an empty option comes through in the markup however
|
|
$options = $this->findOptionElements($field->Field());
|
|
|
|
$this->assertEquals(
|
|
2,
|
|
count($options),
|
|
'Two options exist in the markup, one for the source, one for empty'
|
|
);
|
|
|
|
// the default value should be first
|
|
$first = array_shift($options);
|
|
$attrs = $first->attributes();
|
|
|
|
$this->assertNotEquals(
|
|
1,
|
|
$attrs['value'],
|
|
'First value is the not value (not the source value)'
|
|
);
|
|
|
|
// Test Field Without Empty
|
|
$FieldWithoutEmpty = new DropdownField('Field', null, $source);
|
|
$this->assertEquals(
|
|
$FieldWithoutEmpty->getSource(),
|
|
array(
|
|
1 => 'one'
|
|
)
|
|
);
|
|
|
|
$this->assertEquals(
|
|
1,
|
|
count($options),
|
|
'As hasEmptyDefault is not provided, then no default option.'
|
|
);
|
|
}
|
|
|
|
public function testZeroArraySourceNotOverwrittenByEmptyString()
|
|
{
|
|
$source = array(0=>'zero');
|
|
$field = new DropdownField('Field', null, $source);
|
|
$field->setEmptyString('select...');
|
|
$this->assertEquals(
|
|
$field->getSource(),
|
|
array(
|
|
0 => 'zero'
|
|
)
|
|
);
|
|
|
|
$options = $this->findOptionElements($field->Field());
|
|
|
|
$this->assertEquals(
|
|
2,
|
|
count($options),
|
|
'Two options exist in the markup, one for the source, one for empty'
|
|
);
|
|
}
|
|
|
|
public function testStringZeroValueSelectedOptionBehaviour()
|
|
{
|
|
$field = new DropdownField(
|
|
'Field',
|
|
null,
|
|
array(
|
|
'-1' => 'some negative',
|
|
'0' => 'none',
|
|
'1' => 'one',
|
|
'2+' => 'two or more'
|
|
),
|
|
'0'
|
|
);
|
|
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'none', 'The selected option is "none"');
|
|
|
|
$field = new DropdownField(
|
|
'Field',
|
|
null,
|
|
array(
|
|
'-1' => 'some negative',
|
|
'0' => 'none',
|
|
'1' => 'one',
|
|
'2+' => 'two or more'
|
|
),
|
|
0
|
|
);
|
|
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'none', 'The selected option is "none"');
|
|
}
|
|
|
|
public function testStringOneValueSelectedOptionBehaviour()
|
|
{
|
|
$field = new DropdownField(
|
|
'Field',
|
|
null,
|
|
array(
|
|
'-1' => 'some negative',
|
|
'0' => 'none',
|
|
'1' => 'one',
|
|
'2+' => 'two or more'
|
|
),
|
|
'1'
|
|
);
|
|
|
|
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'one', 'The selected option is "one"');
|
|
|
|
$field = new DropdownField(
|
|
'Field',
|
|
null,
|
|
array(
|
|
'-1' => 'some negative',
|
|
'0' => 'none',
|
|
'1' => 'one',
|
|
'2+' => 'two or more'
|
|
),
|
|
1
|
|
);
|
|
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'one', 'The selected option is "one"');
|
|
}
|
|
|
|
public function testNumberOfSelectOptionsAvailable()
|
|
{
|
|
/* Create a field with a blank value */
|
|
$field = $this->createDropdownField('(Any)');
|
|
|
|
/* 3 options are available */
|
|
$this->assertEquals(count($this->findOptionElements($field->Field())), 3, '3 options are available');
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals(
|
|
count($selectedOptions),
|
|
1,
|
|
'We only have 1 selected option, since a dropdown can only possibly have one!'
|
|
);
|
|
|
|
/* Create a field without a blank value */
|
|
$field = $this->createDropdownField();
|
|
|
|
/* 2 options are available */
|
|
$this->assertEquals(count($this->findOptionElements($field->Field())), 2, '2 options are available');
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals(count($selectedOptions), 0, 'There are no selected options');
|
|
}
|
|
|
|
public function testIntegerZeroValueSeelctedOptionBehaviour()
|
|
{
|
|
$field = $this->createDropdownField('(Any)', 0);
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'No', 'The selected option is "No"');
|
|
}
|
|
|
|
public function testBlankStringValueSelectedOptionBehaviour()
|
|
{
|
|
$field = $this->createDropdownField('(Any)');
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], '(Any)', 'The selected option is "(Any)"');
|
|
}
|
|
|
|
public function testNullValueSelectedOptionBehaviour()
|
|
{
|
|
$field = $this->createDropdownField('(Any)', null);
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], '(Any)', 'The selected option is "(Any)"');
|
|
}
|
|
|
|
public function testStringValueSelectedOptionBehaviour()
|
|
{
|
|
$field = $this->createDropdownField('(Any)', '1');
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals((string) $selectedOptions[0], 'Yes', 'The selected option is "Yes"');
|
|
$field->setSource(
|
|
array(
|
|
'Cats' => 'Cats and Kittens',
|
|
'Dogs' => 'Dogs and Puppies'
|
|
)
|
|
);
|
|
$field->setValue('Cats');
|
|
$selectedOptions = $this->findSelectedOptionElements($field->Field());
|
|
$this->assertEquals(
|
|
(string) $selectedOptions[0],
|
|
'Cats and Kittens',
|
|
'The selected option is "Cats and Kittens"'
|
|
);
|
|
}
|
|
|
|
public function testNumberOfDisabledOptions()
|
|
{
|
|
/* Create a field with a blank value & set 0 & 1 to disabled */
|
|
$field = $this->createDropdownField('(Any)');
|
|
$field->setDisabledItems(array(0,1));
|
|
|
|
/* 3 options are available */
|
|
$this->assertEquals(count($this->findOptionElements($field->Field())), 3, '3 options are available');
|
|
|
|
/* There are 2 disabled options */
|
|
$disabledOptions = $this->findDisabledOptionElements($field->Field());
|
|
$this->assertEquals(count($disabledOptions), 2, 'We have 2 disabled options');
|
|
|
|
/* Create a field without a blank value & set 1 to disabled, then set none to disabled (unset) */
|
|
$field = $this->createDropdownField();
|
|
$field->setDisabledItems(array(1));
|
|
|
|
/* 2 options are available */
|
|
$this->assertEquals(count($this->findOptionElements($field->Field())), 2, '2 options are available');
|
|
|
|
/* get disabled items returns an array of one */
|
|
$this->assertEquals(
|
|
$field->getDisabledItems(),
|
|
array( 1 )
|
|
);
|
|
|
|
/* unset disabled items */
|
|
$field->setDisabledItems(array());
|
|
|
|
/* There are no disabled options anymore */
|
|
$disabledOptions = $this->findDisabledOptionElements($field->Field());
|
|
$this->assertEquals(count($disabledOptions), 0, 'There are no disabled options');
|
|
}
|
|
|
|
/**
|
|
* The Field() method should be able to handle arrays as values in an edge case. If it couldn't handle it then
|
|
* this test would trigger an array to string conversion PHP notice
|
|
*
|
|
* @dataProvider arrayValueProvider
|
|
*/
|
|
public function testDropdownWithArrayValues($value)
|
|
{
|
|
$field = $this->createDropdownField();
|
|
$field->setValue($value);
|
|
$this->assertInstanceOf('SilverStripe\\ORM\\FieldType\\DBHTMLText', $field->Field());
|
|
$this->assertSame($value, $field->Value());
|
|
}
|
|
|
|
/**
|
|
* @return array
|
|
*/
|
|
public function arrayValueProvider()
|
|
{
|
|
return array(
|
|
array(array()),
|
|
array(array(0)),
|
|
array(array(123)),
|
|
array(array('string')),
|
|
array('Regression-ish test.')
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Create a test dropdown field, with the option to
|
|
* set what source and blank value it should contain
|
|
* as optional parameters.
|
|
*
|
|
* @param string|null $emptyString The text to display for the empty value
|
|
* @param string|integer $value The default value of the field
|
|
* @return DropdownField object
|
|
*/
|
|
public function createDropdownField($emptyString = null, $value = '')
|
|
{
|
|
/* Set up source, with 0 and 1 integers as the values */
|
|
$source = array(
|
|
0 => 'No',
|
|
1 => 'Yes'
|
|
);
|
|
|
|
$field = new DropdownField('Field', null, $source, $value);
|
|
|
|
if ($emptyString !== null) {
|
|
$field->setEmptyString($emptyString);
|
|
}
|
|
|
|
return $field;
|
|
}
|
|
|
|
/**
|
|
* Find all the <OPTION> elements from a
|
|
* string of HTML.
|
|
*
|
|
* @param string $html HTML to scan for elements
|
|
* @return SimpleXMLElement
|
|
*/
|
|
public function findOptionElements($html)
|
|
{
|
|
$parser = new CSSContentParser($html);
|
|
return $parser->getBySelector('option');
|
|
}
|
|
|
|
/**
|
|
* Find all the <OPTION> elements from a
|
|
* string of HTML that have the "selected"
|
|
* attribute.
|
|
*
|
|
* @param string $html HTML to parse for elements
|
|
* @return array of SimpleXMLElement objects
|
|
*/
|
|
public function findSelectedOptionElements($html)
|
|
{
|
|
$options = $this->findOptionElements($html);
|
|
|
|
/* Find any elements that have the "selected" attribute and put them into a list */
|
|
$foundSelected = array();
|
|
foreach ($options as $option) {
|
|
$attributes = $option->attributes();
|
|
if ($attributes) {
|
|
foreach ($attributes as $attribute => $value) {
|
|
if ($attribute == 'selected') {
|
|
$foundSelected[] = $option;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return $foundSelected;
|
|
}
|
|
|
|
/**
|
|
* Find all the <OPTION> elements from a
|
|
* string of HTML that have the "disabled"
|
|
* attribute.
|
|
*
|
|
* @param string $html HTML to parse for elements
|
|
* @return array of SimpleXMLElement objects
|
|
*/
|
|
public function findDisabledOptionElements($html)
|
|
{
|
|
$options = $this->findOptionElements($html);
|
|
|
|
/* Find any elements that have the "disabled" attribute and put them into a list */
|
|
$foundDisabled = array();
|
|
foreach ($options as $option) {
|
|
$attributes = $option->attributes();
|
|
if ($attributes) {
|
|
foreach ($attributes as $attribute => $value) {
|
|
if ($attribute == 'disabled') {
|
|
$foundDisabled[] = $option;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return $foundDisabled;
|
|
}
|
|
|
|
/**
|
|
* @skipUpgrade
|
|
*/
|
|
public function testValidation()
|
|
{
|
|
$field = DropdownField::create(
|
|
'Test',
|
|
'Testing',
|
|
array(
|
|
"One" => "One",
|
|
"Two" => "Two",
|
|
"Five" => "Five"
|
|
)
|
|
);
|
|
$validator = new RequiredFields();
|
|
new Form(null, 'Form', new FieldList($field), new FieldList(), $validator);
|
|
$field->setValue("One");
|
|
$this->assertTrue($field->validate($validator));
|
|
$field->setName("TestNew"); //try changing name of field
|
|
$this->assertTrue($field->validate($validator));
|
|
//non-existent value should make the field invalid
|
|
$field->setValue("Three");
|
|
$this->assertFalse($field->validate($validator));
|
|
//empty string shouldn't validate
|
|
$field->setValue('');
|
|
$this->assertFalse($field->validate($validator));
|
|
//empty field should validate after being set
|
|
$field->setEmptyString('Empty String');
|
|
$field->setValue('');
|
|
$this->assertTrue($field->validate($validator));
|
|
//disabled items shouldn't validate
|
|
$field->setDisabledItems(array('Five'));
|
|
$field->setValue('Five');
|
|
$this->assertFalse($field->validate($validator));
|
|
}
|
|
|
|
/**
|
|
* #2939 DropdownField creates invalid HTML when required
|
|
*/
|
|
public function testRequiredDropdownHasEmptyDefault()
|
|
{
|
|
$field = new \SilverStripe\Forms\DropdownField("RequiredField", "dropdown", ["item 1", "item 2"]);
|
|
|
|
$form = new Form(
|
|
Controller::curr(),
|
|
"form",
|
|
new FieldList($field),
|
|
new FieldList(),
|
|
new RequiredFields(["RequiredField"])
|
|
);
|
|
|
|
$this->assertTrue($field->getHasEmptyDefault());
|
|
}
|
|
}
|