mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
3873e4ba00
See https://github.com/silverstripe/silverstripe-framework/pull/7037 and https://github.com/silverstripe/silverstripe-framework/issues/6681 Squashed commit of the following: commit8f65e56532Author: Ingo Schommer <me@chillu.com> Date: Thu Jun 22 22:25:50 2017 +1200 Fixed upgrade guide spelling commit76f95944faAuthor: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 16:38:34 2017 +1200 BUG Fix non-test class manifest including sapphiretest / functionaltest commit9379834cb4Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:50:47 2017 +1200 BUG Fix nesting bug in Kernel commit188ce35d82Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:14:51 2017 +1200 BUG fix db bootstrapping issues commit7ed4660e7aAuthor: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 14:49:07 2017 +1200 BUG Fix issue in DetailedErrorFormatter commit738f50c497Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:49:19 2017 +1200 Upgrading notes on mysite/_config.php commit6279d28e5eAuthor: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:43:28 2017 +1200 Update developer documentation commit5c90d53a84Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 10:48:44 2017 +1200 Update installer to not use global databaseConfig commitf9b2ba4755Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 21:04:39 2017 +1200 Fix behat issues commit5b59a912b6Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 17:07:11 2017 +1200 Move HTTPApplication to SilverStripe\Control namespace commite2c4a18f63Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 16:29:03 2017 +1200 More documentation Fix up remaining tests Refactor temp DB into TempDatabase class so it’s available outside of unit tests. commit5d235e64f3Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 12:13:15 2017 +1200 API HTTPRequestBuilder::createFromEnvironment() now cleans up live globals BUG Fix issue with SSViewer Fix Security / View tests commitd88d4ed4e4Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:39:43 2017 +1200 API Refactor AppKernel into CoreKernel commitf7946aec33Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:00:40 2017 +1200 Docs and minor cleanup commit12bd31f936Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 15:34:34 2017 +1200 API Remove OutputMiddleware API Move environment / global / ini management into Environment class API Move getTempFolder into TempFolder class API Implement HTTPRequestBuilder / CLIRequestBuilder BUG Restore SS_ALLOWED_HOSTS check in original location API CoreKernel now requires $basePath to be passed in API Refactor installer.php to use application to bootstrap API move memstring conversion globals to Convert BUG Fix error in CoreKernel nesting not un-nesting itself properly. commitbba9791146Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 18:07:53 2017 +1200 API Create HTTPMiddleware and standardise middleware for request handling commit2a10c2397bAuthor: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:42:42 2017 +1200 Fixed ORM tests commitd75a8d1d93Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:15:07 2017 +1200 FIx i18n tests commit06364af3c3Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 16:59:34 2017 +1200 Fix controller namespace Move states to sub namespace commit2a278e2953Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 12:49:45 2017 +1200 Fix forms namespace commitb65c21241bAuthor: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:56:48 2017 +1200 Update API usages commitd1d4375c95Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:41:44 2017 +1200 API Refactor $flush into HTPPApplication API Enforce health check in Controller::pushCurrent() API Better global backup / restore Updated Director::test() to use new API commitb220534f06Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 22:05:57 2017 +1200 Move app nesting to a test state helper commit603704165cAuthor: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 21:46:04 2017 +1200 Restore kernel stack to fix multi-level nesting commit2f6336a15bAuthor: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 17:23:21 2017 +1200 API Implement kernel nesting commitfc7188da7dAuthor: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:43:13 2017 +1200 Fix core tests commita0ae723514Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:23:52 2017 +1200 Fix manifest tests commitca03395251Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:00:00 2017 +1200 API Move extension management into test state commitc66d433977Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 14:10:59 2017 +1200 API Refactor SapphireTest state management into SapphireTestState API Remove Injector::unregisterAllObjects() API Remove FakeController commitf26ae75c6eAuthor: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 18:04:34 2017 +1200 Implement basic CLI application object commit001d559662Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 17:39:38 2017 +1200 Remove references to SapphireTest::is_running_test() Upgrade various code commitde079c041dAuthor: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 7 18:07:33 2017 +1200 API Implement APP object API Refactor of Session
377 lines
14 KiB
PHP
377 lines
14 KiB
PHP
<?php
|
|
|
|
namespace SilverStripe\Control\Tests;
|
|
|
|
use SilverStripe\Control\Controller;
|
|
use SilverStripe\Control\Director;
|
|
use SilverStripe\Control\HTTP;
|
|
use SilverStripe\Control\HTTPRequest;
|
|
use SilverStripe\Control\HTTPResponse;
|
|
use SilverStripe\Core\Injector\Injector;
|
|
use SilverStripe\Core\Kernel;
|
|
use SilverStripe\Dev\FunctionalTest;
|
|
|
|
/**
|
|
* Tests the {@link HTTP} class
|
|
*
|
|
* @skipUpgrade
|
|
*/
|
|
class HTTPTest extends FunctionalTest
|
|
{
|
|
|
|
public function testAddCacheHeaders()
|
|
{
|
|
$body = "<html><head></head><body><h1>Mysite</h1></body></html>";
|
|
$response = new HTTPResponse($body, 200);
|
|
$this->assertEmpty($response->getHeader('Cache-Control'));
|
|
|
|
HTTP::set_cache_age(30);
|
|
|
|
HTTP::add_cache_headers($response);
|
|
$this->assertNotEmpty($response->getHeader('Cache-Control'));
|
|
|
|
// Ensure max-age is zero for development.
|
|
/** @var Kernel $kernel */
|
|
$kernel = Injector::inst()->get(Kernel::class);
|
|
$kernel->setEnvironment(Kernel::DEV);
|
|
$response = new HTTPResponse($body, 200);
|
|
HTTP::add_cache_headers($response);
|
|
$this->assertContains('max-age=0', $response->getHeader('Cache-Control'));
|
|
|
|
// Ensure max-age setting is respected in production.
|
|
$kernel->setEnvironment(Kernel::LIVE);
|
|
$response = new HTTPResponse($body, 200);
|
|
HTTP::add_cache_headers($response);
|
|
$this->assertContains('max-age=30', explode(', ', $response->getHeader('Cache-Control')));
|
|
$this->assertNotContains('max-age=0', $response->getHeader('Cache-Control'));
|
|
|
|
// Still "live": Ensure header's aren't overridden if already set (using purposefully different values).
|
|
$headers = array(
|
|
'Vary' => '*',
|
|
'Pragma' => 'no-cache',
|
|
'Cache-Control' => 'max-age=0, no-cache, no-store',
|
|
);
|
|
$response = new HTTPResponse($body, 200);
|
|
foreach ($headers as $name => $value) {
|
|
$response->addHeader($name, $value);
|
|
}
|
|
HTTP::add_cache_headers($response);
|
|
foreach ($headers as $name => $value) {
|
|
$this->assertEquals($value, $response->getHeader($name));
|
|
}
|
|
}
|
|
|
|
public function testConfigVary()
|
|
{
|
|
/** @var Kernel $kernel */
|
|
$kernel = Injector::inst()->get(Kernel::class);
|
|
$body = "<html><head></head><body><h1>Mysite</h1></body></html>";
|
|
$response = new HTTPResponse($body, 200);
|
|
$kernel->setEnvironment(Kernel::LIVE);
|
|
HTTP::set_cache_age(30);
|
|
HTTP::add_cache_headers($response);
|
|
|
|
$v = $response->getHeader('Vary');
|
|
$this->assertNotEmpty($v);
|
|
|
|
$this->assertContains("Cookie", $v);
|
|
$this->assertContains("X-Forwarded-Protocol", $v);
|
|
$this->assertContains("User-Agent", $v);
|
|
$this->assertContains("Accept", $v);
|
|
|
|
HTTP::config()->update('vary', '');
|
|
|
|
$response = new HTTPResponse($body, 200);
|
|
HTTP::add_cache_headers($response);
|
|
|
|
$v = $response->getHeader('Vary');
|
|
$this->assertEmpty($v);
|
|
}
|
|
|
|
/**
|
|
* Tests {@link HTTP::getLinksIn()}
|
|
*/
|
|
public function testGetLinksIn()
|
|
{
|
|
$content = '
|
|
<h2><a href="/">My Cool Site</a></h2>
|
|
|
|
<p>
|
|
A boy went <a href="home/">home</a> to see his <span><a href="mother/">mother</a></span>. This
|
|
involved a short <a href="$Journey">journey</a>, as well as some <a href="space travel">space travel</a>
|
|
and <a href=unquoted>unquoted</a> events, as well as a <a href=\'single quote\'>single quote</a> from
|
|
his <a href="/father">father</a>.
|
|
</p>
|
|
|
|
<p>
|
|
There were also some elements with extra <a class=attribute href=\'attributes\'>attributes</a> which
|
|
played a part in his <a href=journey"extra id="JourneyLink">journey</a>. HE ALSO DISCOVERED THE
|
|
<A HREF="CAPS LOCK">KEY</a>. Later he got his <a href="quotes \'mixed\' up">mixed up</a>.
|
|
</p>
|
|
';
|
|
|
|
$expected = array (
|
|
'/', 'home/', 'mother/', '$Journey', 'space travel', 'unquoted', 'single quote', '/father', 'attributes',
|
|
'journey', 'CAPS LOCK', 'quotes \'mixed\' up'
|
|
);
|
|
|
|
$result = HTTP::getLinksIn($content);
|
|
|
|
// Results don't neccesarily come out in the order they are in the $content param.
|
|
sort($result);
|
|
sort($expected);
|
|
|
|
$this->assertTrue(is_array($result));
|
|
$this->assertEquals($expected, $result, 'Test that all links within the content are found.');
|
|
}
|
|
|
|
/**
|
|
* Tests {@link HTTP::setGetVar()}
|
|
*/
|
|
public function testSetGetVar()
|
|
{
|
|
// Hackery to work around volatile URL formats in test invocation,
|
|
// and the inability of Director::absoluteBaseURL() to produce consistent URLs.
|
|
Director::mockRequest(function (HTTPRequest $request) {
|
|
$controller = new Controller();
|
|
$controller->setRequest($request);
|
|
$controller->pushCurrent();
|
|
try {
|
|
$this->assertContains(
|
|
'relative/url?foo=bar',
|
|
HTTP::setGetVar('foo', 'bar'),
|
|
'Omitting a URL falls back to current URL'
|
|
);
|
|
} finally {
|
|
$controller->popCurrent();
|
|
}
|
|
}, 'relative/url/');
|
|
|
|
$this->assertEquals(
|
|
'relative/url?foo=bar',
|
|
HTTP::setGetVar('foo', 'bar', 'relative/url'),
|
|
'Relative URL without existing query params'
|
|
);
|
|
|
|
$this->assertEquals(
|
|
'relative/url?baz=buz&foo=bar',
|
|
HTTP::setGetVar('foo', 'bar', '/relative/url?baz=buz'),
|
|
'Relative URL with existing query params, and new added key'
|
|
);
|
|
|
|
$this->assertEquals(
|
|
'http://test.com/?foo=new&buz=baz',
|
|
HTTP::setGetVar('foo', 'new', 'http://test.com/?foo=old&buz=baz'),
|
|
'Absolute URL without path and multipe existing query params, overwriting an existing parameter'
|
|
);
|
|
|
|
$this->assertContains(
|
|
'http://test.com/?foo=new',
|
|
HTTP::setGetVar('foo', 'new', 'http://test.com/?foo=&foo=old'),
|
|
'Absolute URL and empty query param'
|
|
);
|
|
// http_build_query() escapes angular brackets, they should be correctly urldecoded by the browser client
|
|
$this->assertEquals(
|
|
'http://test.com/?foo%5Btest%5D=one&foo%5Btest%5D=two',
|
|
HTTP::setGetVar('foo[test]', 'two', 'http://test.com/?foo[test]=one'),
|
|
'Absolute URL and PHP array query string notation'
|
|
);
|
|
|
|
$urls = array(
|
|
'http://www.test.com:8080',
|
|
'http://test.com:3000/',
|
|
'http://test.com:3030/baz/',
|
|
'http://baz:foo@test.com',
|
|
'http://baz@test.com/',
|
|
'http://baz:foo@test.com:8080',
|
|
'http://baz@test.com:8080'
|
|
);
|
|
|
|
foreach ($urls as $testURL) {
|
|
$this->assertEquals(
|
|
$testURL .'?foo=bar',
|
|
HTTP::setGetVar('foo', 'bar', $testURL),
|
|
'Absolute URL and Port Number'
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Test that the the get_mime_type() works correctly
|
|
*/
|
|
public function testGetMimeType()
|
|
{
|
|
$this->assertEquals('text/plain', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.csv'));
|
|
$this->assertEquals('image/gif', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.gif'));
|
|
$this->assertEquals('text/html', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.html'));
|
|
$this->assertEquals('image/jpeg', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.jpg'));
|
|
$this->assertEquals('image/png', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.png'));
|
|
$this->assertEquals(
|
|
'image/vnd.adobe.photoshop',
|
|
HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.psd')
|
|
);
|
|
$this->assertEquals('audio/x-wav', HTTP::get_mime_type(FRAMEWORK_DIR.'/tests/control/files/file.wav'));
|
|
}
|
|
|
|
/**
|
|
* Test that absoluteURLs correctly transforms urls within CSS to absolute
|
|
*/
|
|
public function testAbsoluteURLsCSS()
|
|
{
|
|
$this->withBaseURL(
|
|
'http://www.silverstripe.org/',
|
|
function () {
|
|
|
|
// background-image
|
|
// Note that using /./ in urls is absolutely acceptable
|
|
$this->assertEquals(
|
|
'<div style="background-image: url(\'http://www.silverstripe.org/./images/mybackground.gif\');">'.
|
|
'Content</div>',
|
|
HTTP::absoluteURLs('<div style="background-image: url(\'./images/mybackground.gif\');">Content</div>')
|
|
);
|
|
|
|
// background
|
|
$this->assertEquals(
|
|
'<div style="background: url(\'http://www.silverstripe.org/images/mybackground.gif\');">Content</div>',
|
|
HTTP::absoluteURLs('<div style="background: url(\'images/mybackground.gif\');">Content</div>')
|
|
);
|
|
|
|
// list-style-image
|
|
$this->assertEquals(
|
|
'<div style=\'background: url(http://www.silverstripe.org/list.png);\'>Content</div>',
|
|
HTTP::absoluteURLs('<div style=\'background: url(list.png);\'>Content</div>')
|
|
);
|
|
|
|
// list-style
|
|
$this->assertEquals(
|
|
'<div style=\'background: url("http://www.silverstripe.org/./assets/list.png");\'>Content</div>',
|
|
HTTP::absoluteURLs('<div style=\'background: url("./assets/list.png");\'>Content</div>')
|
|
);
|
|
}
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test that absoluteURLs correctly transforms urls within html attributes to absolute
|
|
*/
|
|
public function testAbsoluteURLsAttributes()
|
|
{
|
|
$this->withBaseURL(
|
|
'http://www.silverstripe.org/',
|
|
function () {
|
|
//empty links
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/">test</a>',
|
|
HTTP::absoluteURLs('<a href="">test</a>')
|
|
);
|
|
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/">test</a>',
|
|
HTTP::absoluteURLs('<a href="/">test</a>')
|
|
);
|
|
|
|
//relative
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/">test</a>',
|
|
HTTP::absoluteURLs('<a href="./">test</a>')
|
|
);
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/">test</a>',
|
|
HTTP::absoluteURLs('<a href=".">test</a>')
|
|
);
|
|
|
|
// links
|
|
$this->assertEquals(
|
|
'<a href=\'http://www.silverstripe.org/blog/\'>SS Blog</a>',
|
|
HTTP::absoluteURLs('<a href=\'/blog/\'>SS Blog</a>')
|
|
);
|
|
|
|
// background
|
|
// Note that using /./ in urls is absolutely acceptable
|
|
$this->assertEquals(
|
|
'<div background="http://www.silverstripe.org/./themes/silverstripe/images/nav-bg-repeat-2.png">'.
|
|
'SS Blog</div>',
|
|
HTTP::absoluteURLs('<div background="./themes/silverstripe/images/nav-bg-repeat-2.png">SS Blog</div>')
|
|
);
|
|
|
|
//check dot segments
|
|
// Assumption: dots are not removed
|
|
//if they were, the url should be: http://www.silverstripe.org/abc
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/test/page/../../abc">Test</a>',
|
|
HTTP::absoluteURLs('<a href="test/page/../../abc">Test</a>')
|
|
);
|
|
|
|
// image
|
|
$this->assertEquals(
|
|
'<img src=\'http://www.silverstripe.org/themes/silverstripe/images/logo-org.png\' />',
|
|
HTTP::absoluteURLs('<img src=\'themes/silverstripe/images/logo-org.png\' />')
|
|
);
|
|
|
|
// link
|
|
$this->assertEquals(
|
|
'<link href=http://www.silverstripe.org/base.css />',
|
|
HTTP::absoluteURLs('<link href=base.css />')
|
|
);
|
|
|
|
// Test special characters are retained
|
|
$this->assertEquals(
|
|
'<a href="http://www.silverstripe.org/Security/changepassword?m=3&t=7214fdfde">password reset link</a>',
|
|
HTTP::absoluteURLs('<a href="/Security/changepassword?m=3&t=7214fdfde">password reset link</a>')
|
|
);
|
|
}
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Make sure URI schemes are not rewritten
|
|
*/
|
|
public function testURISchemes()
|
|
{
|
|
$this->withBaseURL(
|
|
'http://www.silverstripe.org/',
|
|
function ($test) {
|
|
|
|
// mailto
|
|
$this->assertEquals(
|
|
'<a href=\'mailto:admin@silverstripe.org\'>Email Us</a>',
|
|
HTTP::absoluteURLs('<a href=\'mailto:admin@silverstripe.org\'>Email Us</a>'),
|
|
'Email links are not rewritten'
|
|
);
|
|
|
|
// data uri
|
|
$this->assertEquals(
|
|
'<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38'.
|
|
'GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==" alt="Red dot" />',
|
|
HTTP::absoluteURLs(
|
|
'<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAH'.
|
|
'ElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==" alt="Red dot" />'
|
|
),
|
|
'Data URI links are not rewritten'
|
|
);
|
|
|
|
// call
|
|
$this->assertEquals(
|
|
'<a href="callto:12345678" />',
|
|
HTTP::absoluteURLs('<a href="callto:12345678" />'),
|
|
'Call to links are not rewritten'
|
|
);
|
|
}
|
|
);
|
|
}
|
|
|
|
public function testFilename2url()
|
|
{
|
|
$this->withBaseURL(
|
|
'http://www.silverstripe.org/',
|
|
function ($test) {
|
|
$frameworkTests = ltrim(FRAMEWORK_DIR . '/tests', '/');
|
|
$this->assertEquals(
|
|
"http://www.silverstripe.org/$frameworkTests/php/Control/HTTPTest.php",
|
|
HTTP::filename2url(__FILE__)
|
|
);
|
|
}
|
|
);
|
|
}
|
|
}
|