mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-08-27 21:15:40 +02:00
1. Add missing _super calls. 2. Make UI widget destroys more consistent to avoid exceptions. Selectable would throw an exception in the GridField.js if destroy called from onunmatch - at that stage jQuery UI would have had called the destroy already. Add a guard, and change to onremove, which triggers before the element is removed from DOM. 3. DOM traversal fails after the element is removed from DOM. Onunmatch triggers after the removal of the element from the DOM, which makes DOM traversal fail. Use onremove instead, which triggers while the element is still in DOM.
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
(function($) {
|
|
$.entwine('ss', function($) {
|
|
/**
|
|
* Converts an inline field description into a tooltip
|
|
* which is shown on hover over any part of the field container,
|
|
* as well as when focusing into an input element within the field container.
|
|
*
|
|
* Note that some fields don't have distinct focusable
|
|
* input fields (e.g. GridField), and aren't compatible
|
|
* with showing tooltips.
|
|
*/
|
|
$(".cms .field.cms-description-tooltip").entwine({
|
|
onmatch: function() {
|
|
this._super();
|
|
|
|
var descriptionEl = this.find('.description'), inputEl, tooltipEl;
|
|
if(descriptionEl.length) {
|
|
this
|
|
// TODO Remove title setting, shouldn't be necessary
|
|
.attr('title', descriptionEl.text())
|
|
.tooltip({content: descriptionEl.html()});
|
|
descriptionEl.remove();
|
|
}
|
|
},
|
|
});
|
|
|
|
$(".cms .field.cms-description-tooltip :input").entwine({
|
|
onfocusin: function(e) {
|
|
this.closest('.field').tooltip('open');
|
|
},
|
|
onfocusout: function(e) {
|
|
this.closest('.field').tooltip('close');
|
|
}
|
|
});
|
|
|
|
});
|
|
}(jQuery));
|