silverstripe-framework/control
Marcus Nyeholt 82495f5a7e BUGFIX Versioned's constructor doesn't provide suitable defaults. Previously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through
CHANGE Given that Config::inst is an implementation of the singleton pattern itself, I've removed the extra call to singleton(). A side effect of this is that it gets around a possibly nasty circular reference with the dependency injector (which relies on the config object); in future, this dependency structure should really be structured from the DI directly.

MINOR Change singleton and strong_create to use dependency injector

BUGFIX: Provide default constructor values for classes (fixes issues when used in 'singleton' scenario during dev/build in particular)

MINOR Clear out injector state when resetting db schema during tests (a follow on from changing singleton() calls to use the injector underneath)
2012-05-23 21:10:04 +10:00
..
injector BUGFIX Versioned's constructor doesn't provide suitable defaults. Previously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through 2012-05-23 21:10:04 +10:00
ContentNegotiator.php MINOR Update @package values to match renaming sapphire 2012-04-15 10:50:19 +12:00
Controller.php Merge branch (pull request #247) 'template-global-fixes' of https://github.com/sminnee/sapphire into sminnee-template-global-fixes 2012-05-19 15:39:59 +12:00
Cookie.php MINOR Update @package values to match renaming sapphire 2012-04-15 10:50:19 +12:00
Director.php API CHANGE: Changes to make Director rules set through the new config system. Includes the addition of a new AdminRootController to take over handling of routing /admin/* routes to the correct LeftAndMain panel. 2012-05-19 14:37:32 +12:00
HTTP.php BUGFIX Ensure HTTP::get_mime_type() checks the full path in 2012-05-18 09:22:02 +12:00
HTTPRequest.php BUGFIX Less strict checks for relative URL normalization in SS_HTTPRequest (regression from recent security fixes to Director::is_absolute_url()) (fixes #7359) 2012-05-20 11:16:34 +02:00
HTTPResponse.php MINOR Removed mbstring support checks, its an installation requirement 2012-05-08 15:32:15 +02:00
NullHTTPRequest.php MINOR Update @package values to match renaming sapphire 2012-04-15 10:50:19 +12:00
PjaxResponseNegotiator.php MINOR Add newline to end of files without one 2012-04-15 10:50:19 +12:00
RequestFilter.php FEATURE: Added dependency injector for managing creation of new objects and their dependencies. 2012-05-18 12:39:57 +12:00
RequestHandler.php API CHANGE Renamed setModel for DataModel instances to setDataModel for 2012-05-01 14:45:44 +12:00
RequestProcessor.php FEATURE: Added dependency injector for managing creation of new objects and their dependencies. 2012-05-18 12:39:57 +12:00
Session.php ENHANCEMENT Session::start() now only called when there is changed 2012-04-27 16:28:46 +12:00