mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-09-02 07:48:00 +02:00
See https://github.com/silverstripe/silverstripe-framework/pull/7037 and https://github.com/silverstripe/silverstripe-framework/issues/6681 Squashed commit of the following: commit8f65e56532
Author: Ingo Schommer <me@chillu.com> Date: Thu Jun 22 22:25:50 2017 +1200 Fixed upgrade guide spelling commit76f95944fa
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 16:38:34 2017 +1200 BUG Fix non-test class manifest including sapphiretest / functionaltest commit9379834cb4
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:50:47 2017 +1200 BUG Fix nesting bug in Kernel commit188ce35d82
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:14:51 2017 +1200 BUG fix db bootstrapping issues commit7ed4660e7a
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 14:49:07 2017 +1200 BUG Fix issue in DetailedErrorFormatter commit738f50c497
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:49:19 2017 +1200 Upgrading notes on mysite/_config.php commit6279d28e5e
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:43:28 2017 +1200 Update developer documentation commit5c90d53a84
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 10:48:44 2017 +1200 Update installer to not use global databaseConfig commitf9b2ba4755
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 21:04:39 2017 +1200 Fix behat issues commit5b59a912b6
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 17:07:11 2017 +1200 Move HTTPApplication to SilverStripe\Control namespace commite2c4a18f63
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 16:29:03 2017 +1200 More documentation Fix up remaining tests Refactor temp DB into TempDatabase class so it’s available outside of unit tests. commit5d235e64f3
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 12:13:15 2017 +1200 API HTTPRequestBuilder::createFromEnvironment() now cleans up live globals BUG Fix issue with SSViewer Fix Security / View tests commitd88d4ed4e4
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:39:43 2017 +1200 API Refactor AppKernel into CoreKernel commitf7946aec33
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:00:40 2017 +1200 Docs and minor cleanup commit12bd31f936
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 15:34:34 2017 +1200 API Remove OutputMiddleware API Move environment / global / ini management into Environment class API Move getTempFolder into TempFolder class API Implement HTTPRequestBuilder / CLIRequestBuilder BUG Restore SS_ALLOWED_HOSTS check in original location API CoreKernel now requires $basePath to be passed in API Refactor installer.php to use application to bootstrap API move memstring conversion globals to Convert BUG Fix error in CoreKernel nesting not un-nesting itself properly. commitbba9791146
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 18:07:53 2017 +1200 API Create HTTPMiddleware and standardise middleware for request handling commit2a10c2397b
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:42:42 2017 +1200 Fixed ORM tests commitd75a8d1d93
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:15:07 2017 +1200 FIx i18n tests commit06364af3c3
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 16:59:34 2017 +1200 Fix controller namespace Move states to sub namespace commit2a278e2953
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 12:49:45 2017 +1200 Fix forms namespace commitb65c21241b
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:56:48 2017 +1200 Update API usages commitd1d4375c95
Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:41:44 2017 +1200 API Refactor $flush into HTPPApplication API Enforce health check in Controller::pushCurrent() API Better global backup / restore Updated Director::test() to use new API commitb220534f06
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 22:05:57 2017 +1200 Move app nesting to a test state helper commit603704165c
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 21:46:04 2017 +1200 Restore kernel stack to fix multi-level nesting commit2f6336a15b
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 17:23:21 2017 +1200 API Implement kernel nesting commitfc7188da7d
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:43:13 2017 +1200 Fix core tests commita0ae723514
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:23:52 2017 +1200 Fix manifest tests commitca03395251
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:00:00 2017 +1200 API Move extension management into test state commitc66d433977
Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 14:10:59 2017 +1200 API Refactor SapphireTest state management into SapphireTestState API Remove Injector::unregisterAllObjects() API Remove FakeController commitf26ae75c6e
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 18:04:34 2017 +1200 Implement basic CLI application object commit001d559662
Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 17:39:38 2017 +1200 Remove references to SapphireTest::is_running_test() Upgrade various code commitde079c041d
Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 7 18:07:33 2017 +1200 API Implement APP object API Refactor of Session
393 lines
13 KiB
PHP
393 lines
13 KiB
PHP
<?php
|
|
|
|
namespace SilverStripe\Forms\Tests;
|
|
|
|
use SilverStripe\Forms\Tests\CheckboxSetFieldTest\Article;
|
|
use SilverStripe\Forms\Tests\CheckboxSetFieldTest\Tag;
|
|
use SilverStripe\ORM\ArrayList;
|
|
use SilverStripe\ORM\DataObject;
|
|
use SilverStripe\ORM\DB;
|
|
use SilverStripe\Security\Member;
|
|
use SilverStripe\ORM\FieldType\DBField;
|
|
use SilverStripe\Dev\CSSContentParser;
|
|
use SilverStripe\Dev\SapphireTest;
|
|
use SilverStripe\Control\Controller;
|
|
use SilverStripe\Forms\CheckboxSetField;
|
|
use SilverStripe\Forms\FieldList;
|
|
use SilverStripe\Forms\Form;
|
|
use SilverStripe\Forms\RequiredFields;
|
|
use SilverStripe\View\ArrayData;
|
|
|
|
class CheckboxSetFieldTest extends SapphireTest
|
|
{
|
|
|
|
protected static $fixture_file = 'CheckboxSetFieldTest.yml';
|
|
|
|
protected static $extra_dataobjects = array(
|
|
Article::class,
|
|
Tag::class,
|
|
);
|
|
|
|
public function testSetDefaultItems()
|
|
{
|
|
$f = new CheckboxSetField(
|
|
'Test',
|
|
false,
|
|
array(0 => 'Zero', 1 => 'One', 2 => 'Two', 3 => 'Three')
|
|
);
|
|
|
|
$f->setValue(array(0,1));
|
|
$f->setDefaultItems(array(2));
|
|
$p = new CSSContentParser($f->Field());
|
|
$item0 = $p->getBySelector('#Test_0');
|
|
$item1 = $p->getBySelector('#Test_1');
|
|
$item2 = $p->getBySelector('#Test_2');
|
|
$item3 = $p->getBySelector('#Test_3');
|
|
$this->assertEquals(
|
|
(string)$item0[0]['checked'],
|
|
'checked',
|
|
'Selected through value'
|
|
);
|
|
$this->assertEquals(
|
|
(string)$item1[0]['checked'],
|
|
'checked',
|
|
'Selected through value'
|
|
);
|
|
$this->assertEquals(
|
|
(string)$item2[0]['checked'],
|
|
'checked',
|
|
'Selected through default items'
|
|
);
|
|
$this->assertEquals(
|
|
(string)$item3[0]['checked'],
|
|
'',
|
|
'Not selected by either value or default items'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test different data sources
|
|
*/
|
|
public function testSources()
|
|
{
|
|
// Array
|
|
$items = array('a' => 'Apple', 'b' => 'Banana', 'c' => 'Cranberry');
|
|
$field = new CheckboxSetField('Field', null, $items);
|
|
$this->assertEquals($items, $field->getSource());
|
|
|
|
// SS_List
|
|
$list = new ArrayList(
|
|
array(
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'a',
|
|
'Title' => 'Apple'
|
|
)
|
|
),
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'b',
|
|
'Title' => 'Banana'
|
|
)
|
|
),
|
|
new ArrayData(
|
|
array(
|
|
'ID' => 'c',
|
|
'Title' => 'Cranberry'
|
|
)
|
|
)
|
|
)
|
|
);
|
|
$field2 = new CheckboxSetField('Field', null, $list);
|
|
$this->assertEquals($items, $field2->getSource());
|
|
|
|
$field3 = new CheckboxSetField('Field', null, $list->map());
|
|
$this->assertEquals($items, $field3->getSource());
|
|
}
|
|
|
|
public function testSaveWithNothingSelected()
|
|
{
|
|
$article = $this->objFromFixture(Article::class, 'articlewithouttags');
|
|
|
|
/* Create a CheckboxSetField with nothing selected */
|
|
$field = new CheckboxSetField("Tags", "Test field", DataObject::get(Tag::class)->map());
|
|
|
|
/* Saving should work */
|
|
$field->saveInto($article);
|
|
|
|
$this->assertNull(
|
|
DB::prepared_query(
|
|
"SELECT *
|
|
FROM \"CheckboxSetFieldTest_Article_Tags\"
|
|
WHERE \"CheckboxSetFieldTest_Article_Tags\".\"CheckboxSetFieldTest_ArticleID\" = ?",
|
|
array($article->ID)
|
|
)->value(),
|
|
'Nothing should go into manymany join table for a saved field without any ticked boxes'
|
|
);
|
|
}
|
|
|
|
public function testSaveWithArrayValueSet()
|
|
{
|
|
$article = $this->objFromFixture(Article::class, 'articlewithouttags');
|
|
$articleWithTags = $this->objFromFixture(Article::class, 'articlewithtags');
|
|
$tag1 = $this->objFromFixture(Tag::class, 'tag1');
|
|
$tag2 = $this->objFromFixture(Tag::class, 'tag2');
|
|
|
|
/* Create a CheckboxSetField with 2 items selected. Note that the array is a list of values */
|
|
$field = new CheckboxSetField("Tags", "Test field", DataObject::get(Tag::class)->map());
|
|
$field->setValue(
|
|
array(
|
|
$tag1->ID,
|
|
$tag2->ID
|
|
)
|
|
);
|
|
|
|
/* Saving should work */
|
|
$field->saveInto($article);
|
|
|
|
$this->assertEquals(
|
|
array($tag1->ID,$tag2->ID),
|
|
DB::prepared_query(
|
|
"SELECT \"CheckboxSetFieldTest_TagID\"
|
|
FROM \"CheckboxSetFieldTest_Article_Tags\"
|
|
WHERE \"CheckboxSetFieldTest_Article_Tags\".\"CheckboxSetFieldTest_ArticleID\" = ?",
|
|
array($article->ID)
|
|
)->column(),
|
|
'Data shold be saved into CheckboxSetField manymany relation table on the "right end"'
|
|
);
|
|
$this->assertEquals(
|
|
array($articleWithTags->ID,$article->ID),
|
|
DB::query(
|
|
"SELECT \"CheckboxSetFieldTest_ArticleID\"
|
|
FROM \"CheckboxSetFieldTest_Article_Tags\"
|
|
WHERE \"CheckboxSetFieldTest_Article_Tags\".\"CheckboxSetFieldTest_TagID\" = $tag1->ID
|
|
"
|
|
)->column(),
|
|
'Data shold be saved into CheckboxSetField manymany relation table on the "left end"'
|
|
);
|
|
}
|
|
|
|
public function testLoadDataFromObject()
|
|
{
|
|
$articleWithTags = $this->objFromFixture(Article::class, 'articlewithtags');
|
|
$tag1 = $this->objFromFixture(Tag::class, 'tag1');
|
|
$tag2 = $this->objFromFixture(Tag::class, 'tag2');
|
|
|
|
$field = new CheckboxSetField("Tags", "Test field", DataObject::get(Tag::class)->map());
|
|
/** @skipUpgrade */
|
|
$form = new Form(
|
|
Controller::curr(),
|
|
'Form',
|
|
new FieldList($field),
|
|
new FieldList()
|
|
);
|
|
$form->loadDataFrom($articleWithTags);
|
|
$value = $field->Value();
|
|
sort($value);
|
|
$this->assertEquals(
|
|
array(
|
|
$tag1->ID,
|
|
$tag2->ID
|
|
),
|
|
$value,
|
|
'CheckboxSetField loads data from a manymany relationship in an object through Form->loadDataFrom()'
|
|
);
|
|
}
|
|
|
|
public function testSavingIntoTextField()
|
|
{
|
|
$field = new CheckboxSetField(
|
|
'Content',
|
|
'Content',
|
|
array(
|
|
'Test' => 'Test',
|
|
'Another' => 'Another',
|
|
'Something' => 'Something'
|
|
)
|
|
);
|
|
$article = new CheckboxSetFieldTest\Article();
|
|
$field->setValue(array('Test' => 'Test', 'Another' => 'Another'));
|
|
$field->saveInto($article);
|
|
$article->write();
|
|
|
|
$dbValue = DB::query(
|
|
sprintf(
|
|
'SELECT "Content" FROM "CheckboxSetFieldTest_Article" WHERE "ID" = %s',
|
|
$article->ID
|
|
)
|
|
)->value();
|
|
|
|
// JSON encoded values
|
|
$this->assertEquals('["Test","Another"]', $dbValue);
|
|
}
|
|
|
|
public function testValidationWithArray()
|
|
{
|
|
// Test with array input
|
|
$field = CheckboxSetField::create(
|
|
'Test',
|
|
'Testing',
|
|
array(
|
|
"One" => "One",
|
|
"Two" => "Two",
|
|
"Three" => "Three"
|
|
)
|
|
);
|
|
$validator = new RequiredFields();
|
|
$field->setValue(array("One", "Two"));
|
|
$this->assertTrue(
|
|
$field->validate($validator),
|
|
'Field validates values within source array'
|
|
);
|
|
|
|
// Non valid value should fail
|
|
$field->setValue(array("Four" => "Four"));
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not validate values outside of source array'
|
|
);
|
|
|
|
// Non valid value, even if included with valid options, should fail
|
|
$field->setValue(array("One", "Two", "Four"));
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not validate when presented with mixed valid and invalid values'
|
|
);
|
|
}
|
|
|
|
public function testValidationWithDataList()
|
|
{
|
|
//test with datalist input
|
|
$checkboxTestArticle = $this->objFromFixture(Article::class, 'articlewithtags');
|
|
$tag1 = $this->objFromFixture(Tag::class, 'tag1');
|
|
$tag2 = $this->objFromFixture(Tag::class, 'tag2');
|
|
$tag3 = $this->objFromFixture(Tag::class, 'tag3');
|
|
$field = CheckboxSetField::create('Test', 'Testing', $checkboxTestArticle->Tags());
|
|
$validator = new RequiredFields();
|
|
$field->setValue(array( $tag1->ID, $tag2->ID ));
|
|
$isValid = $field->validate($validator);
|
|
$this->assertTrue(
|
|
$isValid,
|
|
'Validates values in source map'
|
|
);
|
|
|
|
// Invalid value should fail
|
|
$validator = new RequiredFields();
|
|
$fakeID = CheckboxSetFieldTest\Tag::get()->max('ID') + 1;
|
|
$field->setValue(array($fakeID));
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not valid values outside of source map'
|
|
);
|
|
$errors = $validator->getErrors();
|
|
$error = reset($errors);
|
|
$this->assertEquals(
|
|
_t(
|
|
'SilverStripe\\Forms\\MultiSelectField.SOURCE_VALIDATION',
|
|
"Please select values within the list provided. Invalid option(s) {value} given",
|
|
array('value' => $fakeID)
|
|
),
|
|
$error['message']
|
|
);
|
|
|
|
// Multiple invalid values should fail
|
|
$validator = new RequiredFields();
|
|
$fakeID = Tag::get()->max('ID') + 1;
|
|
$field->setValue(array($fakeID, $tag3->ID));
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not valid values outside of source map'
|
|
);
|
|
$errors = $validator->getErrors();
|
|
$error = reset($errors);
|
|
$this->assertEquals(
|
|
_t(
|
|
'SilverStripe\\Forms\\MultiSelectField.SOURCE_VALIDATION',
|
|
"Please select values within the list provided. Invalid option(s) {value} given",
|
|
array('value' => implode(',', [$fakeID, $tag3->ID]))
|
|
),
|
|
$error['message']
|
|
);
|
|
|
|
// Invalid value with non-array value
|
|
$validator = new RequiredFields();
|
|
$field->setValue($fakeID);
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not valid values outside of source map'
|
|
);
|
|
$errors = $validator->getErrors();
|
|
$error = reset($errors);
|
|
$this->assertEquals(
|
|
_t(
|
|
'SilverStripe\\Forms\\MultiSelectField.SOURCE_VALIDATION',
|
|
"Please select values within the list provided. Invalid option(s) {value} given",
|
|
array('value' => $fakeID)
|
|
),
|
|
$error['message']
|
|
);
|
|
|
|
//non valid value included with valid options should succeed
|
|
$validator = new RequiredFields();
|
|
$field->setValue(
|
|
array(
|
|
$tag1->ID,
|
|
$tag2->ID,
|
|
$tag3->ID
|
|
)
|
|
);
|
|
$this->assertFalse(
|
|
$field->validate($validator),
|
|
'Field does not validate when presented with mixed valid and invalid values'
|
|
);
|
|
}
|
|
|
|
public function testSafelyCast()
|
|
{
|
|
$member = new Member();
|
|
$member->FirstName = '<firstname>';
|
|
$member->Surname = '<surname>';
|
|
$member->write();
|
|
$field1 = new CheckboxSetField(
|
|
'Options',
|
|
'Options',
|
|
array(
|
|
'one' => 'One',
|
|
'two' => 'Two & Three',
|
|
'three' => DBField::create_field('HTMLText', 'Four & Five & Six'),
|
|
'four' => $member->FirstName,
|
|
)
|
|
);
|
|
$fieldHTML = (string)$field1->Field();
|
|
$this->assertContains('One', $fieldHTML);
|
|
$this->assertContains('Two & Three', $fieldHTML);
|
|
$this->assertNotContains('Two & Three', $fieldHTML);
|
|
$this->assertContains('Four & Five & Six', $fieldHTML);
|
|
$this->assertNotContains('Four & Five & Six', $fieldHTML);
|
|
$this->assertContains('<firstname>', $fieldHTML);
|
|
$this->assertNotContains('<firstname>', $fieldHTML);
|
|
}
|
|
|
|
/**
|
|
* #2939 CheckboxSetField creates invalid HTML when required
|
|
*/
|
|
public function testNoAriaRequired()
|
|
{
|
|
$field = new CheckboxSetField('RequiredField', 'myRequiredField');
|
|
|
|
$form = new Form(
|
|
Controller::curr(),
|
|
"form",
|
|
new FieldList($field),
|
|
new FieldList(),
|
|
new RequiredFields(["RequiredField"])
|
|
);
|
|
$this->assertTrue($field->Required());
|
|
|
|
$attributes = $field->getAttributes();
|
|
$this->assertFalse(array_key_exists("aria-required", $attributes));
|
|
$this->assertFalse(array_key_exists("name", $attributes));
|
|
$this->assertFalse(array_key_exists("required", $attributes));
|
|
}
|
|
}
|