silverstripe-framework/tests
Stig Lindqvist 333a2aa8f9 BUG: CMS tree filters doesn't count the correct number of children for deleted pages
This is a bug that combines Hierarchy, Versioned and LeftAndMain admins and CMSSiteTreeFilters.

This bug can be reproduced by having a large site tree with enough deleted pages in it so it doesn't
pre load all the children pages when initially opening an admin. Filter by either 'All pages including deleted'
or 'Deleted pages'. For CMS users it will look like deleted pages are gone.

The solution involves a couple of smaller fixes in both CMS and framework modules.

1) Ensure that 'numHistoricalChildren' are used instead of 'numChildren' when dealing with deleted pages
2) LeftAndMain::currentPage() deletes all the 'marking' cache previously built up by Hierarchy::markPartialTree()
3) Use Versioned::get_included_deleted() instead of raw DB queries against the DataObject tables when calculating parents in CMSSiteTreeFilter
2014-07-25 16:19:30 +12:00
..
api Better support for overloading start and destroy methods in Session 2014-06-20 10:35:53 +12:00
assets FIX extra_requirements to accept non associative arrays. 2013-06-02 13:37:34 +12:00
behat Merge pull request #3207 from chillu/pulls/behat-gridfield 2014-06-17 13:43:33 +12:00
cache Make CacheTest sleep properly 2013-12-21 15:05:51 +13:00
control BUG using isDev or isTest query string no longer triggers basic auth 2014-07-02 11:51:51 +12:00
core Revert "BUG Config::merge_array_low_into_high() ignores falsey values" 2014-07-09 09:57:25 +12:00
dev Adding some more commonly used SS_Log priority constants. 2014-06-23 11:50:05 +12:00
email Unit tests for Email 2013-10-09 11:51:29 +01:00
filesystem FIX folder Title not being exactly the same as Name field if setName modified the value 2014-05-02 14:41:10 +12:00
forms Merge pull request #2967 from halkyon/formfield_readonly 2014-06-17 14:48:56 +12:00
i18n BUG Default Member.Locale now chooses a better default value when i18n.locale is not a valid translation 2014-01-30 15:55:14 +13:00
injector BUG fix dependency injection stumbling over ViewableData's __isset 2014-06-12 10:08:59 +12:00
integration FIX We still need XML escaping on href attributes in HTML4Value 2013-04-18 09:13:24 +12:00
javascript Add codesniffer that ensures indentation is with tabs. 2012-12-12 17:33:31 +13:00
model BUG: CMS tree filters doesn't count the correct number of children for deleted pages 2014-07-25 16:19:30 +12:00
oembed FIX oembed to avoid mixed media issues 2013-10-17 17:06:40 +13:00
parsers API: Pass extra context information to shortcode handlers. 2013-10-09 15:05:17 +11:00
phpcs Add code-sniffs other than line length to scrutinizer 2013-05-23 10:39:01 +12:00
search FulltextSearchableTest doesn't clean up after itself. 2013-10-22 17:52:51 +13:00
security API Security.remember_username to disable login form autocompletion 2014-04-11 09:05:25 +12:00
tasks Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
templates FEATURE: <% include %> inherits iterator scope of parent template 2013-07-07 12:39:42 +00:00
testing API Marked statics private, use Config API instead (#8317) 2013-03-24 17:20:53 +01:00
view Correct errors from differening behaviour between 3.0 and 3.1 2014-03-30 19:29:18 +13:00
Bare.yml MINOR: Added small fixture YML that just lets you log in, for bootstrapping browser automation tests. 2011-02-02 14:17:57 +13:00
bootstrap.php Setting SapphireTest::is_running_test() in PHPUnit bootstrap 2013-01-09 23:31:10 +01:00
FakeController.php Better support for overloading start and destroy methods in Session 2014-06-20 10:35:53 +12:00
MemoryLimitTest.php Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
phpcs_runner.php Only have Scrutinizer check PHP files 2013-08-21 21:02:12 +12:00
PhpSyntaxTest.php FIX Remove instances of lines longer than 120c 2012-09-30 17:18:13 +13:00