silverstripe-framework/model
Stig Lindqvist 333a2aa8f9 BUG: CMS tree filters doesn't count the correct number of children for deleted pages
This is a bug that combines Hierarchy, Versioned and LeftAndMain admins and CMSSiteTreeFilters.

This bug can be reproduced by having a large site tree with enough deleted pages in it so it doesn't
pre load all the children pages when initially opening an admin. Filter by either 'All pages including deleted'
or 'Deleted pages'. For CMS users it will look like deleted pages are gone.

The solution involves a couple of smaller fixes in both CMS and framework modules.

1) Ensure that 'numHistoricalChildren' are used instead of 'numChildren' when dealing with deleted pages
2) LeftAndMain::currentPage() deletes all the 'marking' cache previously built up by Hierarchy::markPartialTree()
3) Use Versioned::get_included_deleted() instead of raw DB queries against the DataObject tables when calculating parents in CMSSiteTreeFilter
2014-07-25 16:19:30 +12:00
..
fieldtypes FIX Add support for compositedbfield within many_many_extraFields 2014-06-28 10:54:48 +12:00
Aggregate.php Skip tags in Zend_Cache for Aggregate if not available 2014-03-16 11:54:00 +13:00
ArrayList.php BUG ArrayList failing to respect the SS_Sortable interface 2014-05-15 14:25:23 +12:00
Database.php Rewrote usages of error suppression operator 2014-03-05 15:48:55 +13:00
DatabaseAdmin.php API Marked statics private, use Config API instead (#8317) 2013-03-24 17:20:53 +01:00
DataDifferencer.php Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
DataExtension.php Revert "FIX make augmentSQL API consistent for strict PHP" 2013-06-01 11:51:01 +12:00
DataList.php FIX Docs for DataList::filter() 2014-04-25 10:13:04 +01:00
DataModel.php Update @package, @subpackage labels 2013-05-21 22:24:41 +12:00
DataObject.php Merge pull request #2917 from tractorcow/pulls/fix-lazyload-queryparams 2014-03-15 21:45:42 +13:00
DataObjectInterface.php Removing deprecated instance_get_one() and instance_get() 2012-11-15 14:43:19 +13:00
DataQuery.php BUG Fix data query not always joining necessary tables 2014-05-06 12:22:46 +12:00
DB.php Allow DB::connect() to specify the connection name. 2014-03-17 21:46:40 +13:00
Filterable.php Merge branch 'pulls/apidocs-package-list' of https://github.com/madmatt/silverstripe-framework into madmatt-pulls/apidocs-package-list 2014-01-31 15:15:59 +13:00
GroupedList.php Correct line length and indentation 2014-03-30 21:11:56 +13:00
HasManyList.php BUG Fixes issue where items could be deleted from a has_many relation by an entirely unrelated HasManyList calling delete on that item. 2013-11-01 11:39:13 +13:00
HiddenClass.php MINOR Update @package values to match renaming sapphire 2012-04-15 10:50:19 +12:00
Hierarchy.php BUG: CMS tree filters doesn't count the correct number of children for deleted pages 2014-07-25 16:19:30 +12:00
HTMLValue.php Rewrote usages of error suppression operator 2014-03-05 15:48:55 +13:00
Image_Backend.php API Marked statics private, use Config API instead (#8317) 2013-03-24 17:20:53 +01:00
Image.php FEATURE allow force resampling on images 2014-07-05 14:29:01 +12:00
Limitable.php Updating @package and @subpackage doc tags 2013-11-29 17:49:30 +13:00
List.php NEW: Add new method "each" to SS_List and core implementors thereof 2012-11-02 18:21:02 -07:00
ListDecorator.php added filterByCallback() to interface SS_Filterable and all implementing classes 2013-11-21 13:03:18 +00:00
ManyManyList.php FIX Add support for compositedbfield within many_many_extraFields 2014-06-28 10:54:48 +12:00
Map.php API: Implement SS_Map::push() to append values. 2013-11-18 20:38:57 +13:00
MySQLDatabase.php Close the mysqli connection when deleting the class. 2014-03-17 21:46:47 +13:00
MySQLQuery.php Separate out SS_Query and MySQLQuery from their Database classes 2013-11-28 11:55:25 +13:00
Query.php Fixing SQLQueryTest failures on PHPUnit 3.7.30 2014-02-10 13:32:39 +13:00
RelationList.php Update @package, @subpackage labels 2013-05-21 22:24:41 +12:00
Sortable.php Updating @package and @subpackage doc tags 2013-11-29 17:49:30 +13:00
SQLMap.php Scoped deprecation messages (fixes #7645) 2012-07-13 11:37:35 +02:00
SQLQuery.php BUG #3282: Added ability to subselect with in left or inner join 2014-07-17 13:27:28 +12:00
Transliterator.php cs_CZ transliteration chars (fixes #2816) 2014-02-07 17:43:41 +13:00
UnsavedRelationList.php Merge pull request #1992 from jthomerson/fix_unsaved_relation_list_constructor 2013-05-24 15:19:19 -07:00
URLSegmentFilter.php Remove trailing dashes from URLSegment 2014-03-03 22:22:03 +00:00
ValidationException.php BUG Enforced requirement that ValidationException::getResult() is expected to consistently produce a valid ValidationResult object. 2013-03-15 13:56:43 +13:00
ValidationResult.php NEW: Made ValidationResult functions chain-able. 2014-01-09 16:32:27 +13:00
Versioned.php Versioned no longer sets redundant session data 2014-06-11 16:42:22 +12:00