mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 12:05:37 +00:00
Ingo Schommer
1ec2abe75f
Fixed timezone and normalised ISO handling
A few observations: - ISO says “T” is optional (https://en.wikipedia.org/wiki/ISO_8601#cite_note-21), - WHATWG says in the HTML5 spec that it’s optional (https://html.spec.whatwg.org/multipage/infrastructure.html#local-dates-and-times) - W3C says it’s reqiured in 1997 (https://www.w3.org/TR/NOTE-datetime), but then later says it’s optional in its HTML5 spec (https://www.w3.org/TR/html5/infrastructure.html#floating-dates-and-times). - Chrome doesn’t parse values with whitespace separators (requires "T") - DataObject DBDatetime values and database columns use whitespace separators (and will have many devs relying on this format) - MySQL only supports whitespace separators (https://dev.mysql.com/doc/refman/5.7/en/datetime.html) - SQLite can parse both ways (https://sqlite.org/lang_datefunc.html) So the goal here is to retain ORM/database compatibility with 3.x (whitespace separator), while exposing "T" separators to the browser in HTML5 mode. Regarding timezones, this fixes a regression where setValue() would not actually apply the timezone (last $value assignment is ineffective now that sub fields are removed).
SilverStripe Framework
PHP5 framework forming the base for the SilverStripe CMS (http://silverstripe.org).
Requires a silverstripe-installer
base project. Typically used alongside the cms
module.
Installation
See installation on different platforms, and installation from source.
Bugtracker
Bugs are tracked on github.com. Please read our issue reporting guidelines.
Development and Contribution
If you would like to make changes to the SilverStripe core codebase, we have an extensive guide to contributing code.
Links
Description
Languages
PHP
99.4%
Scheme
0.5%