mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-08-29 05:55:52 +02:00
ba5984e2bf
If more than two $from were added through SQLQuery->addFrom(),
the getOrderedJoins() comparison kicks in. It assumes all $from
parts are in array notation, which isn't always the case.
For legacy reasons, and because we don't have full API support,
you can still add literal joins through addFrom('INNER JOIN ...').
On PHP 5.3, the ordering comparison still works because it
allows array access in strings, with string rather than numeric indexes.
Thankfully that's no longer supported in PHP 5.4.
522 lines
15 KiB
PHP
Executable File
522 lines
15 KiB
PHP
Executable File
<?php
|
|
|
|
class SQLQueryTest extends SapphireTest {
|
|
|
|
protected static $fixture_file = 'SQLQueryTest.yml';
|
|
|
|
protected $extraDataObjects = array(
|
|
'SQLQueryTest_DO',
|
|
);
|
|
|
|
public function testEmptyQueryReturnsNothing() {
|
|
$query = new SQLQuery();
|
|
$this->assertEquals('', $query->sql());
|
|
}
|
|
|
|
public function testSelectFromBasicTable() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('MyTable');
|
|
$this->assertEquals("SELECT * FROM MyTable", $query->sql());
|
|
$query->addFrom('MyJoin');
|
|
$this->assertEquals("SELECT * FROM MyTable MyJoin", $query->sql());
|
|
}
|
|
|
|
public function testSelectFromUserSpecifiedFields() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect(array("Name", "Title", "Description"));
|
|
$query->setFrom("MyTable");
|
|
$this->assertEquals("SELECT Name, Title, Description FROM MyTable", $query->sql());
|
|
}
|
|
|
|
public function testSelectWithWhereClauseFilter() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect(array("Name","Meta"));
|
|
$query->setFrom("MyTable");
|
|
$query->setWhere("Name = 'Name'");
|
|
$query->addWhere("Meta = 'Test'");
|
|
$this->assertEquals("SELECT Name, Meta FROM MyTable WHERE (Name = 'Name') AND (Meta = 'Test')", $query->sql());
|
|
}
|
|
|
|
public function testSelectWithConstructorParameters() {
|
|
$query = new SQLQuery(array("Foo", "Bar"), "FooBarTable");
|
|
$this->assertEquals("SELECT Foo, Bar FROM FooBarTable", $query->sql());
|
|
$query = new SQLQuery(array("Foo", "Bar"), "FooBarTable", array("Foo = 'Boo'"));
|
|
$this->assertEquals("SELECT Foo, Bar FROM FooBarTable WHERE (Foo = 'Boo')", $query->sql());
|
|
}
|
|
|
|
public function testSelectWithChainedMethods() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect("Name","Meta")->setFrom("MyTable")->setWhere("Name = 'Name'")->addWhere("Meta = 'Test'");
|
|
$this->assertEquals("SELECT Name, Meta FROM MyTable WHERE (Name = 'Name') AND (Meta = 'Test')", $query->sql());
|
|
}
|
|
|
|
public function testCanSortBy() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect("Name","Meta")->setFrom("MyTable")->setWhere("Name = 'Name'")->addWhere("Meta = 'Test'");
|
|
$this->assertTrue($query->canSortBy('Name ASC'));
|
|
$this->assertTrue($query->canSortBy('Name'));
|
|
}
|
|
|
|
public function testSelectWithChainedFilterParameters() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect(array("Name","Meta"))->setFrom("MyTable");
|
|
$query->setWhere("Name = 'Name'")->addWhere("Meta = 'Test'")->addWhere("Beta != 'Gamma'");
|
|
$this->assertEquals(
|
|
"SELECT Name, Meta FROM MyTable WHERE (Name = 'Name') AND (Meta = 'Test') AND (Beta != 'Gamma')",
|
|
$query->sql());
|
|
}
|
|
|
|
public function testSelectWithLimitClause() {
|
|
if(!(DB::getConn() instanceof MySQLDatabase || DB::getConn() instanceof SQLite3Database
|
|
|| DB::getConn() instanceof PostgreSQLDatabase)) {
|
|
$this->markTestIncomplete();
|
|
}
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setLimit(99);
|
|
$this->assertEquals("SELECT * FROM MyTable LIMIT 99", $query->sql());
|
|
|
|
// array limit with start (MySQL specific)
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setLimit(99, 97);
|
|
$this->assertEquals("SELECT * FROM MyTable LIMIT 99 OFFSET 97", $query->sql());
|
|
}
|
|
|
|
public function testSelectWithOrderbyClause() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('MyName');
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName ASC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('MyName desc');
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName DESC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('MyName ASC, Color DESC');
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName ASC, Color DESC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('MyName ASC, Color');
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName ASC, Color ASC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy(array('MyName' => 'desc'));
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName DESC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy(array('MyName' => 'desc', 'Color'));
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY MyName DESC, Color ASC', $query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('implode("MyName","Color")');
|
|
$this->assertEquals(
|
|
'SELECT *, implode("MyName","Color") AS "_SortColumn0" FROM MyTable ORDER BY "_SortColumn0" ASC',
|
|
$query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('implode("MyName","Color") DESC');
|
|
$this->assertEquals(
|
|
'SELECT *, implode("MyName","Color") AS "_SortColumn0" FROM MyTable ORDER BY "_SortColumn0" DESC',
|
|
$query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setOrderBy('RAND()');
|
|
$this->assertEquals(
|
|
'SELECT *, RAND() AS "_SortColumn0" FROM MyTable ORDER BY "_SortColumn0" ASC',
|
|
$query->sql());
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->addFrom('INNER JOIN SecondTable USING (ID)');
|
|
$query->addFrom('INNER JOIN ThirdTable USING (ID)');
|
|
$query->setOrderBy('MyName');
|
|
$this->assertEquals(
|
|
'SELECT * FROM MyTable '
|
|
. 'INNER JOIN SecondTable USING (ID) '
|
|
. 'INNER JOIN ThirdTable USING (ID) '
|
|
. 'ORDER BY MyName ASC',
|
|
$query->sql());
|
|
}
|
|
|
|
public function testNullLimit() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setLimit(null);
|
|
|
|
$this->assertEquals(
|
|
'SELECT * FROM MyTable',
|
|
$query->sql()
|
|
);
|
|
}
|
|
|
|
public function testZeroLimit() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setLimit(0);
|
|
|
|
$this->assertEquals(
|
|
'SELECT * FROM MyTable',
|
|
$query->sql()
|
|
);
|
|
}
|
|
|
|
public function testZeroLimitWithOffset() {
|
|
if(!(DB::getConn() instanceof MySQLDatabase || DB::getConn() instanceof SQLite3Database
|
|
|| DB::getConn() instanceof PostgreSQLDatabase)) {
|
|
$this->markTestIncomplete();
|
|
}
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom("MyTable");
|
|
$query->setLimit(0, 99);
|
|
|
|
$this->assertEquals(
|
|
'SELECT * FROM MyTable LIMIT 0 OFFSET 99',
|
|
$query->sql()
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @expectedException InvalidArgumentException
|
|
*/
|
|
public function testNegativeLimit() {
|
|
$query = new SQLQuery();
|
|
$query->setLimit(-10);
|
|
}
|
|
|
|
/**
|
|
* @expectedException InvalidArgumentException
|
|
*/
|
|
public function testNegativeOffset() {
|
|
$query = new SQLQuery();
|
|
$query->setLimit(1, -10);
|
|
}
|
|
|
|
/**
|
|
* @expectedException InvalidArgumentException
|
|
*/
|
|
public function testNegativeOffsetAndLimit() {
|
|
$query = new SQLQuery();
|
|
$query->setLimit(-10, -10);
|
|
}
|
|
|
|
public function testReverseOrderBy() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('MyTable');
|
|
|
|
// default is ASC
|
|
$query->setOrderBy("Name");
|
|
$query->reverseOrderBy();
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY Name DESC',$query->sql());
|
|
|
|
$query->setOrderBy("Name DESC");
|
|
$query->reverseOrderBy();
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY Name ASC',$query->sql());
|
|
|
|
$query->setOrderBy(array("Name" => "ASC"));
|
|
$query->reverseOrderBy();
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY Name DESC',$query->sql());
|
|
|
|
$query->setOrderBy(array("Name" => 'DESC', 'Color' => 'asc'));
|
|
$query->reverseOrderBy();
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable ORDER BY Name ASC, Color DESC',$query->sql());
|
|
|
|
$query->setOrderBy('implode("MyName","Color") DESC');
|
|
$query->reverseOrderBy();
|
|
|
|
$this->assertEquals(
|
|
'SELECT *, implode("MyName","Color") AS "_SortColumn0" FROM MyTable ORDER BY "_SortColumn0" ASC',
|
|
$query->sql());
|
|
}
|
|
|
|
public function testFiltersOnID() {
|
|
$query = new SQLQuery();
|
|
$query->setWhere("ID = 5");
|
|
$this->assertTrue(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is true with simple unquoted column name"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("ID=5");
|
|
$this->assertTrue(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is true with simple unquoted column name and no spaces in equals sign"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("Identifier = 5");
|
|
$this->assertFalse(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is false with custom column name (starting with 'id')"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("ParentID = 5");
|
|
$this->assertFalse(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is false with column name ending in 'ID'"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("MyTable.ID = 5");
|
|
$this->assertTrue(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is true with table and column name"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("MyTable.ID = 5");
|
|
$this->assertTrue(
|
|
$query->filtersOnID(),
|
|
"filtersOnID() is true with table and quoted column name "
|
|
);
|
|
}
|
|
|
|
public function testFiltersOnFK() {
|
|
$query = new SQLQuery();
|
|
$query->setWhere("ID = 5");
|
|
$this->assertFalse(
|
|
$query->filtersOnFK(),
|
|
"filtersOnFK() is true with simple unquoted column name"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("Identifier = 5");
|
|
$this->assertFalse(
|
|
$query->filtersOnFK(),
|
|
"filtersOnFK() is false with custom column name (starting with 'id')"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("MyTable.ParentID = 5");
|
|
$this->assertTrue(
|
|
$query->filtersOnFK(),
|
|
"filtersOnFK() is true with table and column name"
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setWhere("MyTable.`ParentID`= 5");
|
|
$this->assertTrue(
|
|
$query->filtersOnFK(),
|
|
"filtersOnFK() is true with table and quoted column name "
|
|
);
|
|
}
|
|
|
|
public function testInnerJoin() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('MyTable');
|
|
$query->addInnerJoin('MyOtherTable', 'MyOtherTable.ID = 2');
|
|
$query->addLeftJoin('MyLastTable', 'MyOtherTable.ID = MyLastTable.ID');
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable '.
|
|
'INNER JOIN "MyOtherTable" ON MyOtherTable.ID = 2 '.
|
|
'LEFT JOIN "MyLastTable" ON MyOtherTable.ID = MyLastTable.ID',
|
|
$query->sql()
|
|
);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom('MyTable');
|
|
$query->addInnerJoin('MyOtherTable', 'MyOtherTable.ID = 2', 'table1');
|
|
$query->addLeftJoin('MyLastTable', 'MyOtherTable.ID = MyLastTable.ID', 'table2');
|
|
|
|
$this->assertEquals('SELECT * FROM MyTable '.
|
|
'INNER JOIN "MyOtherTable" AS "table1" ON MyOtherTable.ID = 2 '.
|
|
'LEFT JOIN "MyLastTable" AS "table2" ON MyOtherTable.ID = MyLastTable.ID',
|
|
$query->sql()
|
|
);
|
|
}
|
|
|
|
|
|
public function testSetWhereAny() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('MyTable');
|
|
|
|
$query->setWhereAny(array("Monkey = 'Chimp'", "Color = 'Brown'"));
|
|
$this->assertEquals("SELECT * FROM MyTable WHERE (Monkey = 'Chimp' OR Color = 'Brown')",$query->sql());
|
|
}
|
|
|
|
public function testSelectFirst() {
|
|
|
|
// Test first from sequence
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$result = $query->firstRow()->execute();
|
|
|
|
$this->assertCount(1, $result);
|
|
foreach($result as $row) {
|
|
$this->assertEquals('Object 1', $row['Name']);
|
|
}
|
|
|
|
// Test first from empty sequence
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$query->setWhere(array("\"Name\" = 'Nonexistent Object'"));
|
|
$result = $query->firstRow()->execute();
|
|
$this->assertCount(0, $result);
|
|
|
|
// Test that given the last item, the 'first' in this list matches the last
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$query->setLimit(1, 1);
|
|
$result = $query->firstRow()->execute();
|
|
$this->assertCount(1, $result);
|
|
foreach($result as $row) {
|
|
$this->assertEquals('Object 2', $row['Name']);
|
|
}
|
|
}
|
|
|
|
public function testSelectLast() {
|
|
|
|
// Test last in sequence
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$result = $query->lastRow()->execute();
|
|
|
|
$this->assertCount(1, $result);
|
|
foreach($result as $row) {
|
|
$this->assertEquals('Object 2', $row['Name']);
|
|
}
|
|
|
|
// Test last from empty sequence
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$query->setWhere(array("\"Name\" = 'Nonexistent Object'"));
|
|
$result = $query->lastRow()->execute();
|
|
$this->assertCount(0, $result);
|
|
|
|
// Test that given the first item, the 'last' in this list matches the first
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('"Name"');
|
|
$query->setLimit(1);
|
|
$result = $query->lastRow()->execute();
|
|
$this->assertCount(1, $result);
|
|
foreach($result as $row) {
|
|
$this->assertEquals('Object 1', $row['Name']);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Tests aggregate() function
|
|
*/
|
|
public function testAggregate() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setGroupBy('"Common"');
|
|
|
|
$queryClone = $query->aggregate('COUNT(*)', 'cnt');
|
|
$result = $queryClone->execute();
|
|
$this->assertEquals(array(2), $result->column('cnt'));
|
|
}
|
|
|
|
/**
|
|
* Tests that an ORDER BY is only added if a LIMIT is set.
|
|
*/
|
|
public function testAggregateNoOrderByIfNoLimit() {
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('Common');
|
|
$query->setLimit(array());
|
|
|
|
$aggregate = $query->aggregate('MAX("ID")');
|
|
$limit = $aggregate->getLimit();
|
|
$this->assertEquals(array(), $aggregate->getOrderBy());
|
|
$this->assertEquals(array(), $limit);
|
|
|
|
$query = new SQLQuery();
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy('Common');
|
|
$query->setLimit(2);
|
|
|
|
$aggregate = $query->aggregate('MAX("ID")');
|
|
$limit = $aggregate->getLimit();
|
|
$this->assertEquals(array('Common' => 'ASC'), $aggregate->getOrderBy());
|
|
$this->assertEquals(array('start' => 0, 'limit' => 2), $limit);
|
|
}
|
|
|
|
/**
|
|
* Test that "_SortColumn0" is added for an aggregate in the ORDER BY
|
|
* clause, in combination with a LIMIT and GROUP BY clause.
|
|
* For some databases, like MSSQL, this is a complicated scenario
|
|
* because a subselect needs to be done to query paginated data.
|
|
*/
|
|
public function testOrderByContainingAggregateAndLimitOffset() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect(array('"Name"', '"Meta"'));
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
$query->setOrderBy(array('MAX("Date")'));
|
|
$query->setGroupBy(array('"Name"', '"Meta"'));
|
|
$query->setLimit('1', '1');
|
|
|
|
$records = array();
|
|
foreach($query->execute() as $record) {
|
|
$records[] = $record;
|
|
}
|
|
|
|
$this->assertCount(1, $records);
|
|
|
|
$this->assertEquals('Object 2', $records[0]['Name']);
|
|
$this->assertEquals('2012-05-01 09:00:00', $records['0']['_SortColumn0']);
|
|
}
|
|
|
|
/**
|
|
* Test passing in a LIMIT with OFFSET clause string.
|
|
*/
|
|
public function testLimitSetFromClauseString() {
|
|
$query = new SQLQuery();
|
|
$query->setSelect('*');
|
|
$query->setFrom('"SQLQueryTest_DO"');
|
|
|
|
$query->setLimit('20 OFFSET 10');
|
|
$limit = $query->getLimit();
|
|
$this->assertEquals(20, $limit['limit']);
|
|
$this->assertEquals(10, $limit['start']);
|
|
}
|
|
|
|
}
|
|
|
|
class SQLQueryTest_DO extends DataObject implements TestOnly {
|
|
private static $db = array(
|
|
"Name" => "Varchar",
|
|
"Meta" => "Varchar",
|
|
"Common" => "Varchar",
|
|
"Date" => "SS_Datetime"
|
|
);
|
|
}
|
|
|
|
class SQLQueryTestBase extends DataObject implements TestOnly {
|
|
private static $db = array(
|
|
"Title" => "Varchar",
|
|
);
|
|
}
|
|
|
|
class SQLQueryTestChild extends SQLQueryTestBase {
|
|
private static $db = array(
|
|
"Name" => "Varchar",
|
|
);
|
|
|
|
private static $has_one = array(
|
|
);
|
|
}
|