mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
8c3ba81052
* FIX PHP 8.1 support in MySQLiConnector::query errors The default error reporting mode in PHP 8.1 has changed from using errors reported on the connection handle to throwing mysqli_sql_exception. query() makes no allowance for this, and functions up the call stack expect to catch Silverstripe\ORM\Connect\DatabaseException instead - resulting in the MySQLi exception going all the way up to halt the system. We can use a try, catch, and finally to retain backwards compatibility, no matter which setting (e.g. PHP version default) someone has enabled. * Move MySQLConnector test skip call into setUp() As review feedback; marking the test as skipped in a private function obfuscated where the call was happening and made it harder to skimread the tests. Moving this into a setUp function makes it obvious the check is run before each test case, and skipped if necessary. |
||
|---|---|---|
| .. | ||
| Control | ||
| Core | ||
| Dev | ||
| Forms | ||
| i18n | ||
| Logging | ||
| ORM | ||
| Security | ||
| View | ||